https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-641 OpenFlowPlugin <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-641

Milestone: Update translators

Bug Resolved Done Tomas Slusny Jozef Bacigal Wed, 16 Mar 2016 07:01:30 +0000 Mon, 27 Sep 2021 09:01:45 +0000 Mon, 8 Aug 2016 08:37:45 +0000 General 0 2 <p>So, after discussion with Michal Rehák, this is what I am currently trying to achieve:</p> <ul class="alternate" type="square"> <li>Split giant ActionConvertor (1215 lines) and MatchConvertorImpl (2000 lines) classes to smaller pieces to be more managable and get rid of big if-else chains in these two classes</li> <li>Update all convertors in package org.opendaylight.openflowplugin.openflow.md.core.sal.convertor to use one generic method to convert between SAL and OPF model (and vice versa) if possible</li> <li>Update and fix all unit tests for convertors in above package to increase coverage and test all possibilities of different conversion types</li> </ul> <p>So, in short, with these changes, convertors (converters) should be more manageable and easier to modify, when needed.</p> <p>Here are links to GERRIT:</p> <ul class="alternate" type="square"> <li><a href="https://git.opendaylight.org/gerrit/#/c/40863/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40863/</a> - ConvertorManager</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40865" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40865</a> - TableFeaturesConvertor</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40868" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40868</a> - TableFeaturesResponseConvertor</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40870" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40870</a> - MeterConvertor</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40875" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40875</a> - MeterStatsResponseConvertor, MeterConfigStatsResponseConvertor</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40877" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40877</a> - PortConvertor</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40929" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40929</a> - MatchConvertor</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40937" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40937</a> - ActionConvertor, ActionResponseConvertor</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40944" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40944</a> - GroupConvertor, GroupStatsConvertor, GroupDescStatsConvertor</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40986" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40986</a> - PacketOutConvertor</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/40994" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40994</a> - FlowConvertor, FlowStatsResponseConvertor, FlowInstructionResponseConvertor</li> </ul> <p>Attaching results of CBench tests on master and with new convertor changes, both using same configuration and on same machine.</p> <p>Configuration:<br/> controller: localhost<br/> port: 6633<br/> loops: 20<br/> msPerTest: 10000<br/> macPerSwitch: 1000<br/> startupDelay: 1000<br/> warmup: 1<br/> switches: 16</p> <p>To see actual graph, just open out3d.pdf, or run `gnuplot out3d.plot`.<br/> For each branch (master, convertors) I did 3 tests to gather more data.</p> <p>Attachment cbench-results.tar.gz has been added with description: CBench test results</p> <p>Hi, this may have introduced a regression in NetIDE.</p> <p>See <a href="https://gist.github.com/mosieurlaurin/059de066ef2849489534da921e4378bf" class="external-link" target="_blank" rel="nofollow noopener">https://gist.github.com/mosieurlaurin/059de066ef2849489534da921e4378bf</a></p> <p>NetIDE cannot compile properly.</p> <p>I submitted patch that will fix that compile errors to NetIDE project here: <a href="https://git.opendaylight.org/gerrit/#/c/43302" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/43302</a></p> Development External issue ID 5540 External issue URL Issue Type ODL SR Target Milestone Rank 0|i032en: