https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-657 OpenFlowPlugin <p>Subclasses of org.opendaylight.openflowplugin.impl.services.AbstractService should have their own field for accessing NodeId+DatapathId+version. For example these classes use NodeId/DatapathId just for logging:<br/> a/ org.opendaylight.openflowplugin.impl.statistics.services.dedicated.StatisticsGatheringService<br/> b/ org.opendaylight.openflowplugin.impl.statistics.services.dedicated.StatisticsGatheringOnTheFlyService<br/> c/ org.opendaylight.openflowplugin.impl.statistics.services.MatchingFlowsInTableService<br/> d/ ... (all other subclasses)</p> <p>Lets used DeviceState for accessing at least:</p> <ul class="alternate" type="square"> <li>nodeId</li> <li>version</li> <li>datapathId (accesible in DeviceState.getFeatures())</li> </ul> <p>This deviceContext is propagated also to this transform utility functions but it is not necessary (propagate there only DeviceState):<br/> e/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.FlowStatisticsToNotificationTransformer.transformToNotification(List&lt;MultipartReply&gt;, DeviceContext, OpenflowVersion, TransactionId)<br/> f/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.GroupStatisticsToNotificationTransformer.transformToNotification(List&lt;MultipartReply&gt;, DeviceContext, OpenflowVersion, TransactionId)<br/> g/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.MeterStatisticsToNotificationTransformer.transformToNotification(List&lt;MultipartReply&gt;, DeviceContext, OpenflowVersion, TransactionId)<br/> h/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.QueueStatisticsToNotificationTransformer.transformToNotification(List&lt;MultipartReply&gt;, DeviceContext, OpenflowVersion, TransactionId)<br/> i/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.NodeConnectorStatisticsToNotificationTransformer.transformToNotification(List&lt;MultipartReply&gt;, DeviceContext, OpenflowVersion, TransactionId)<br/> j/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.QueueStatisticsToNotificationTransformer.transformToNotification(List&lt;MultipartReply&gt;, DeviceContext, OpenflowVersion, TransactionId)</p> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-657

NodeId+DatapathId in Services (remove dependency on DeviceContext)

Bug Resolved Done Tomas Slusny Jozef Slezák Wed, 23 Mar 2016 12:35:00 +0000 Mon, 27 Sep 2021 09:01:46 +0000 Mon, 16 May 2016 11:42:45 +0000 General 0 2 <p>I am bit confused about the first half of the description. Should I add DeviceState to AbstractService constructor and then modify AbstractService.getVersion() and AbstractService.getDatapathId() to get these values from DeviceState and not DeviceContext.Features? And then add another method, AbstractService.getNodeId() what will return NodeId of DeviceState and update subclasses according to these changes? Because, even with these changes, I cannot replace usage of the DeviceContext, because subclasses are using MessageSpy from DeviceContext.</p> <p>GERRIT:<br/> <a href="https://git.opendaylight.org/gerrit/37082" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/37082</a><br/> <a href="https://git.opendaylight.org/gerrit/37083" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/37083</a></p> <p>Transformers merged.</p> Development External issue ID 5592 External issue URL Issue Type ODL SR Target Milestone Rank 0|i032i7: