[OPNFLWPLUG-709] Li plugin failed to push master role request occasionally

Mon, 27 Sep 2021 09:01:50 +0000

As I observed, when a switch connects to the Lithium version of OpenFlow plugin, plugin sets role by two steps:
step 1 - firstly push a slave role request.
step 2 - Received EOS messages and push a master role request as a response.

I found step 2 failed occasionally, especially when the switch reconnects to the ODL Controller.

The related messages in log is as following :

{targetType=interface org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node, path=[org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819 .Nodes, org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node[key=NodeKey [_id=Uri [_value=openflow:1]]]]}

], augmentation=[]]
2016-06-14 13:49:00,373 | INFO | entLoopGroup-5-4 | SalRoleServiceImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | Requesting state change to BECOMESLAVE
2016-06-14 13:49:00,377 | INFO | entLoopGroup-5-4 | SalRoleServiceImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | RoleChangeTask called on device:openflow:1 OFPRole:BECOMESLAVE
2016-06-14 13:49:00,382 | INFO | entLoopGroup-5-4 | RoleService | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | getGenerationIdFromDevice called for device:openflow:1
2016-06-14 13:49:00,388 | INFO | entLoopGroup-5-4 | RoleContextImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | Initialization main candidate for node Uri [_value=openflow:1]
2016-06-14 13:49:00,393 | DEBUG | entLoopGroup-5-4 | RoleContextImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | Register candidate for entity Entity{type='openflow', id=/(urn:op
endaylight:params:xml:ns:yang:controller:md:sal:core:general-entity?revision=2015-08-20)entity/entity[

{(urn:opendaylight:params:xml:ns:yang:controller:md:sal:core:general-entity?revision=2015-08-20)name=openflow:1}

]}
2016-06-14 13:49:00,398 | DEBUG | entLoopGroup-5-4 | RoleManagerImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | Notifying registered listeners for role initialization done, no.
of listeners 1
2016-06-14 13:49:00,404 | INFO | entLoopGroup-5-4 | LifecycleConductorImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | initialization phase for node Uri [_value=openflow:1] in role con
text was successful, continuing to next context.
2016-06-14 13:49:00,401 | DEBUG | lt-dispatcher-25 | RoleManagerImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | Received EOS message: wasOwner:false isOwner:true hasOwner:true f
or entity type openflow and node ~~> no watching entity, disregarding notification <~~
2016-06-14 13:49:00,413 | INFO | entLoopGroup-5-4 | RoleService | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | submitRoleChange called for device:Uri [_value=openflow:1], role:
BECOMESLAVE
2016-06-14 13:49:00,414 | DEBUG | lt-dispatcher-25 | RoleManagerImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | OwnershipChange EntityOwnershipChanged [entity=Entity{type='openf
low', id=/(urn:opendaylight:params:xml:ns:yang:controller:md:sal:core:general-entity?revision=2015-08-20)entity/entity[

{(urn:opendaylight:params:xml:ns:yang:controller:md:sal:core:general-entity?revision=2015-08-20)name= openflow:1}

]}, wasOwner=false, isOwner=true, hasOwner=true]
2016-06-14 13:49:00,421 | INFO | entLoopGroup-5-4 | RoleService | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | submitRoleChange onSuccess for device:Uri [_value=openflow:1], ro
le:BECOMESLAVE
2016-06-14 13:49:00,424 | INFO | entLoopGroup-5-4 | RoleManagerImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | Role BECOMESLAVE successfully set on device Uri [_value=openflow:
1]
2016-06-14 13:49:00,425 | DEBUG | entLoopGroup-5-4 | RoleManagerImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | Notifying registered listeners for role change, no. of listeners
1
2016-06-14 13:49:00,920 | WARN | entLoopGroup-5-4 | DeviceContextImpl | 182 - org.opendaylight.openflowplugin.impl - 0.2.2.Beryllium-SR2 | Error processing port status message: Cannot write into transacti
on.

I guess there exists a race condition between thread entLoopGroup-5-4 and lt-dispatcher-25.

OpenDaylight JIRA

[OPNFLWPLUG-709] Li plugin failed to push master role request occasionally