https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-767 OpenFlowPlugin <p>Bouncing a switch connection produces stale entry in entity owner and further connection requests rejects.</p> <p>Karaf log with DEBUG is attached.</p> <p>BR/Luis</p> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-767

Switch connection bounce generates wrong entity owner in cluster env

Bug Resolved Done Luis Gomez Luis Gomez Thu, 8 Sep 2016 23:47:54 +0000 Mon, 27 Sep 2021 09:01:54 +0000 Fri, 9 Dec 2016 08:31:48 +0000 General 0 5 <p>Attachment karaf_log_device_connection_bounce.txt has been added with description: Karaf log</p> <p>to reproduce the above:</p> <p>1) start mininet 1 switch (s1) pointing to any of the cluster instances (e.g. 192.168.0.101)<br/> 2) Run the following script in the mininet system to bounce connection quickly:</p> <p>#!/bin/bash<br/> sudo ovs-vsctl del-controller s1<br/> sleep 0.2<br/> sudo ovs-vsctl set-controller s1 "tcp:192.168.0.101"</p> <p>Posted patch that will hopefully fix this issue: <a href="https://git.opendaylight.org/gerrit/#/c/45526" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45526</a> . Luis, can you recheck it?</p> <p>So I partially fixed this issue with patch I posted earlier, but I think there is problem with Singleton (sometimes, it is sending SLAVE instead of MASTER) so I raised bug in mdsal here: <a href="https://bugs.opendaylight.org/show_bug.cgi?id=6710" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=6710</a> and added it as blocker for this issue.</p> <p>I see some NPEs:</p> <p>2016-09-08 23:35:05,409 | ERROR | pool-31-thread-1 | ExecutionList | 65 - com.google.guava - 18.0.0 | RuntimeException while executing runnable com.google.common.util.concurrent.Futures$6@66487d12 with executor INSTANCE<br/> java.lang.NullPointerException<br/> at org.opendaylight.openflowplugin.impl.device.DeviceContextImpl.shutdownConnection(DeviceContextImpl.java:568)</p> <p>but looks like that is fixed by Tomas's patch.</p> <p>The attached log is from member-1 which wasn't the EOS shard leader - member-2 was. When device connections were dropped, I see the candidates for the ServiceEntityType removed for member-3 and member-2. I don't see the candidate removed for member-1 - I assume that's not expected? Maybe the NPE prevented it? In any event, it seems member-1 remained as candidate and thus the owner. As far as the EOS is concerned, this is correct.</p> <p>I don't see any evidence of an entity with an owner that isn't a candidate as we saw in the CI test a couple weeks ago. However I did find an issue that can result in that scenario that I fixed with <a href="https://git.opendaylight.org/gerrit/#/c/45516/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45516/</a>.</p> <p>Added another patch on Gerrit: <a href="https://git.opendaylight.org/gerrit/#/c/46321" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/46321</a><br/> that will hopefully make unregistering process of cluster singleton services better and more stable, and that means that connection bounce will also work better.</p> <p>Gerrit: <a href="https://git.opendaylight.org/gerrit/#/c/46390/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/46390/</a></p> <p>This should fix all errors with fast connection and disconnection of device. This patch depends on this <a href="https://git.opendaylight.org/gerrit/#/c/45638/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45638/</a> patch in controller and this patch <a href="https://git.opendaylight.org/gerrit/#/c/46175/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/46175/</a> in mdsal. After these 3 will be merged, I think everything should be fine.</p> <p>Thanks Tomas for spending time in this <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>So, both mdsal (<a href="https://git.opendaylight.org/gerrit/#/c/46175/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/46175/</a>) and controller (<a href="https://git.opendaylight.org/gerrit/#/c/45638/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45638/</a>) changes what was required to solve this issue (and other related) issues was merged in master. So if you can Luis, can you test this connection bounce on my patch (<a href="https://git.opendaylight.org/gerrit/#/c/46390/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/46390/</a>) if it is really working?</p> <p>I am testing your patch today, I will let you know the results.</p> <p>(In reply to Luis Gomez from comment #9)<br/> &gt; I am testing your patch today, I will let you know the results.</p> <p>Luis , any updates on this ?</p> <p>This is fixed now.</p> Blocks MDSAL-197 Development External issue ID 6672 External issue URL ODL SR Target Milestone Rank 0|i0336n: