OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [OPNFLWPLUG-857] OpenFlowPluginProviderImpl.setFlowRemovedNotification performs self-assignment https://jira.opendaylight.org/browse/OPNFLWPLUG-857 OpenFlowPlugin <p>Looking at Boron-SR2, <br/> ./openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/OpenFlowPluginProviderImpl.java, line 180.</p> <p>I believe this method is incorrect:<br/> public void setFlowRemovedNotification(boolean isFlowRemovedNotificationOn) </p> { this.isFlowRemovedNotificationOn = this.isFlowRemovedNotificationOn; } <p>It should be<br/> public void setFlowRemovedNotification(final boolean isFlowRemovedNotificationOn) </p> { this.isFlowRemovedNotificationOn = isFlowRemovedNotificationOn; } <p>As it is currently coded, it does not function as intended.</p> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-857 OpenFlowPluginProviderImpl.setFlowRemovedNotification performs self-assignment Bug Resolved Done Jim West Jim West Mon, 20 Feb 2017 14:26:19 +0000 Mon, 27 Sep 2021 09:02:00 +0000 Fri, 3 Mar 2017 14:35:39 +0000 General 0 2 <p>This defect was caused by this commit:<br/> <a href="https://github.com/opendaylight/openflowplugin/commit/a47ccf345dcabb0dbd3f2b15cce79e587149c572" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/openflowplugin/commit/a47ccf345dcabb0dbd3f2b15cce79e587149c572</a></p> <p>In Nov 2016</p> <p>I fixed this issue as part of this patch: <a href="https://git.opendaylight.org/gerrit/#/c/50819/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/50819/</a> because I do not knew that there is already bug reported for it, and creating new bug was not worth it for that small issue. So, when that patch will be merged, this bug can be closed.</p> <p>Patch <a href="https://git.opendaylight.org/gerrit/#/c/50819/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/50819/</a> has been merged.</p> Development External issue ID 7822 External issue URL Rank 0|i033qn: