https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-930 OpenFlowPlugin <p>While using both Nitrogen and master, I am running into a problem with how the Openflow plugin writes the Flow IDs in Operational. The Flow IDs are as expected in the config data store, but when the flows get installed in an OVS bridge and consequently written to the operational data store, the Flow IDs arent the same.</p> <p>This appears to happen only for the flows that have the NSH (Network Service Headers) Nicira extensions.</p> <p>Here is a summary of the flow IDs inconsistency:</p> <p>curl -H "Content-Type: application/json" -X GET --user admin:admin <a href="http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:99999963124801/table/4" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:99999963124801/table/4</a> | python -m json.tool | grep \"id\"</p> <p> "id": "nextHop_255_8388627",<br/> "id": "nextHop_255_19",<br/> "id": "matchAny_4_10",<br/> "id": 4</p> <p>curl -H "Content-Type: application/json" -X GET --user admin:admin <a href="http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:99999963124801/table/4" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:99999963124801/table/4</a> | python -m json.tool | grep \"id\"</p> <p> "id": "matchAny_4_10",<br/> "id": "#UF$TABLE*4-3",<br/> "id": "#UF$TABLE*4-4",<br/> "id": 4</p> <p>And here is a complete dump of the config and operational flows:</p> <p>--------------------<br/> Config data store<br/> --------------------</p> <p>curl -H "Content-Type: application/json" -X GET --user admin:admin <a href="http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:99999963124801/table/4" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:99999963124801/table/4</a> | python -m json.tool</p> <p>{<br/> "flow-node-inventory:table": [<br/> {<br/> "flow": [<br/> {<br/> "barrier": false,<br/> "cookie": 20,<br/> "cookie_mask": 20,<br/> "flags": "",<br/> "flow-name": "nextHop_255_8388627",<br/> "hard-timeout": 0,<br/> "id": "nextHop_255_8388627",<br/> "idle-timeout": 0,<br/> "instructions": {<br/> "instruction": [<br/> {<br/> "apply-actions": {<br/> "action": [<br/> {<br/> "openflowplugin-extension-nicira-action:nx-reg-load": {<br/> "dst": </p> { "end": 31, "nx-tun-ipv4-dst": [ null ], "start": 0 } <p>,<br/> "value": 167772170<br/> },<br/> "order": 0<br/> }<br/> ]<br/> },<br/> "order": 0<br/> },<br/> {<br/> "go-to-table": </p> { "table_id": 10 } <p>,<br/> "order": 1<br/> }<br/> ]<br/> },<br/> "match": {<br/> "openflowplugin-extension-general:extension-list": [<br/> {<br/> "extension": {<br/> "openflowplugin-extension-nicira-match:nxm-nx-nsp": </p> { "value": 8388627 } <p> },<br/> "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsp-key"<br/> },<br/> {<br/> "extension": {<br/> "openflowplugin-extension-nicira-match:nxm-nx-nsi": </p> { "nsi": 255 } <p> },<br/> "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsi-key"<br/> }<br/> ]<br/> },<br/> "priority": 550,<br/> "strict": false,<br/> "table_id": 4<br/> },<br/> {<br/> "barrier": false,<br/> "cookie": 20,<br/> "cookie_mask": 20,<br/> "flags": "",<br/> "flow-name": "nextHop_255_19",<br/> "hard-timeout": 0,<br/> "id": "nextHop_255_19",<br/> "idle-timeout": 0,<br/> "instructions": {<br/> "instruction": [<br/> {<br/> "apply-actions": {<br/> "action": [<br/> {<br/> "openflowplugin-extension-nicira-action:nx-reg-load": {<br/> "dst": </p> { "end": 31, "nx-tun-ipv4-dst": [ null ], "start": 0 } <p>,<br/> "value": 167772170<br/> },<br/> "order": 0<br/> }<br/> ]<br/> },<br/> "order": 0<br/> },<br/> {<br/> "go-to-table": </p> { "table_id": 10 } <p>,<br/> "order": 1<br/> }<br/> ]<br/> },<br/> "match": {<br/> "openflowplugin-extension-general:extension-list": [<br/> {<br/> "extension": {<br/> "openflowplugin-extension-nicira-match:nxm-nx-nsp": </p> { "value": 19 } <p> },<br/> "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsp-key"<br/> },<br/> {<br/> "extension": {<br/> "openflowplugin-extension-nicira-match:nxm-nx-nsi": </p> { "nsi": 255 } <p> },<br/> "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsi-key"<br/> }<br/> ]<br/> },<br/> "priority": 550,<br/> "strict": false,<br/> "table_id": 4<br/> },<br/> {<br/> "barrier": false,<br/> "cookie": 20,<br/> "cookie_mask": 20,<br/> "flags": "",<br/> "flow-name": "matchAny_4_10",<br/> "hard-timeout": 0,<br/> "id": "matchAny_4_10",<br/> "idle-timeout": 0,<br/> "instructions": {<br/> "instruction": [<br/> {<br/> "go-to-table": </p> { "table_id": 10 } <p>,<br/> "order": 0<br/> }<br/> ]<br/> },<br/> "match": {},<br/> "priority": 5,<br/> "strict": false,<br/> "table_id": 4<br/> }<br/> ],<br/> "id": 4<br/> }<br/> ]<br/> }</p> <p>---------------<br/> Operational<br/> ---------------</p> <p>curl -H "Content-Type: application/json" -X GET --user admin:admin <a href="http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:99999963124801/table/4" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:99999963124801/table/4</a> | python -m json.tool</p> <p>{<br/> "flow-node-inventory:table": [<br/> {<br/> "flow": [<br/> {<br/> "cookie": 20,<br/> "cookie_mask": 0,<br/> "flags": "",<br/> "hard-timeout": 0,<br/> "id": "matchAny_4_10",<br/> "idle-timeout": 0,<br/> "instructions": {<br/> "instruction": [<br/> {<br/> "go-to-table": </p> { "table_id": 10 } <p>,<br/> "order": 0<br/> }<br/> ]<br/> },<br/> "match": {},<br/> "opendaylight-flow-statistics:flow-statistics": {<br/> "byte-count": 0,<br/> "duration": </p> { "nanosecond": 464000000, "second": 102 } <p>,<br/> "packet-count": 0<br/> },<br/> "priority": 5,<br/> "table_id": 4<br/> },<br/> {<br/> "cookie": 20,<br/> "cookie_mask": 0,<br/> "flags": "",<br/> "hard-timeout": 0,<br/> "id": "#UF$TABLE*4-3",<br/> "idle-timeout": 0,<br/> "instructions": {<br/> "instruction": [<br/> {<br/> "apply-actions": {<br/> "action": [<br/> {<br/> "openflowplugin-extension-nicira-action:nx-reg-load": {<br/> "dst": </p> { "end": 31, "nx-tun-ipv4-dst": [ null ], "start": 0 } <p>,<br/> "value": 167772170<br/> },<br/> "order": 0<br/> }<br/> ]<br/> },<br/> "order": 0<br/> },<br/> {<br/> "go-to-table": </p> { "table_id": 10 } <p>,<br/> "order": 1<br/> }<br/> ]<br/> },<br/> "match": {<br/> "openflowplugin-extension-general:extension-list": [<br/> {<br/> "extension": {<br/> "openflowplugin-extension-nicira-match:nxm-nx-nsp": </p> { "value": 19 } <p> },<br/> "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsp-key"<br/> },<br/> {<br/> "extension": {<br/> "openflowplugin-extension-nicira-match:nxm-nx-nsi": </p> { "nsi": 255 } <p> },<br/> "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsi-key"<br/> }<br/> ]<br/> },<br/> "opendaylight-flow-statistics:flow-statistics": {<br/> "byte-count": 0,<br/> "duration": </p> { "nanosecond": 464000000, "second": 102 } <p>,<br/> "packet-count": 0<br/> },<br/> "priority": 550,<br/> "table_id": 4<br/> },<br/> {<br/> "cookie": 20,<br/> "cookie_mask": 0,<br/> "flags": "",<br/> "hard-timeout": 0,<br/> "id": "#UF$TABLE*4-4",<br/> "idle-timeout": 0,<br/> "instructions": {<br/> "instruction": [<br/> {<br/> "apply-actions": {<br/> "action": [<br/> {<br/> "openflowplugin-extension-nicira-action:nx-reg-load": {<br/> "dst": </p> { "end": 31, "nx-tun-ipv4-dst": [ null ], "start": 0 } <p>,<br/> "value": 167772170<br/> },<br/> "order": 0<br/> }<br/> ]<br/> },<br/> "order": 0<br/> },<br/> {<br/> "go-to-table": </p> { "table_id": 10 } <p>,<br/> "order": 1<br/> }<br/> ]<br/> },<br/> "match": {<br/> "openflowplugin-extension-general:extension-list": [<br/> {<br/> "extension": {<br/> "openflowplugin-extension-nicira-match:nxm-nx-nsp": </p> { "value": 8388627 } <p> },<br/> "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsp-key"<br/> },<br/> {<br/> "extension": {<br/> "openflowplugin-extension-nicira-match:nxm-nx-nsi": </p> { "nsi": 255 } <p> },<br/> "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsi-key"<br/> }<br/> ]<br/> },<br/> "opendaylight-flow-statistics:flow-statistics": {<br/> "byte-count": 0,<br/> "duration": </p> { "nanosecond": 464000000, "second": 102 } <p>,<br/> "packet-count": 0<br/> },<br/> "priority": 550,<br/> "table_id": 4<br/> }<br/> ],<br/> "id": 4,<br/> "opendaylight-flow-table-statistics:flow-table-statistics": </p> { "active-flows": 3, "packets-looked-up": 0, "packets-matched": 0 } <p> }<br/> ]<br/> }</p> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-930

Inconsistent flow IDs between flows in config and operational data stores

Bug Verified Done Luis Gomez Brady Johnson Thu, 17 Aug 2017 23:26:05 +0000 Mon, 27 Sep 2021 09:02:05 +0000 Tue, 12 Dec 2017 00:44:26 +0000 Nitrogen-SR1 General 0 6 <p>Can you try this again with this patch:<a href="https://git.opendaylight.org/gerrit/#/c/62272/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/62272/</a> ?</p> <p>I tested patch set 3 of this patch <span class="error">&#91;0&#93;</span>, and no changes were observed. That is, the problem has not been fixed.</p> <p><span class="error">&#91;0&#93;</span> <a href="https://git.opendaylight.org/gerrit/#/c/62272/3" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/62272/3</a></p> <p>Okay, uploaded new patch, problem was probably with inconsisten extension augmentation class names, so swapped comparison of matches by equal method (what is also checking for classnames) with comparison of matches by hashCode (what is only comparing contents of objects), what should solve this issue, because contents of augmentations are same, but wrapping classes are not.</p> <p>I tested with patch set 4, and no changes were observed. This is still failing.</p> <p>Looks like the proposed patch was abandoned:</p> <p> <a href="https://git.opendaylight.org/gerrit/#/c/62272" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/62272</a></p> <p>Will another patch be proposed then?</p> <p>So as my patch was not solving the issue, it looks like that with extensions there isn't properly working matching of flows, and my patch do not solved that, so I abandoned it. Currently I moved to blocked bugs, so I am not working on another patch that can solve this issue.</p> <p>This bug should have been a blocker from the beginning, since its blocking the SFC statistics collection feature. Because of this bug, I wasnt able to complete the feature in Nitrogen and I cant progress in Oxygen.</p> <p>The result of this failure is inconsistent flow information between the config and operational data store, making the operational flows basically useless since they cant be queried, which is a blocker in and of itself.</p> <p>For those 2 reasons, Im changing this bug to be a blocker.</p> <p>Okay, as there are currently only pending patches I can look at this issue again. I actually found one issue with patch that I created for this issue. I will un-abandon the patch and make small edit in few mins. Can you test that again after the change please?</p> <p>Ok, thanks for looking again.</p> <p>Yes, I can test that again today.</p> <p>I still get the following:</p> <p>$ curl -H "Content-Type: application/json" -X GET --user admin:admin <a href="http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:156930464280132/table/4" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:156930464280132/table/4</a> | python -m json.tool | grep \"id\"<br/> "id": "matchAny_4_10",<br/> "id": "nextHop_255_8388639",<br/> "id": "nextHop_255_31",<br/> "id": 4</p> <p>curl -H "Content-Type: application/json" -X GET --user admin:admin <a href="http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:156930464280132/table/4" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:156930464280132/table/4</a> | python -m json.tool | grep \"id\"<br/> "id": "matchAny_4_10",<br/> "id": "#UF$TABLE*4-3",<br/> "id": "#UF$TABLE*4-4",<br/> "id": 4,</p> <p>Okay I tried to reproduce this on my local machine and I keep getting BADMATCH BADFIELD from OVS. Do I need some special OVS build to have this work? I have OVS 2.7.2 running rn.</p> <p>I think I found the culprit, created custom hashing function for match, can you try this again? Since i cannot try it locally.</p> <p>This is still not working with patch-set 9.</p> <p>To reproduce this yourself, you'll need a version of OVS that supports NSH (Network Service Headers) that you can find here:</p> <p><a href="https://wiki.opendaylight.org/view/Service_Function_Chaining:Main#Building_Open_vSwitch_with_VxLAN-GPE_and_NSH_support" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.opendaylight.org/view/Service_Function_Chaining:Main#Building_Open_vSwitch_with_VxLAN-GPE_and_NSH_support</a></p> <p>Simple steps to reproduce this yourself without SFC, you'll just need the openflow plugin:</p> <p>1) Create an OVS bridge and set the controller to ODL<br/> sudo ovs-vsctl add-br br-int<br/> sudo ovs-vsctl set-manager "tcp:&lt;ODL IP&gt;:6640"<br/> sudo ovs-vsctl set-controller "tcp:&lt;ODL IP&gt;:6653"</p> <p>2) Get the openflow ID:</p> <p>curl -H "Content-Type: application/json" -X GET --user admin:admin <a href="http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/</a> | python -m json.tool | grep "openflow:"</p> <p> "id": "openflow:156930464280132",<br/> "id": "openflow:156930464280132:1",<br/> "id": "openflow:156930464280132:LOCAL",</p> <p>2) Create the flow:<br/> (notice, replace openflow:156930464280132 accordingly)</p> <p>curl -H "Content-Type: application/json" -X PUT --user admin:admin --data '{ "flow": [ { "barrier": false, "cookie": 20, "cookie_mask": 20, "flags": "", "flow-name": "nextHop_255_300", "hard-timeout": 0, "id": "nextHop_255_300", "idle-timeout": 0, "instructions": { "instruction": [ { "apply-actions": { "action": [ { "openflowplugin-extension-nicira-action:nx-reg-load": { "dst": </p> { "end": 31, "nx-tun-ipv4-dst": [ null ], "start": 0 } <p>, "value": 167772170 }, "order": 0 } ] }, "order": 0 }, { "go-to-table": </p> { "table_id": 10 } <p>, "order": 1 } ] }, "match": { "openflowplugin-extension-general:extension-list": [ { "extension": { "openflowplugin-extension-nicira-match:nxm-nx-nsp": </p> { "value": 300 } <p> }, "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsp-key" }, { "extension": { "openflowplugin-extension-nicira-match:nxm-nx-nsi": </p> { "nsi": 255 } <p> }, "extension-key": "openflowplugin-extension-nicira-match:nxm-nx-nsi-key" } ] }, "priority": 550, "strict": false, "table_id": 4 } ] }' <a href="http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:156930464280132/flow-node-inventory:table/4/flow/nextHop_255_300" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:156930464280132/flow-node-inventory:table/4/flow/nextHop_255_300</a></p> <p>3) Query the flow-id in config<br/> (notice, replace openflow:156930464280132 accordingly)</p> <p>curl -H "Content-Type: application/json" -X GET --user admin:admin <a href="http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:156930464280132/table/4" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:156930464280132/table/4</a> | python -m json.tool | grep "\"id\"\:"</p> <p> "id": "nextHop_255_300",<br/> "id": 4</p> <p>4) Query the flow-id in operational<br/> (notice, replace openflow:156930464280132 accordingly)</p> <p>curl -H "Content-Type: application/json" -X GET --user admin:admin <a href="http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:156930464280132/table/4" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:156930464280132/table/4</a> | python -m json.tool | grep "\"id\"\:"</p> <p> "id": "#UF$TABLE*4-1", &lt;== This is wrong<br/> "id": 4,</p> <p>Moved to Anil (from Brady / Tomas).</p> <p>I am able to recreate this issue locally with OVS 2.6.90 + NSH patches. Debugging the issue now.</p> <p>it's an issue related to object hashcode values for the augmentations. To me it looks like this issue will happen for any augmentation on match. In am able to recreate it by augmenting single extension on the flow match</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-quote">"match"</span>: { <span class="code-quote">"openflowplugin-extension-general:extension-list"</span>: [ { <span class="code-quote">"extension"</span>: { <span class="code-quote">"openflowplugin-extension-nicira-match:nxm-nx-nsp"</span>: { <span class="code-quote">"value"</span>: 300 } }, <span class="code-quote">"extension-key"</span>: <span class="code-quote">"openflowplugin-extension-nicira-match:nxm-nx-nsp-key"</span> } ] }, </pre> </div></div> <p>Plugin receives the data change notification when user write flow to data store and uses that data change notification data to generate the flow body (match, instruction) and dump it to switch. And looks like the notifications data is populated lazily and and plugin call the hashcode on Match object ( augmented with the extension) it return different hashcode value, compared to the object build through the normal builder object.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> Augmentation on Match object created using the data change notification data 2017-10-25 12:51:06,532 | INFO | on-dispatcher-43 | FlowRegistryKeyFactory | 285 - org.opendaylight.openflowplugin.impl - 0.5.1.SNAPSHOT | Augmentation : GeneralAugMatchNodesNodeTableFlow{getExtensionList=[ExtensionList{getExtension=Extension{augmentations={<span class="code-keyword">interface</span> org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.nicira.match.rev140714.NxAugMatchNodesNodeTableFlow=NxAugMatchNodesNodeTableFlow{getNxmNxNsp=NxmNxNsp{getValue=300, augmentations={}}}}}, getExtensionKey=<span class="code-keyword">class </span>org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.nicira.match.rev140714.NxmNxNspKey, augmentations={}}]} *hashcode : -745547690 * Augmentation on Match created through builders provided by java bindings 2017-10-25 12:51:09,241 | INFO | entLoopGroup-7-1 | FlowRegistryKeyFactory | 285 - org.opendaylight.openflowplugin.impl - 0.5.1.SNAPSHOT | Augmentation : GeneralAugMatchNodesNodeTableFlow [_extensionList=[ExtensionList [_extension=Extension [augmentation=[NxAugMatchNotifUpdateFlowStats [_nxmNxNsp=NxmNxNsp [_value=300, augmentation=[]], ]]], _extensionKey=<span class="code-keyword">class </span>org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.nicira.match.rev140714.NxmNxNspKey, _key=ExtensionListKey [_extensionKey=<span class="code-keyword">class </span>org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.nicira.match.rev140714.NxmNxNspKey], augmentation=[]]]]* hashcode : -1428243401* </pre> </div></div> <p>It's a same augmentation with the same values, but we see different hashcode value when it comes from data store and through builder object, and that's where plugin thinks it's not a match and store it as a alien flow. It can be workaround by creating builder object for all the augmentation data received through data change notification, but that's not a practical approach because openflowplugin provides the augmentation for vendors to hook their extensions, and everytime someone hook their augmentation, plugin code need to be changes. I am sending my findings to mdsal/yangtools team to provide the feedback on this.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=ebrjohn" class="user-hover" rel="ebrjohn">ebrjohn</a> you mentioned that it only happens to nsh extension flows, but looking at the code it should happen for any flow that augment extension on the match. If you have a flow handy, can you give me a flow that uses other extension and it's working for you. I tried with the following basic nicira extension flow and it was failing as well</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> &lt;match&gt; &lt;ethernet-match&gt; &lt;ethernet-type&gt; &lt;type&gt;2048&lt;/type&gt; &lt;/ethernet-type&gt; &lt;/ethernet-match&gt; &lt;ipv4-destination&gt;10.0.0.0/24&lt;/ipv4-destination&gt; &lt;extension-list xmlns=<span class="code-quote">"urn:opendaylight:openflowplugin:extension:general"</span>&gt; &lt;extension-key xmlns:nxNB=<span class="code-quote">"urn:opendaylight:openflowplugin:extension:nicira:match"</span>&gt;nxNB:nxm-nx-reg0-key&lt;/extension-key&gt; &lt;extension&gt; &lt;nxm-nx-reg xmlns=<span class="code-quote">"urn:opendaylight:openflowplugin:extension:nicira:match"</span>&gt; &lt;reg xmlns:nxSB=<span class="code-quote">"urn:opendaylight:openflowjava:nx:match"</span>&gt;nxSB:nxm-nx-reg0&lt;/reg&gt; &lt;value&gt;42&lt;/value&gt; &lt;/nxm-nx-reg&gt; &lt;/extension&gt; &lt;/extension-list&gt; &lt;/match&gt; </pre> </div></div> <p>I pushed the following patch and it fixes the issue. I tested with the provided flow and it looks good.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/64843" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/64843</a></p> <p>Please get the patch merged and we can start a release candidate build for Nitrogen-SR1. Thanks!</p> <p>Im testing this with SFC now.</p> <p>I tested this in Nitrogen, and it is working as expected <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/> so Im ok with merging the patch in Nitrogen.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=Avishnoi" class="user-hover" rel="Avishnoi">Avishnoi</a> Regarding your previous request to test this with flows that have augment extensions that arent nsh extension flows: there arent any such flows in SFC.</p> <p><a href="https://git.opendaylight.org/gerrit/64913" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/64913</a><br/> <a href="https://git.opendaylight.org/gerrit/64914" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/64914</a></p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=ecelgp" class="user-hover" rel="ecelgp">ecelgp</a> can we add a test in our CSIT test to capture this bug?</p> <p>Make sure your patch is merged in all active branches otherwise this will fail:</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/65012/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/65012/</a></p> <p>Yup, all the patches are now merged.</p> <p> I guess we can close this then.</p> Relates MDSAL-667 Development External issue ID 9007 External issue URL Priority Rank 0|i0346v: