OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [OPNFLWPLUG-95] Port config https://jira.opendaylight.org/browse/OPNFLWPLUG-95 OpenFlowPlugin <p>From the backlog list: <a href="https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Backlog" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Backlog</a></p> <p>Operating System: Mac OS<br/> Platform: PC</p> OPNFLWPLUG-95 Port config Improvement Resolved Won't Do Hariharan Sethuraman Abhijit Kumbhare Thu, 20 Mar 2014 00:53:12 +0000 Mon, 27 Sep 2021 09:01:07 +0000 Wed, 12 Aug 2015 08:57:26 +0000 General 0 5 <p>Requirement:-<br/> The feature Port Config will enable the client to access the port descriptions of all the ports of a node. Since the associated OFPMP_PORT_DESCRIPTION is a multipart request, we need to cache the intermittent results (received as notifications from multipart response) and deliver the PortDescription/Config response to the client. <br/> As part of collecting all multipart response notifications for port description we would need to :</p> <ul class="alternate" type="square"> <li>have some cache mechanism as currently all transformation code is stateless</li> <li>will be responsible for assigning responses based on xid and type</li> <li>will be responsible for timeouting of whole rpc if device disconnects or slows down</li> </ul> <p>Openflowplugin/OFJava:<br/> requestPorts() in ConnectionConductor currently gets the PortDescription after handshake.<br/> In order to provide an RPC we might need to leverage this.</p> <p>I am interested to work on this bug, please let me know about desired implementation and details for this enhancement.</p> <p>I believe we don't need caching of all the multipart response messages, because each multipart response message payload contains data that can make sense without rest of the multipart messages. E.g if a switch has 40 ports (1 to 40) and it decides that it will send the response in 4 multipart message,then it will pack port_description of 10 ports and send in each multipart response. So whenever controller receives the port description multipart message it can decode the port description of these 10 ports and augment it to their respective port/node connector location in the operational data store.</p> <p>Subhash:<br/> If you are still interested in working on this enhancement, you can start with <br/> 1) Read openflow spec to understand the openflow multipart messages<br/> 2) Understand the port description multipart request message and what all data you can get in response to this multipart request.<br/> 3) Look at the translator java files in openflowplugin project <br/> openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/translator</p> <p>It will give you idea about high level control flow and clues on how to hack it.</p> <p>Thanks<br/> Anil</p> <p>subhash kumar singh and Abhijit, I will take this defect and work on. Please let me know if you/someone working on this already.</p> <p>Hope this defect is for Beryllium release.</p> <p>I dont understand the following part</p> <p>"In order to provide an RPC we might need to leverage this."</p> <p>Kamal Rameshan,<br/> Could you explain this?</p> <p>Thanks,<br/> Hari</p> <p>Provided RPC service. Please check port-config from yang-ui for reference. Provided this service for both He and Li code.</p> <p>Changes ref:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/24568/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/24568/</a></p> <p>Provided RPC service. Please check the rest api under port-config module from yang-ui for reference. Provided this service for both He and Li code.</p> <p>Changes ref:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/24568/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/24568/</a></p> <p>(In reply to Hariharan Sethuraman from comment #7)<br/> &gt; Changes ref:<br/> &gt; <a href="https://git.opendaylight.org/gerrit/#/c/24568/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/24568/</a></p> <p>This API dont return the port-config, it updates the port-config in the datastore. Since we are re-using existing helper method for this multipart request, which ultimately updates the datastore. So the consumer should check the returned transaction activity is finished and then retrieve the port-description from the datastore directly.</p> <p>(In reply to Hariharan Sethuraman from comment #8)<br/> &gt; Provided RPC service. Please check the rest api under port-config module<br/> &gt; from yang-ui for reference. Provided this service for both He and Li code.<br/> &gt; <br/> &gt; Changes ref:<br/> &gt; <a href="https://git.opendaylight.org/gerrit/#/c/24568/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/24568/</a><br/> &gt; <br/> &gt; (In reply to Hariharan Sethuraman from comment #7)<br/> &gt; &gt; Changes ref:<br/> &gt; &gt; <a href="https://git.opendaylight.org/gerrit/#/c/24568/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/24568/</a><br/> &gt; <br/> &gt; This API dont return the port-config, it updates the port-config in the<br/> &gt; datastore. Since we are re-using existing helper method for this multipart<br/> &gt; request, which ultimately updates the datastore. So the consumer should<br/> &gt; check the returned transaction activity is finished and then retrieve the<br/> &gt; port-description from the datastore directly.</p> <p>Removed the changes from Li codebase as commented by Michal. Refer code review comments in git.</p> <p>Will be abandoning the changes and close the defect before this week end. Before that please let me know if you have any concerns.</p> <p>Code abandoned. We cant provide RPC despite of the fact that this RPC can be used to update port-configuration on demand. If we provide RPC, it turns out to have an unwanted effect in scenario when port flaps while multipart reply being constructed, this leeway the port status out of sync.</p> Development External issue ID 547 External issue URL Rank 0|i02z1b: