[OVSDB-129] equals check in LoadBalancerConfiguration.java needs to be tweaked

Thu, 6 Nov 2014 16:42:59 +0000

From: Srini Seetharaman srini.seetharaman@gmail.com
Sent: Monday, November 3, 2014 11:41 AM
To: Flavio Fernandes
Cc: Koontz, Marcus G; Sam Hague
Subject: Re: Sonar Issues: Naming - Suspicious equals method name

Hi Flavio, Marcus:
I did mean to override the equals to check on all parameters while ignoring
the index. But, looks like I did a poor job at the equals check, especially
with the string values. I can push a fix and add the @Override qualifier. Did
you have something else in mind?

Srini.

On Mon, Nov 3, 2014 at 10:53 AM, Flavio Fernandes <ffernand@redhat.com
<ffernand@redhat.com> > wrote:

Hi Srini,

From sonar’s comments that Marcus added:

http://sonar.opendaylight.org/drilldown/issues/14975?&rule=pmd%3ASuspiciousEqualsMethodName&rule_sev=CRITICAL&severity=CRITICAL#

"Unsure of whether overriding equals() was purposeful. Will check on mailing
list."

Being the one most familiar with ‘LoadBalancerConfiguration.java’ I thought
of connecting the dots to make sure you have seen this.
Any comments?

Thanks!

— flavio

OpenDaylight JIRA

[OVSDB-129] equals check in LoadBalancerConfiguration.java needs to be tweaked