https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OVSDB-167 ovsdb <p>Because TerminationPointCreate/UpdateCommand are keying off creation/update in the config store, not the underlying OVSDB... attempt to create configuration for an existing termination point will result in an attempt to 'insert' an existing interface in ovsdb, which will call the entire transact to fail.</p> <p>The solution to this is to do a single TerminationPointUpdateCommand in a manner similar to how its done for BridgeUpdateCommand.</p> <p>Operating System: All<br/> Platform: All</p> OVSDB-167

Updates to termination point configuration for existing termination points broken

Bug Resolved Done Unassigned Ed Warnicke Tue, 2 Jun 2015 18:30:28 +0000 Thu, 19 Oct 2017 21:29:06 +0000 Thu, 13 Aug 2015 07:01:47 +0000 unspecified Southbound.Open_vSwitch 0 4 <p>Reproduce:<br/> 1. add port to bridge<br/> 2. Add data to port via ovs-vsctl<br/> 3. then later add extra config to the port via odl</p> <p>I tried following on stable lithium this morning -</p> <p>1. Create bretest2 bridge using postman.<br/> 2. Add port using - "ovs-vsctl add-port brtest2 vlan10 tag=10 &#8211; set Interface vlan10 type=internal"<br/> 3. operational shows following (cut to only the relevant section) -</p> <p> "termination-point": [</p> { "ovsdb:interface-type": "ovsdb:interface-type-internal", "ovsdb:interface-uuid": "c1666aa1-bd40-47ee-9f65-994b838d430f", "ovsdb:name": "vlan10", "ovsdb:ofport": 1, "ovsdb:port-uuid": "fa38cb93-c2f6-4850-8ce4-2a86bd108e6d", "ovsdb:vlan-tag": 10, "tp-id": "vlan10" } <p> ]</p> <p>4. Using postman, added trunks and vlan-mode to this termination-point. Operational changed to -</p> <p> "ovsdb:interface-type": "ovsdb:interface-type-internal",<br/> "ovsdb:interface-uuid": "c1666aa1-bd40-47ee-9f65-994b838d430f",<br/> "ovsdb:name": "vlan10",<br/> "ovsdb:ofport": 1,<br/> "ovsdb:options": [</p> { "option": "remote_ip", "value": "134.134.170.72" } <p> ],<br/> "ovsdb:port-external-ids": [</p> { "external-id-key": "opendaylight-iid", "external-id-value": "/network-topology:network-topology/network-topology:topology[network-topology:topology-id='ovsdb:1']/network-topology:node[network-topology:node-id='ovsdb://134.134.170.72:6640/bridge/brtest2']/network-topology:termination-point[network-topology:tp-id='vlan10']" } <p> ],<br/> "ovsdb:port-uuid": "fa38cb93-c2f6-4850-8ce4-2a86bd108e6d",<br/> "ovsdb:trunks": [<br/> </p> { "trunk": 2 } <p>,</p> { "trunk": 3 } <p> ],<br/> "ovsdb:vlan-mode": "access",<br/> "ovsdb:vlan-tag": 10,<br/> "tp-id": "vlan10"<br/> }</p> <p>5. sudo ovs-vsctl list Port<br/> _<br/> _uuid : fa38cb93-c2f6-4850-8ce4-2a86bd108e6d<br/> bond_active_slave : []<br/> bond_downdelay : 0<br/> bond_fake_iface : false<br/> bond_mode : []<br/> bond_updelay : 0<br/> external_ids : </p> {opendaylight-iid="/network-topology:network-topology/network-topology:topology[network-topology:topology-id='ovsdb:1']/network-topology:node[network-topology:node-id='ovsdb://134.134.170.72:6640/bridge/brtest2']/network-topology:termination-point[network-topology:tp-id='vlan10']"} <p>fake_bridge : false<br/> interfaces : <span class="error">&#91;c1666aa1-bd40-47ee-9f65-994b838d430f&#93;</span><br/> lacp : []<br/> mac : []<br/> name : "vlan10"<br/> other_config : {}<br/> qos : []<br/> statistics : {}<br/> status : {}<br/> tag : 10<br/> trunks : <span class="error">&#91;2, 3&#93;</span><br/> vlan_mode : access</p> <p>Postman collection - <a href="https://www.getpostman.com/collections/330c161d1f46d6273e17" class="external-link" target="_blank" rel="nofollow noopener">https://www.getpostman.com/collections/330c161d1f46d6273e17</a></p> <p>I also tried</p> <p>1. Create bridge using postman.<br/> 2. Add port using postman.<br/> 3. Add interface type using ovs-vsctl ( sudo ovs-vsctl &#8211; set Interface vlan10 type=internal)<br/> 4. $ sudo ovs-vsctl show<br/> b31bca50-69da-4afe-8b14-5f8064cdf316<br/> Manager "ptcp:6640"<br/> is_connected: true<br/> Bridge "brtest2"<br/> Controller "tcp:134.134.170.72:6640"<br/> Port "vlan10"<br/> tag: 10<br/> Interface "vlan10"<br/> type: internal<br/> Port "brtest2"<br/> Interface "brtest2"<br/> type: internal<br/> ovs_version: "2.3.1-git3282e51"</p> <p>4. Update TP with "options" and "trunk" using postman.</p> <p>5. $ sudo ovs-vsctl show<br/> b31bca50-69da-4afe-8b14-5f8064cdf316<br/> Manager "ptcp:6640"<br/> is_connected: true<br/> Bridge "brtest2"<br/> Controller "tcp:134.134.170.72:6640"<br/> Port "vlan10"<br/> tag: 10<br/> trunks: <span class="error">&#91;2, 3&#93;</span><br/> Interface "vlan10"<br/> type: internal<br/> options: </p> {remote_ip="134.134.170.72"} <p> Port "brtest2"<br/> Interface "brtest2"<br/> type: internal<br/> ovs_version: "2.3.1-git3282e51"</p> <p>this is just a reference script. Refer to bug3545.sh for a handy<br/> and easy script to reproduce this bug.</p> <p>Attachment createFloat.sh has been added with description: original script where bug3545.sh came from</p> <ol> <li>steps to reproduce <a href="https://jira.opendaylight.org/browse/OVSDB-167" title="Updates to termination point configuration for existing termination points broken" class="issue-link" data-issue-key="OVSDB-167"><del>OVSDB-167</del></a></li> </ol> <ol> <li>1) start ODL, and do: feature:install odl-ovsdb-openstack</li> <li>Make sure to wait for ODL to be fully up</li> <li></li> <li>2) copy this script to a system that ir running OVS. Make sure OVS is completely</li> <li>cleared. If using ubuntu, that involves something like:<br/> #</li> <li>#!/usr/bin/env bash</li> <li>sudo service openvswitch-switch stop</li> <li>sudo rm -rf /var/log/openvswitch/*</li> <li>sudo rm -rf /etc/openvswitch/conf.db</li> <li>sudo service openvswitch-switch start<br/> #</li> <li>3) make sure you have curl installed in the system where this script is ran<br/> #</li> <li>4) do "sudo ovs-vsctl show" and make sure there are no bridges and OVS is not</li> <li>connected to ODL yet. An example of what it should look like is below:<br/> #</li> <li>$ sudo ovs-vsctl show</li> <li>5c012e23-b5a1-45d4-9a2e-865a3f81c59e</li> <li>ovs_version: "2.3.0"</li> <li>$<br/> #</li> <li>5) change ODL_IP below to the ip address of where ODL is running<br/> #</li> <li>6) run this script. It will:<br/> #</li> <li>- explicitly create bridge br-ex;</li> <li>- connect to ODL</li> <li>- create neutron network</li> <li>- add an ovs port<br/> #</li> <li>7) if bug is reproduced, you will notive that while there is a patch-port in</li> <li>br-int, a patch port in br-ex is not created. Doing this will work around the bug<br/> #</li> <li>sudo ovs-vsctl add-port br-ex patch-int &#8211; set interface patch-int type=patch &#8211; set interface patch-int options:peer=patch-ext</li> </ol> <p>===</p> <p>vagrant@devstack-control:~$ <br/> vagrant@devstack-control:~$ sudo ovs-vsctl show<br/> 75234ef6-ef80-4899-8fda-2b26d1f7c199<br/> Manager "tcp:192.168.50.1:6640"<br/> is_connected: true<br/> Bridge br-ex<br/> Port br-ex<br/> Interface br-ex<br/> type: internal<br/> Bridge br-int<br/> Controller "tcp:192.168.50.1:6653"<br/> is_connected: true<br/> fail_mode: secure<br/> Port br-int<br/> Interface br-int<br/> type: internal<br/> Port "tap79adcba5-19"<br/> Interface "tap79adcba5-19"<br/> type: internal<br/> Port patch-ext<br/> Interface patch-ext<br/> type: patch<br/> options: </p> {peer=patch-int}<br/> ovs_version: "2.3.0"<br/> vagrant@devstack-control:~$ <br/> vagrant@devstack-control:~$ <br/> vagrant@devstack-control:~$ sudo ovs-vsctl add-port br-ex patch-int &#8211; set interface patch-int type=patch &#8211; set interface patch-int options:peer=patch-ext<br/> vagrant@devstack-control:~$ sudo ovs-vsctl show<br/> 75234ef6-ef80-4899-8fda-2b26d1f7c199<br/> Manager "tcp:192.168.50.1:6640"<br/> is_connected: true<br/> Bridge br-ex<br/> Port br-ex<br/> Interface br-ex<br/> type: internal<br/> Port patch-int<br/> Interface patch-int<br/> type: patch<br/> options: {peer=patch-ext}<br/> Bridge br-int<br/> Controller "tcp:192.168.50.1:6653"<br/> is_connected: true<br/> fail_mode: secure<br/> Port br-int<br/> Interface br-int<br/> type: internal<br/> Port "tap79adcba5-19"<br/> Interface "tap79adcba5-19"<br/> type: internal<br/> Port patch-ext<br/> Interface patch-ext<br/> type: patch<br/> options: {peer=patch-int} <p> ovs_version: "2.3.0"<br/> vagrant@devstack-control:~$</p> <p>Attachment bug3545.sh has been added with description: easy script for reproducing this bug</p> <p>Attachment bug3545.out has been added with description: Output of shell script to create network and test this defect.</p> <p>rc='ovs-vsctl: no bridge named br-int</p> <p>Can you also attach the logs from ODL? Looks like the node never connected properly to ODL and netvirt did not create br-int.</p> <p>This line should have enabled the connection: sudo ovs-vsctl set-manager tcp:localhost:6640</p> <p>I missed a step that would enable l3 in ovsdb net-virt</p> <p>w/out that, no patch ports will be created (in any bridge).</p> <p>Will re-submit updated patch and instructions.</p> <p><a href="https://github.com/opendaylight/ovsdb/blob/master/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/BridgeConfigurationManagerImpl.java#L369" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/ovsdb/blob/master/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/BridgeConfigurationManagerImpl.java#L369</a></p> <p>Missed step 0: enable l3 forwarding in ovsdb netvirt:</p> <p> echo 'ovsdb.l3.fwd.enabled=yes' &gt;&gt; ./etc/custom.properties </p> <p>(In reply to Flavio Fernandes from comment #6)<br/> &gt; Created attachment 549 <span class="error">&#91;details&#93;</span><br/> &gt; easy script for reproducing this bug<br/> &gt; <br/> &gt; # steps to reproduce <a href="https://jira.opendaylight.org/browse/OVSDB-167" title="Updates to termination point configuration for existing termination points broken" class="issue-link" data-issue-key="OVSDB-167"><del>OVSDB-167</del></a><br/> &gt; <br/> &gt; # 1) start ODL, and do: feature:install odl-ovsdb-openstack<br/> &gt; # Make sure to wait for ODL to be fully up<br/> &gt; #</p> <ol> <li>steps to reproduce <a href="https://jira.opendaylight.org/browse/OVSDB-167" title="Updates to termination point configuration for existing termination points broken" class="issue-link" data-issue-key="OVSDB-167"><del>OVSDB-167</del></a></li> </ol> <ol> <li>0) enable L3 forwarding in ODL, so patch ports will be created upon neutron network creation:</li> <li>echo 'ovsdb.l3.fwd.enabled=yes' &gt;&gt; ./etc/custom.properties<br/> #</li> <li>1) start ODL, and do: feature:install odl-ovsdb-openstack</li> <li>Make sure to wait for ODL to be fully up<br/> #</li> <li>2) copy this script to a system that ir running OVS. Make sure OVS is completely</li> <li>cleared. If using ubuntu, that involves something like:<br/> #</li> <li>#!/usr/bin/env bash</li> <li>sudo service openvswitch-switch stop</li> <li>sudo rm -rf /var/log/openvswitch/*</li> <li>sudo rm -rf /etc/openvswitch/conf.db</li> <li>sudo service openvswitch-switch start<br/> #</li> <li>3) make sure you have curl installed in the system where this script is ran<br/> #</li> <li>4) do "sudo ovs-vsctl show" and make sure there are no bridges and OVS is not</li> <li>connected to ODL yet. An example of what it should look like is below:<br/> #</li> <li>$ sudo ovs-vsctl show</li> <li>5c012e23-b5a1-45d4-9a2e-865a3f81c59e</li> <li>ovs_version: "2.3.0"</li> <li>$<br/> #</li> <li>5) change ODL_IP below to the ip address of where ODL is running<br/> #</li> <li>6) run this script. It will:<br/> #</li> <li>- explicitly create bridge br-ex;</li> <li>- connect to ODL</li> <li>- create neutron network</li> <li>- add an ovs port<br/> #</li> <li>7) if bug is reproduced, you will notive that while there is a patch-port in</li> <li>br-int, a patch port in br-ex is not created. Doing this will work around the bug<br/> #</li> <li>sudo ovs-vsctl add-port br-ex patch-int &#8211; set interface patch-int type=patch &#8211; set interface patch-int options:peer=patch-ext</li> </ol> <p>Attachment bug3545.sh has been added with description: bug3545.sh</p> <p>I re-run the script and not I hit the same issue Sharad see:</p> <p>br-int is not getting created at all in the node. I ended up with 2 br-int in mdsal's config:</p> <p>{<br/> "network-topology": {<br/> "topology": [<br/> {<br/> "topology-id": "ovsdb:1",<br/> "node": [<br/> {<br/> "node-id": "ovsdb://uuid/ddfb2be2-eafe-477d-be33-12e87f35bdb5/bridge/br-int",<br/> "ovsdb:bridge-name": "br-int",<br/> "ovsdb:managed-by": "/network-topology:network-topology/network-topology:topology<span class="error">&#91;network-topology:topology-id=&#39;ovsdb:1&#39;&#93;</span>/network-topology:node<span class="error">&#91;network-topology:node-id=&#39;ovsdb://uuid/ddfb2be2-eafe-477d-be33-12e87f35bdb5&#39;&#93;</span>",<br/> "ovsdb:controller-entry": [</p> { "target": "tcp:192.168.50.1:6653" } <p> ],<br/> "ovsdb:protocol-entry": [</p> { "protocol": "ovsdb:ovsdb-bridge-protocol-openflow-13" } <p> ],<br/> "ovsdb:fail-mode": "ovsdb:ovsdb-fail-mode-secure"<br/> },<br/> {<br/> "node-id": "ovsdb://uuid/273cc9c1-1800-4af0-9c7c-bceb0454628c/bridge/br-int",<br/> "ovsdb:bridge-name": "br-int",<br/> "ovsdb:managed-by": "/network-topology:network-topology/network-topology:topology<span class="error">&#91;network-topology:topology-id=&#39;ovsdb:1&#39;&#93;</span>/network-topology:node<span class="error">&#91;network-topology:node-id=&#39;ovsdb://uuid/273cc9c1-1800-4af0-9c7c-bceb0454628c&#39;&#93;</span>",<br/> "ovsdb:controller-entry": [</p> { "target": "tcp:192.168.50.1:6653" } <p> ],<br/> "ovsdb:protocol-entry": [</p> { "protocol": "ovsdb:ovsdb-bridge-protocol-openflow-13" } <p> ],<br/> "ovsdb:fail-mode": "ovsdb:ovsdb-fail-mode-secure"<br/> }<br/> ]<br/> }<br/> ]<br/> }<br/> }</p> <p>And I see br-ex (and nothing else) on the operational tree:</p> <p>{<br/> "network-topology": {<br/> "topology": [<br/> </p> { "topology-id": "netvirt:1" } <p>,<br/> </p> { "topology-id": "flow:1" } <p>,<br/> {<br/> "topology-id": "ovsdb:1",<br/> "node": [<br/> {<br/> "node-id": "ovsdb://uuid/ddfb2be2-eafe-477d-be33-12e87f35bdb5/bridge/br-ex",<br/> "ovsdb:bridge-name": "br-ex",<br/> "ovsdb:bridge-uuid": "4110352b-f9a7-4edc-a473-faf7e450b1ee",<br/> "ovsdb:datapath-id": "00:00:2a:35:10:41:dc:4e",<br/> "ovsdb:datapath-type": "ovsdb:datapath-type-system",<br/> "ovsdb:managed-by": "/network-topology:network-topology/network-topology:topology<span class="error">&#91;network-topology:topology-id=&#39;ovsdb:1&#39;&#93;</span>/network-topology:node<span class="error">&#91;network-topology:node-id=&#39;ovsdb://uuid/ddfb2be2-eafe-477d-be33-12e87f35bdb5&#39;&#93;</span>",<br/> "ovsdb:bridge-external-ids": [</p> { "bridge-external-id-key": "bridge-id", "bridge-external-id-value": "br-ex" } <p> ],<br/> "termination-point": [</p> { "tp-id": "br-ex", "ovsdb:interface-type": "ovsdb:interface-type-internal", "ovsdb:port-uuid": "6d845492-99d1-4716-acde-0e32ad3ac278", "ovsdb:name": "br-ex", "ovsdb:interface-uuid": "c55dfd94-21a3-4163-b06c-afe7634907e5", "ovsdb:ofport": 65534 } <p> ]<br/> },<br/> {<br/> "node-id": "ovsdb://uuid/ddfb2be2-eafe-477d-be33-12e87f35bdb5",<br/> "ovsdb:managed-node-entry": [</p> { "bridge-ref": "/network-topology:network-topology/network-topology:topology[network-topology:topology-id='ovsdb:1']/network-topology:node[network-topology:node-id='ovsdb://uuid/ddfb2be2-eafe-477d-be33-12e87f35bdb5/bridge/br-ex']" } <p> ],<br/> "ovsdb:connection-info": </p> { "local-ip": "192.168.50.1", "remote-ip": "192.168.50.20", "remote-port": 47688, "local-port": 6640 } <p>,<br/> "ovsdb:ovs-version": "2.3.2",<br/> "ovsdb:openvswitch-external-ids": [</p> { "external-id-key": "system-id", "external-id-value": "0b0f991e-5420-466f-aafd-492cdb2b130e" } <p> ]<br/> }<br/> ]<br/> }<br/> ]<br/> }<br/> }</p> <p>this is karaf.log when br-int created twice in config tree, and never gets<br/> in the operational tree.</p> <p>Attachment karaf.log has been added with description: karaf.log when br-int is not getting created</p> <p>(In reply to Flavio Fernandes from comment #11)<br/> &gt; Created attachment 567 <span class="error">&#91;details&#93;</span><br/> &gt; bug3545.sh<br/> &gt; <br/> &gt; <br/> &gt; # steps to reproduce <a href="https://jira.opendaylight.org/browse/OVSDB-167" title="Updates to termination point configuration for existing termination points broken" class="issue-link" data-issue-key="OVSDB-167"><del>OVSDB-167</del></a><br/> &gt; </p> <p>revising step 0 to remove any previous state in ODL:</p> <ol> <li>0.0) clean up ODL's previous state. But deleting data AND journal directories: rm -rf ./data ./journal</li> <li>0.5) enable L3 forwarding in ODL, so patch ports will be created upon neutron network creation:</li> <li>echo 'ovsdb.l3.fwd.enabled=yes' &gt;&gt; ./etc/custom.properties<br/> #</li> <li>1) start ODL, and do: feature:install odl-ovsdb-openstack</li> <li>Make sure to wait for ODL to be fully up<br/> #<br/> ...</li> </ol> <ul> <li>added bigger sleep between manager setup and creation of neutron net;</li> </ul> <ul> <li>make sure no state from previous ODL run is carried over:<br/> rm -rf ./data ./journal</li> </ul> <p>&#8211;</p> <ol> <li>steps to reproduce <a href="https://jira.opendaylight.org/browse/OVSDB-167" title="Updates to termination point configuration for existing termination points broken" class="issue-link" data-issue-key="OVSDB-167"><del>OVSDB-167</del></a></li> </ol> <ol> <li>0.0) clean up ODL's previous state. But deleting data AND journal directories: rm -rf ./data ./journal</li> <li>0.5) enable L3 forwarding in ODL, so patch ports will be created upon neutron network creation:</li> <li>echo 'ovsdb.l3.fwd.enabled=yes' &gt;&gt; ./etc/custom.properties<br/> #</li> <li>1) start ODL, and do: feature:install odl-ovsdb-openstack</li> <li>Make sure to wait for ODL to be fully up<br/> #</li> <li>2) copy this script to a system that ir running OVS. Make sure OVS is completely</li> <li>cleared. If using ubuntu, that involves something like:<br/> #</li> <li>#!/usr/bin/env bash</li> <li>sudo service openvswitch-switch stop</li> <li>sudo rm -rf /var/log/openvswitch/*</li> <li>sudo rm -rf /etc/openvswitch/conf.db</li> <li>sudo service openvswitch-switch start<br/> #</li> <li>3) make sure you have curl installed in the system where this script is ran<br/> #</li> <li>4) do "sudo ovs-vsctl show" and make sure there are no bridges and OVS is not</li> <li>connected to ODL yet. An example of what it should look like is below:<br/> #</li> <li>$ sudo ovs-vsctl show</li> <li>5c012e23-b5a1-45d4-9a2e-865a3f81c59e</li> <li>ovs_version: "2.3.0"</li> <li>$<br/> #</li> <li>5) change ODL_IP below to the ip address of where ODL is running<br/> #</li> <li>6) run this script. It will:<br/> #</li> <li>- explicitly create bridge br-ex;</li> <li>- connect to ODL</li> <li>- sleep, so odl is given time to create br-int</li> <li>- create neutron network</li> <li>- add an ovs port<br/> #</li> <li>7) if bug is reproduced, you will notive that while there is a patch-port in</li> <li>br-int, a patch port in br-ex is not created. Doing this will work around the bug<br/> #</li> <li>sudo ovs-vsctl add-port br-ex patch-int &#8211; set interface patch-int type=patch &#8211; set interface patch-int options:peer=patch-ext</li> </ol> <p>Attachment bug3545.sh has been added with description: bug3545.sh</p> <p>draft patch uploaded at <a href="https://git.opendaylight.org/gerrit/#/c/24364/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/24364/</a></p> <p>gerrit on stable/lithium: <a href="https://git.opendaylight.org/gerrit/#/c/25204/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/25204/</a></p> <p>master : <a href="https://git.opendaylight.org/gerrit/#/c/24364/3" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/24364/3</a></p> Development External issue ID 3545 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i02127: