https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OVSDB-352 ovsdb <p>Summary:<br/> If the same OVSDB client repeatedly makes requests to read the OVSDB configuration, the methodContext hashmap keeps growing. </p> <p>Steps to reproduce:</p> <ul class="alternate" type="square"> <li>add multiple ports/interfaces (&gt;30) to OVSDB (using ovs-vsctl) so that the increase in memory consumption is easy to detect.</li> <li>using a client, make requests to read the configuration in OVSDB repeatedly.</li> <li>observe the memory growth of this test program using a tool like jstack.</li> </ul> <p>Some questions:</p> <ul class="alternate" type="square"> <li>Is there a recommendation that the same OVSDB client should not be used for multiple requests?</li> <li>Is there a way to reinitialize JsonRpcEndpoint for the same OVSDB client?</li> </ul> <p>Operating System: All<br/> Platform: All</p> OVSDB-352

potential memory leak in JsonRpcEndpoint

Bug Resolved Done Anil Vishnoi Ashwin P Tue, 5 Jul 2016 13:27:31 +0000 Sun, 24 Jul 2016 08:30:08 +0000 Sun, 24 Jul 2016 08:30:08 +0000 unspecified Library 0 1 <p>Hi Ashwin,</p> <p>Can you please give some more details about "- using a client, make requests to read the configuration in OVSDB repeatedly.". How are you making the request? are you using RESTCONF to fetch the data from data store? Or are you using explicit library calls for that ?</p> <p>@Anil:<br/> &gt; How are you making the request? are you using RESTCONF to fetch the data from data store? Or are you using explicit library calls for that ?</p> <p>Library calls <span class="error">&#91;an example -- repeated ovsdb.lib.operations.TransactionBuilder.execute calls that execute a select operation on the Port table (containing &gt; 30 ports) using an OvsdbClient&#93;</span>. I believe the problem is that there are only "put" invocations on the methodContext hash-map in JsonRpcEndpoint. There is no piece of code that removes elements from the hash-map after the request is processed.</p> <p>Attachment #1: Bug6157 reproducer JUnit test</p> <p>Attachment Bug6157_reproducer.txt has been added with description: Bug6157 reproducer</p> <p>Attachment #2: Bug6157 OutOfMemory exception after running the reproducer.</p> <p>Attachment Bug6157_exception.txt has been added with description: Bug6157 OutOfMemory exception after running the reproducer</p> <p>@Anil:</p> <p>I have attached two files. One of them is a reproducer. It simply creates a select OVSDB transaction using ODL library calls on the OVSDB Port table, and executes it 300 times.</p> <p>If you run the JUnit test <b>after</b> adding a large number of ports (~ 300) using "ovs-vsctl add-port &lt;BRIDGE_NAME&gt; &lt;PORT_NAME&gt;" to OVSDB, I believe you should be able to observe the OutOfMemoryError exception (second attachment). `ps aux` output shows continuous increase in the memory consumption when the test is run. I used the Beryllium-1.2.3-SR2 stable released version of ODL for running these tests.</p> <p>I'd really appreciate if the fix for this Bug can be included in the forthcoming SR3 release.</p> <p>The following change may be a potential workaround/fix:<br/> -----a/library/impl/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java<br/> +++ b/library/impl/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java<br/> @@ -128,6 +128,8 @@ public class JsonRpcEndpoint </p> { return; } <p>+ methodContext.remove(response.get("id").asText());<br/> +<br/> if (ListenableFuture.class == returnCtxt.getMethod().getReturnType()) {<br/> TypeToken&lt;?&gt; retType = TypeToken.of(<br/> returnCtxt.getMethod().getGenericReturnType())</p> <hr /> <p>@Anil: If you could please provide an ETA for the fix for this Bug, I'd really appreciate it. Will the fix make it to the forthcoming SR3 release?</p> <p>Master : <a href="https://git.opendaylight.org/gerrit/42211" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/42211</a><br/> Stable/beryllium : <a href="https://git.opendaylight.org/gerrit/42113" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/42113</a></p> Development External issue ID 6157 External issue URL Priority Rank 0|i0227b: