[OVSDB-452] TransactionInvokerImpl should be daemon

Blocks — Mon, 19 Feb 2018 14:55:40 +0000

I suspect that this OVSDB thread could be (part of / contributing to) ~~GENIUS-114~~:

"transaction-invoker-impl-0" #280 prio=5 os_prio=0 tid=0x00007fbd843ceb00 nid=0x3d76 waiting on condition [0x00007fbd45d87000]
   java.lang.Thread.State: WAITING (parking)
	at sun.misc.Unsafe.park(Native Method)
	- parking to wait for  <0x000000008a65aa70> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
	at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
	at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
	at org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.extractCommandsFromQueue(TransactionInvokerImpl.java:188)
	at org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.extractCommands(TransactionInvokerImpl.java:182)
	at org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.run(TransactionInvokerImpl.java:95)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Should this not be a Thread.setDaemon(true) thread?

You could use org.opendaylight.infrautils.utils.concurrent.ThreadFactoryProvider, if you like.

Can whatever creates this be made to have clean shut-down logic which stops the thread?

OpenDaylight JIRA

[OVSDB-452] TransactionInvokerImpl should be daemon