[OVSDB-454] OvsdbConnectionService background thread (from netty?) should be daemon (and have a proper thread name)

Blocks — Thu, 7 May 2020 08:17:42 +0000

I suspect that this OFP thread could be (part of / contributing to) ~~GENIUS-114~~:

"Thread-39" #283 prio=5 os_prio=0 tid=0x00007fbd6c028780 nid=0x3d79 in Object.wait() [0x00007fbd45884000]
   java.lang.Thread.State: WAITING (on object monitor)
	at java.lang.Object.wait(Native Method)
	at java.lang.Object.wait(Object.java:502)
	at io.netty.util.concurrent.DefaultPromise.await(DefaultPromise.java:232)
	- locked <0x000000008a617300> (a io.netty.channel.AbstractChannel$CloseFuture)
	at io.netty.channel.DefaultChannelPromise.await(DefaultChannelPromise.java:129)
	at io.netty.channel.DefaultChannelPromise.await(DefaultChannelPromise.java:28)
	at io.netty.util.concurrent.DefaultPromise.sync(DefaultPromise.java:333)
	at io.netty.channel.DefaultChannelPromise.sync(DefaultChannelPromise.java:117)
	at io.netty.channel.DefaultChannelPromise.sync(DefaultChannelPromise.java:28)
	at org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.ovsdbManagerWithSsl(OvsdbConnectionService.java:362)
	at org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.ovsdbManager(OvsdbConnectionService.java:300)
	at org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.lambda$startOvsdbManager$1(OvsdbConnectionService.java:249)
	at org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService$$Lambda$1133/1995495413.run(Unknown Source)
	at java.lang.Thread.run(Thread.java:748)

Should this not be a Thread.setDaemon(true) thread?

Could it be made to have a better name than the generic "Thread-39" ?

You could use org.opendaylight.infrautils.utils.concurrent.ThreadFactoryProvider, if you like.

Can OvsdbConnectionService have clean shut-down logic which stops the thread?

OpenDaylight JIRA

[OVSDB-454] OvsdbConnectionService background thread (from netty?) should be daemon (and have a proper thread name)