https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OVSDB-470 ovsdb <p>I'm looking at a Java Flight Recording obtained from (internal) scale lab testing, and see extensive "TLAB Allocations" due to what appears to be a clear mistake causing Excessive toString in <a href="https://github.com/opendaylight/ovsdb/blob/master/utils/southbound-utils/src/main/java/org/opendaylight/ovsdb/utils/southbound/utils/SouthboundUtils.java" class="external-link" target="_blank" rel="nofollow noopener">SouthboundUtils</a>.isBridgeOnOvsdbNode() :</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-object">char</span>[] java.util.Arrays.copyOf(<span class="code-object">char</span>[], <span class="code-object">int</span>) 19544 void java.lang.AbstractStringBuilder.ensureCapacityInternal(<span class="code-object">int</span>) 19544 AbstractStringBuilder java.lang.AbstractStringBuilder.append(<span class="code-object">char</span>) 12292 StringBuilder java.lang.StringBuilder.append(<span class="code-object">char</span>) 12292 <span class="code-object">String</span> com.google.common.base.MoreObjects$ToStringHelper.toString() 11244 <span class="code-object">String</span> org.opendaylight.yangtools.yang.binding.InstanceIdentifier.toString() 11244 <span class="code-object">boolean</span> org.opendaylight.ovsdb.utils.southbound.utils.SouthboundUtils.isBridgeOnOvsdbNode(Node, <span class="code-object">String</span>) 11244 <span class="code-object">Boolean</span> org.opendaylight.netvirt.elan.internal.ElanBridgeManager.isBridgeOnOvsdbNode(Node, <span class="code-object">String</span>) 11244 void org.opendaylight.netvirt.elan.internal.ElanOvsdbNodeListener.update(InstanceIdentifier, Node, Node) 11244 void org.opendaylight.netvirt.elan.internal.ElanOvsdbNodeListener.update(InstanceIdentifier, DataObject, DataObject) 11244 void org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase$DataTreeChangeHandler.run() 11244 void java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor$Worker) 11244 void java.util.concurrent.ThreadPoolExecutor$Worker.run() 11244 void java.lang.<span class="code-object">Thread</span>.run() 11244</pre> </div></div> OVSDB-470

Excessive toString in SouthboundUtils.isBridgeOnOvsdbNode()

Bug High Resolved Done Michael Vorburger Michael Vorburger Mon, 12 Nov 2018 17:29:23 +0000 Wed, 19 Dec 2018 00:53:35 +0000 Wed, 19 Dec 2018 00:53:35 +0000 Oxygen-SR3 Neon Southbound.Open_vSwitch 0 2 <p>Could you clarify what the clear mistake is?</p> <p><a href="https://git.opendaylight.org/gerrit/77719" class="external-link" target="_blank" rel="nofollow noopener">c/77719</a> should help to avoid excessive toString() ?</p> <p>My c/77719 went in on Thursday; <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a>'s c/77721 still needs a rebase, this this issue is done for Neon, and could be cherry-picked.</p> <p>It's in Neon now, let's close this, for now; we can cherry-pick to Fluorine later, if needed.</p> Development Rank 0|i03kbj: