https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OVSDB-495 ovsdb <p>With the MD-SAL migration done, there are now two almost identical classes, as reported by CPD:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[INFO] --- maven-pmd-plugin:3.13.0:cpd-check (cpd) @ utils.mdsal-utils --- [INFO] PMD version: 6.21.0 [INFO] CPD Failure: Found 159 lines of duplicated code at locations: [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/ControllerNotifyingDataChangeListener.java line 70 [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/NotifyingDataChangeListener.java line 68 [INFO] CPD Failure: Found 56 lines of duplicated code at locations: [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/ControllerMdsalUtils.java line 100 [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/MdsalUtils.java line 98 [INFO] CPD Failure: Found 83 lines of duplicated code at locations: [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/ControllerMdsalUtilsAsync.java line 131 [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/MdsalUtilsAsync.java line 130 [INFO] CPD Failure: Found 14 lines of duplicated code at locations: [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/ControllerNotifyingDataChangeListener.java line 34 [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/NotifyingDataChangeListener.java line 33 [INFO] You have 4 CPD duplications. For more details see: /home/nite/odl/ovsdb/utils/mdsal-utils/target/cpd.xml </pre> </div></div> <p>the intent was the have the ones not starting with Controller to supersede the Controller classes and remove them. This needs to be rectified, as it is a maintenance burden an confuses downstreams as to which class to use.</p> OVSDB-495

Eliminate ControllerMdsalUtils et al.

Bug High Resolved Done Chetan Arakere Gowdru Robert Varga Fri, 1 May 2020 08:04:01 +0000 Tue, 12 Jan 2021 01:49:52 +0000 Fri, 26 Jun 2020 09:52:27 +0000 unspecified Commons 0 1 0 minutes 1 day Development Rank 0|i03sa7: