https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/RELENG-137 releng <p>In a given release, all snapshot dependencies should have the same patch level: .0-SNAPSHOT when we’re leading up to GA, .1-SNAPSHOT leading up to SR1, etc. We could easily check builds for this and fail them early — this would catch mis-matches in patches (which catch a lot of developers out), and help reduce the risk of merging patches with obsolete versions after a release bump.</p> RELENG-137

Builds should fail early with snapshot mismatches

Task Medium Open Unresolved Unassigned Stephen Kitt Tue, 27 Nov 2018 09:10:26 +0000 Tue, 4 Aug 2020 12:46:19 +0000 0 2 <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> which jobs are you thinking of adding this to?</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>autorelease-release-* </pre> </div></div> <p> and </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>*-validate-autorelease-* </pre> </div></div> <p> jobs achieve this today by running "mvn clean validate" as an initial build step.</p> <p>I’m not sure yet. This does more than “mvn validate”: it doesn’t only check that all the dependency information is present and correct, it would check that it’s consistent. See for example <a href="https://git.opendaylight.org/gerrit/#/c/77569/8/features/production/odl-neutron-northbound-api/pom.xml" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/77569/8/features/production/odl-neutron-northbound-api/pom.xml</a> — this references aaa-artifacts:0.8.2-SNAPSHOT (which is correct for Fluorine leading up to SR2) and restconf-artifacts:1.8.1-SNAPSHOT (which isn’t).</p> <p>Oh wait, I realise the build isolation in autorelease jobs would check this via “validate”, indirectly...</p> <p>Except it doesn’t, because of the release bumping.</p> <p>That's right. validate-autorelease does validate that all artifacts are reachable due to the nature of the job itself. However the downside is it doesn't work during version bumping (well it does work just we are expecting it to fail).</p> <p>What I meant by release bumping here was the fact that the autorelease jobs drop "-SNAPSHOT". Thus if a project still references a previous release as a snapshot, it pulls in the previously-released artifacts instead, and the autorelease job validates just fine. See <a href="https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/neutron-validate-autorelease-fluorine/69/" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/neutron-validate-autorelease-fluorine/69/</a> which should have failed (because the patch pulls in the SR1 restconf instead of the SR2 restconf).</p> <p>Oh right. Yes that is definitely a problem we should try to address.</p> Development Rank 0|i03l07: