https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/RELENG-151 releng <p>the multipatch job does not seem to be working as expected. Here is a <a href="https://git.opendaylight.org/gerrit/c/controller/+/91549" class="external-link" target="_blank" rel="nofollow noopener">gerrit</a><br/> where I left the comment "multipatch-build:topic=mri-magnesium-sr2" which<br/> triggered this <a href="https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-magnesium/66/" class="external-link" target="_blank" rel="nofollow noopener">job</a> but the PATCHES_TO_BUILD parameter is not "topic=mri-magnesium-sr2"<br/> as we'd expect so the job fails.</p> <p>The workaround is to manually start the job and fill in that parameter, like I did<br/> <a href="https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-magnesium/67/" class="external-link" target="_blank" rel="nofollow noopener">here</a></p> <p>Not everyone can start jenkins jobs manually, so we should fix this if we want to<br/> encourage others to eventually start doing this kind of work.<br/>  </p> RELENG-151

multipatch job not working

Bug High Resolved Done Thanh Ha (zxiiro) Jamo Luhrsen multipatch Thu, 23 Jul 2020 16:08:50 +0000 Thu, 23 Jul 2020 20:02:38 +0000 Thu, 23 Jul 2020 20:02:29 +0000 0 3 <p>So according to the logs GERRIT_EVENT_COMMENT_TEXT comes in as "UGF0Y2ggU2V0IDE6CgptdWx0aXBhdGNoLWJ1aWxkOnRvcGljPW1yaS1tYWduZXNpdW0tc3Iy" which is a base64 encoded value for the comment:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Patch Set 1: multipatch-build:topic=mri-magnesium-sr2 </pre> </div></div> <p>This is a configuration in Jenkins as can be seen here (<a href="https://stackoverflow.com/questions/49187081/jenkins-gerrit-trigger-plugin-gives-encoded-gerrit-change-commit-message-and-ger" class="external-link" target="_blank" rel="nofollow noopener">https://stackoverflow.com/questions/49187081/jenkins-gerrit-trigger-plugin-gives-encoded-gerrit-change-commit-message-and-ger</a>). Perhaps someone at LF was changing configuration for the Gerrit Trigger plugin accidently configured it to use base64 encoding.</p> <p>So we have 2 routes to resolve this:</p> <p>1) LF admin changes this setting back to plain text<br/> 2) We decode the base64 encoding in our scripts</p> <p>I think option 1 would be faster and less complicated though.</p> <p>After some more research with <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=agrimberg" class="user-hover" rel="agrimberg">agrimberg</a> on IRC it appears there is no global setting for this which means likely a new version of Gerrit Trigger plugin must have changed this default setting value to base64. We'll have to resolve this at the job config level in this case.</p> <p>But if this is true, this should impact any job passing keywords and nobody has said anything (yet). Or maybe this impacts when job is re-generated (e.g. we saw this when we merged a patch in a script used by the job), because I just tried recheck in a regular patch and it still works.</p> <p>It impacts all jobs that are parsing Gerrit comments (most likely jjb-deploy job also hits this issue). I'm not sure how many jobs we have that are parsing so we'll have to wait until folks complain and report.</p> <p>If you're just doing a simple "recheck" those jobs are fine because it's not parsing any comment string text in the job (other than for the keyword to trigger it). Jobs that pass paramenters like "jjb-deploy: some-job-name" are the ones affected.</p> <p>good point <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=ecelgp" class="user-hover" rel="ecelgp">ecelgp</a>, I know a lot of people are using jjb-deploy and no complaints so wondering why<br/> they didn't hit this bug?</p> <p>Here's patch for global-jjb and I <em>think</em> covers all jobs that use this feature <a href="https://gerrit.linuxfoundation.org/infra/c/releng/global-jjb/+/64622" class="external-link" target="_blank" rel="nofollow noopener">https://gerrit.linuxfoundation.org/infra/c/releng/global-jjb/+/64622</a></p> <p>I tracked it down to <a href="https://review.opendev.org/#/c/731169/" class="external-link" target="_blank" rel="nofollow noopener">https://review.opendev.org/#/c/731169/</a> upstream JJB where the gerrit trigger plugin was improved to support configuring this option. Previously to that the option was unconfigurable in JJB so it defaulted to whatever the plugin defaulted to. We just started seeing this issue on Monday after we merged the JJB upgrade patch.</p> <p>I think we understand the problem now and how to fix it so we can move forward with this.</p> <p>This final releng/builder patch <a href="https://git.opendaylight.org/gerrit/c/releng/builder/+/91597" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/releng/builder/+/91597</a> should take care of the remaining jobs that parse the GERRIT_EVENT_COMMENT_TEXT.</p> <p>Fixes proposed to all relevant projects as far as I can tell. Once patches are merged we should be okay.</p> <p>OK, makes sense all your comments. Thanks <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=zxiiro" class="user-hover" rel="zxiiro">zxiiro</a> for fixing so fast <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> Development Rank 0|i03u0n: