https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/RELENG-36 releng <p>... because distribution-check allows you to spot whenever you're breaking a dependency or something of the sort.</p> <p>The reason I'm opening this bug is because I faced the following:</p> <ul class="alternate" type="square"> <li>PatchXYZ in Genius removes an artifact</li> <li>Netvirt is actually using the artifact the Genius patch PatchXYZ wants to remove</li> <li>PatchXYZ will fail to build because distribution-check will complain of a missing dependency (obviously the one build PatchXYZ removes)</li> <li>Update the commit message --&gt; only the verify job gets triggered, and jenkins will successfully verified. But distribution-check will not run, thus the patch will get verified, although it should have failed.</li> </ul> <p>Merging such a patch would break autorelease. I think to avoid this, we should always run distribution-check.</p> <p>See <a href="https://git.opendaylight.org/gerrit/#/c/46689/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/46689/</a> for reference.</p> <p>Operating System: All<br/> Platform: All</p> RELENG-36

Distribution-check should be run on trivial rebases and no-code changes

Bug Resolved Done Vratko Polak Alexis de Talhouët Tue, 11 Oct 2016 18:06:49 +0000 Thu, 3 May 2018 14:50:10 +0000 Sat, 19 Nov 2016 00:53:25 +0000 unspecified Jenkins Job Builder 0 2 <p><a href="https://git.opendaylight.org/gerrit/#/c/46792/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/46792/</a></p> <p>&gt; I think to avoid this, we should always run distribution-check.</p> <p>No, we should skip triggering the verify job instead.</p> <p>After the implemented fix we still have a similar situation related to validate-autorelease job. If only validate-autorelease job is failing and you update the commit message, verify and distribution-check are triggered and you get a false verified+1.</p> <p>I have a better fix <span class="error">&#91;0&#93;</span> waiting for review for some time, let me rebase that.</p> <p><span class="error">&#91;0&#93;</span> <a href="https://git.opendaylight.org/gerrit/46043" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/46043</a></p> <p>Vratko, thanks for those input and sorry this has move so fast yesterday. I'm assigning the BUG to you. Can you please update your patch to reflect that BUG please.<br/> Thanks</p> Development External issue ID 6926 External issue URL Rank 0|i01m5j: