https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/RELENG-89 releng <p>The code that generates the dependencies.log needs to be able to handle profiles and commented out code.</p> <p>A first step should be the comments as its easier.</p> <p>Profiles will be more difficult as we can't be sure if it's activated or not but maybe assume it's activated and then if &lt;activeByDefault&gt;false&lt;/activeByDefault&gt; then ignore (Although there's other cases where it needs to ignore too).</p> RELENG-89

Dependencies script should detect profiles and commented out code

Story Medium In Progress Unresolved Anil Belur Thanh Ha (zxiiro) Mon, 9 Apr 2018 22:54:05 +0000 Mon, 17 Aug 2020 20:11:29 +0000 Autorelease Jenkins Job Builder 0 4 <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=zxiiro" class="user-hover" rel="zxiiro">zxiiro</a> Please share some github links on existing commented lines in the projects, unable to find them? </p> <p>&gt; Profiles will be more difficult as we can't be sure if it's activated or not but maybe assume it's activated and then if &lt;activeByDefault&gt;false&lt;/activeByDefault&gt; then ignore (Although there's other cases where it needs to ignore too).</p> <p>Assuming its active, assumes that the project is included in the list and exclude them if its set to `false`, but need to understand why we can't check simply check the poms for `&lt;activeByDefault&gt;true&lt;/activeByDefault&gt;`. </p> <p><b>Regarding commented out code</b></p> <p>This comes in 2 forms:</p> <p>1. A module that is not even listed as a module to build</p> <p>In this case it is not commented out code, the project just did not declare the module. It's similar to how in autorelease we have a modules list:</p> <p><a href="https://github.com/opendaylight/releng-autorelease/blob/master/pom.xml" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/releng-autorelease/blob/master/pom.xml</a></p> <p>You can disable a project from building by simply just removing it from the pom. I don't have an example off hand but I've seen it.</p> <p>2. Using XML &lt;!-- comment --&gt; flag</p> <p>This one is easier to detect as it has a specific syntax. For example:</p> <p><a href="https://github.com/opendaylight/lispflowmapping/blob/37c6bb104b8884ef35a836dec739e9451e3f757f/pom.xml#L24-L26" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/lispflowmapping/blob/37c6bb104b8884ef35a836dec739e9451e3f757f/pom.xml#L24-L26</a></p> <p>This is the most common way projects disable things in their own projects.</p> <p><b>Regarding profiles</b></p> <p>We can not assume &lt;activeByDefault&gt; because it is only one of many activation/deactivation methods of Maven.</p> <p><a href="https://maven.apache.org/guides/introduction/introduction-to-profiles.html" class="external-link" target="_blank" rel="nofollow noopener">https://maven.apache.org/guides/introduction/introduction-to-profiles.html</a></p> <p>Additionally without inspecting the profile we cannot tell what is even in the profile as there are many things Maven pom.xml files support in a profile.</p> Development Rank 0|i03d07: