https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/SXP-155 sxp <p>We have policies setup in Nexus that requires all staging repo artifacts to pass a series of validation checks before allowing them to be released. The following needs to be fixed, since the Nexus repos are failing to close when the repos are created through the maven stage jobs:</p> <ul> <li>POM validation</li> <li>Source validation</li> <li>Javadocs validation</li> <li>Reactivate the validation checker</li> </ul> <p>We've temporarily disabled the validation checker for the SXP project but it really needs to be enabled. We need to resolve the checkers ideally.</p> SXP-155

SXP fails staging validation checker

Improvement High Resolved Done Thanh Ha (zxiiro) Anil Belur Thu, 22 Nov 2018 03:32:09 +0000 Fri, 23 Nov 2018 00:30:59 +0000 Fri, 23 Nov 2018 00:30:59 +0000 General 0 4 0 minutes 1 hour <p>I'm not sure how SXP is skipping the generation of source jars and javadoc jars as it's enabled in odlparent. Is SXP somehow overriding these in their builds?</p> <p>Pom Validation error is from:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>failureMessage Invalid POM: /org/opendaylight/sxp/restconf-client/0.1.1/restconf-client-0.1.1.pom: Project name missing, Project description missing, Project URL missing, License information missing, SCM URL missing, Developer information missing failureMessage Invalid POM: /org/opendaylight/sxp/sxp-jst/0.1.1/sxp-jst-0.1.1.pom: Project name missing, Project description missing, Project URL missing, License information missing, SCM URL missing, Developer information missing failureMessage Invalid POM: /org/opendaylight/sxp/sxp-system-tests/0.1.1/sxp-system-tests-0.1.1.pom: Project description missing, Project URL missing, License information missing, SCM URL missing, Developer information missing </pre> </div></div> <p>Sources Jar validation error is from:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>failureMessage Missing: no sources jar found in folder '/org/opendaylight/sxp/restconf-client/0.1.1' </pre> </div></div> <p>Javadoc validation error is from:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>failureMessage Missing: no javadoc jar found in folder '/org/opendaylight/sxp/restconf-client/0.1.1' </pre> </div></div> <p>Seems like these issues might stem from the files in the system-tests directory not having a parent which traces back to odlparent.</p> <p>I'm investigating adding odlparent-lite as their parent artifacts now.</p> <p>I submitted 3 patches to master, stable/fluorine, and stable/oxygen to hopefully resolve this issue.</p> <p>Can someone double check the copyrights to make sure they are correct?</p> <p>Hi, I will check them.</p> <p>Copyrights are OK.</p> <p>I've re-enabled the validation checker. Let me know if you need me to do anything to get the master branch patch merged.</p> <p>Patch on master branch was failing because using odl-parent as parent caused to run tests in: sxp-system-tests/sxp-jst/src/test/java/org/opendaylight/sxp/jst/<b>SystemTests.java</b> but they require running Karaf which is not satisfied during running unit tests.</p> <p> </p> <p>I think system tests were marked as unit tests only for convenience to run them so I have reworked them:</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/78047/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/78047/</a></p> <p> </p> <p>And now it should be OK.</p> Development Rank 0|i03kx3: