https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/TRNSPRTPCE-103 transportpce <p>mappingServices method in ModelMappingUtils class takes two arguments serviceCreateInput and serviceReconfigureInput but maps only one depending on which is null</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (serviceCreateInput != <span class="code-keyword">null</span>) {} <span class="code-keyword">else</span> <span class="code-keyword">if</span> (serviceReconfigureInput != <span class="code-keyword">null</span>) {} </pre> </div></div> <p>This isn't a good method signature as it's not clear about functionality </p> TRNSPRTPCE-103

mappingServices takes 2 parameters but maps only one

Bug Low Open Unresolved Unassigned Rami Mohamed Thu, 18 Apr 2019 12:59:13 +0000 Mon, 13 Sep 2021 09:28:06 +0000 0 2 <p>I don't really see that as an issue. This method will be called following an RPC. The RPC can be either a service create or a service reconfigure. So we will never have the 2 related attributes (input) valid at the same time. Each RPC will trig different behaviour.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=orenais" class="user-hover" rel="orenais">orenais</a></p> <p>The signature of the method could lead to wrong assumptions, the first thing would come to mind is it maps 2 objects to the output, while it actually maps only one to the output and it's not clear why the first argument shadows the second </p> Development Epic Link TRNSPRTPCE-501 Rank 0|hzzzu5:f