https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/TRNSPRTPCE-701 transportpce <p>Sulfur-SR3 and Clorine-SR1 are respectively using karaf-4.3.8 and karaf-4.4.2</p> <p>In these versions of karaf, when we try to launch the client (./karaf/target/assembly/bin/client), it fails with the following message:</p> <blockquote><p>Logging in as karaf<br/> DefaultOpenFuture[ChannelShell<span class="error">&#91;id=0, recipient=-1&#93;</span>-ClientSessionImpl<span class="error">&#91;karaf@localhost/127.0.0.1:8101&#93;</span>]: Failed (IllegalArgumentException) to execute: Invalid UINT32 value: -1</p></blockquote> <p>This feature is used in transportpce tapi functional tests to install the odl-transportpce-tapi optional feature.</p> <p>Since the tapi feature can no longer be installed, all tapi functional tests are failing on the gate (<a href="https://jenkins.opendaylight.org/releng/job/transportpce-tox-verify-sulfur/1372/consoleFull" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/releng/job/transportpce-tox-verify-sulfur/1372/consoleFull</a>)</p> <p> </p> <p>Karaf client is still failing with karaf-4.4.2, even if the exception is better managed:</p> <blockquote><p><tt>Logging in as karaf</tt><br/> <tt>Required control character VDSUSP is not available</tt></p></blockquote> <p> </p> TRNSPRTPCE-701

karaf client fails in karaf-4.3.8 and 4.4.2

Bug Highest Verified Done Unassigned Gilles Thouenon Wed, 9 Nov 2022 13:53:57 +0000 Wed, 20 Sep 2023 12:33:27 +0000 Wed, 20 Sep 2023 12:33:19 +0000 Sulfur Chlorine Argon Potassium tapi 0 3 <p><tt>1375 <span class="error">&#91;main&#93;</span> DEBUG org.apache.sshd.client.SshClient - close(SshClient<span class="error">&#91;d6da883&#93;</span>)<span class="error">&#91;Immediately&#93;</span> closed</tt><br/> <tt>org.apache.sshd.common.SshException: DefaultOpenFuture[ChannelShell<span class="error">&#91;id=0, recipient=-1&#93;</span>-ClientSessionImpl<span class="error">&#91;karaf@localhost/127.0.0.1:8101&#93;</span>]: Failed (IllegalArgumentException) to execute: Invalid UINT32 value: -1</tt><br/> <tt>    at org.apache.sshd.common.future.AbstractSshFuture.lambda$verifyResult$1(AbstractSshFuture.java:132)</tt><br/> <tt>    at org.apache.sshd.common.future.AbstractSshFuture.formatExceptionMessage(AbstractSshFuture.java:190)</tt><br/> <tt>    at org.apache.sshd.common.future.AbstractSshFuture.verifyResult(AbstractSshFuture.java:131)</tt><br/> <tt>    at org.apache.sshd.client.future.DefaultOpenFuture.verify(DefaultOpenFuture.java:39)</tt><br/> <tt>    at org.apache.sshd.client.future.DefaultOpenFuture.verify(DefaultOpenFuture.java:32)</tt><br/> <tt>    at org.apache.sshd.common.future.VerifiableFuture.verify(VerifiableFuture.java:43)</tt><br/> <tt>    at org.apache.karaf.client.Main.main(Main.java:281)</tt><br/> <tt>Caused by: java.lang.IllegalArgumentException: Invalid UINT32 value: -1</tt><br/> <tt>    at org.apache.sshd.common.util.ValidateUtils.createFormattedException(ValidateUtils.java:213)</tt><br/> <tt>    at org.apache.sshd.common.util.ValidateUtils.throwIllegalArgumentException(ValidateUtils.java:179)</tt><br/> <tt>    at org.apache.sshd.common.util.ValidateUtils.checkTrue(ValidateUtils.java:162)</tt><br/> <tt>    at org.apache.sshd.common.util.buffer.BufferUtils.validateUint32Value(BufferUtils.java:703)</tt><br/> <tt>    at org.apache.sshd.common.util.buffer.Buffer.putUInt(Buffer.java:726)</tt><br/> <tt>    at org.apache.sshd.client.channel.PtyCapableChannelSession.lambda$doOpenPty$0(PtyCapableChannelSession.java:265)</tt><br/> <tt>    at java.base/java.util.HashMap.forEach(HashMap.java:1337)</tt><br/> <tt>    at org.apache.sshd.client.channel.PtyCapableChannelSession.doOpenPty(PtyCapableChannelSession.java:263)</tt><br/> <tt>    at org.apache.sshd.client.channel.ChannelShell.doOpen(ChannelShell.java:45)</tt><br/> <tt>    at org.apache.sshd.client.channel.AbstractClientChannel.handleOpenSuccess(AbstractClientChannel.java:366)</tt><br/> <tt>    at org.apache.sshd.common.session.helpers.AbstractConnectionService.channelOpenConfirmation(AbstractConnectionService.java:545)</tt><br/> <tt>    at org.apache.sshd.common.session.helpers.AbstractConnectionService.process(AbstractConnectionService.java:456)</tt><br/> <tt>    at org.apache.sshd.common.session.helpers.CurrentService.process(CurrentService.java:109)</tt><br/> <tt>    at org.apache.sshd.common.session.helpers.AbstractSession.doHandleMessage(AbstractSession.java:594)</tt><br/> <tt>    at org.apache.sshd.common.session.helpers.AbstractSession.lambda$handleMessage$0(AbstractSession.java:525)</tt><br/> <tt>    at org.apache.sshd.common.util.threads.ThreadUtils.runAsInternal(ThreadUtils.java:66)</tt><br/> <tt>    at org.apache.sshd.common.session.helpers.AbstractSession.handleMessage(AbstractSession.java:524)</tt><br/> <tt>    at org.apache.sshd.common.session.helpers.AbstractSession.decode(AbstractSession.java:1644)</tt><br/> <tt>    at org.apache.sshd.common.session.helpers.AbstractSession.messageReceived(AbstractSession.java:485)</tt><br/> <tt>    at org.apache.sshd.common.session.helpers.AbstractSessionIoHandler.messageReceived(AbstractSessionIoHandler.java:64)</tt><br/> <tt>    at org.apache.sshd.common.io.nio2.Nio2Session.handleReadCycleCompletion(Nio2Session.java:371)</tt><br/> <tt>    at org.apache.sshd.common.io.nio2.Nio2Session$1.onCompleted(Nio2Session.java:344)</tt><br/> <tt>    at org.apache.sshd.common.io.nio2.Nio2Session$1.onCompleted(Nio2Session.java:339)</tt><br/> <tt>    at org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$completed$0(Nio2CompletionHandler.java:38)</tt><br/> <tt>    at java.base/java.security.AccessController.doPrivileged(Native Method)</tt><br/> <tt>    at org.apache.sshd.common.io.nio2.Nio2CompletionHandler.completed(Nio2CompletionHandler.java:37)</tt><br/> <tt>    at java.base/sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:127)</tt><br/> <tt>    at java.base/sun.nio.ch.Invoker$2.run(Invoker.java:219)</tt><br/> <tt>    at java.base/sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)</tt><br/> <tt>    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)</tt><br/> <tt>    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)</tt><br/> <tt>    at java.base/java.lang.Thread.run(Thread.java:829)</tt></p> <p>The failing check was introduced in <a href="https://issues.apache.org/jira/browse/SSHD-1244" class="external-link" target="_blank" rel="nofollow noopener">https://issues.apache.org/jira/browse/SSHD-1244</a> .</p> <p>From quick glance I have not found anything fishy in SSHD itself, but Karaf's client is initializing the input in</p> <p><font color="#000000">client/src/main/java/org/apache/karaf/client/Main.java:267:                        channel.setPtyModes(modes);</font></p> <p>can you look at modes here with a debugger?</p> <p>Alternatively, we really need to know the PtyMode key which has that -1 associated and then track down where it is set.</p> <p>And we'll need a Karaf bug, I think because JLine reports -1 for characters it does not find: <a href="https://github.com/jline/jline3/blob/92a63e1494d7e24a9f36cf639257b181080a535f/terminal/src/main/java/org/jline/terminal/Attributes.java#L292" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/jline/jline3/blob/92a63e1494d7e24a9f36cf639257b181080a535f/terminal/src/main/java/org/jline/terminal/Attributes.java#L292</a> and karaf is not filtering those.</p> <p>Now we need to figure out which attributes are missing and why – because perhaps this can be solved with setting TERM via <a href="https://github.com/jline/jline3/wiki/Terminals" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/jline/jline3/wiki/Terminals</a> – I don't really know, though.</p> <p>Upstream issue: <a href="https://issues.apache.org/jira/browse/KARAF-7607" class="external-link" target="_blank" rel="nofollow noopener">https://issues.apache.org/jira/browse/KARAF-7607</a></p> <p>Upstream (partial?) fix: <a href="https://github.com/apache/karaf/pull/1680" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/karaf/pull/1680</a></p> <p>We still need to try to work this around with TERM.</p> <p>Hopefully the unavailable control char is not one of the three mentioned here: <a href="https://github.com/apache/karaf/pull/1680/commits/96128a63c7c71f613b88ca05017c7e7e75b86d85" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/karaf/pull/1680/commits/96128a63c7c71f613b88ca05017c7e7e75b86d85</a></p> <p>Thank you Robert to take care of this issue.</p> <p>I've just tested your karaf PR and obtained the following messge now:</p> <blockquote><p>Logging in as karaf<br/> Required control character VDSUSP is not available</p></blockquote> <p>Ah, so it is <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/> <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=gthouenon" class="user-hover" rel="gthouenon">gthouenon</a> can you try without the second patch in the PR, please?</p> <p>Good news!<br/> Without your second patch, karaf-client works perfectly!</p> <p>Thanks for testing <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Unfortunately it seems we are not getting a new Karaf for a couple of weeks. I am loathe to downgrade, but it seems the best short-term option to get this unblocked.</p> <p>Q: which release train is the most pressing? Cl SR1? Su SR2?</p> <p>From TPCE side, no pressing at all for any of these releases. From ODL release schedule, it seems Su SR2 is rather urgent if we don't want make the delay worse...<br/> But, may be the best solution would be to find a workaround on TPCE side to avoid a karaf downgrade which will entail to restart all the release process...<br/> Since this karaf feature is only used to perform some TPCE functional test, I can see if we can do thing in another way. Let me have a look to it today...</p> <p>you meant Su SR3 or I'm missing something ?</p> <p>Yes of course, this is Su SR3.</p> <p>In TransportPCE, we have overcomed this issue by switching on lighty build as the runtime for all TransportPCE functional tests on the gate instead of karaf. By this way, this issue is no longer blocking for Su-SR3 nor Cl-SR1.</p> Development External issue ID <a href="https://issues.apache.org/jira/browse/KARAF-7607">https://issues.apache.org/jira/browse/KARAF-7607</a> Rank 0|i042kt:4 Sprint Sprint 29 Sprint 30 Sprint 31 Sprint 32