<!-- 
RSS generated by JIRA (8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d) at Wed Feb 07 20:48:07 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>OpenDaylight JIRA</title>
    <link>https://jira.opendaylight.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.20.10</version>
        <build-number>820010</build-number>
        <build-date>22-06-2022</build-date>
    </build-info>


<item>
            <title>[VTN-128] CSIT for VTN Manager failed to verify ICMP action values in flowentries</title>
                <link>https://jira.opendaylight.org/browse/VTN-128</link>
                <project id="10185" key="VTN">vtn</project>
                    <description>&lt;p&gt;The CSIT flow filter test case is failing in the verification of action ICMP code and type in flowentreis&lt;/p&gt;

&lt;p&gt;Order of Test scenarios execution &lt;br/&gt;
&#8226;	VTN Flow filter&lt;br/&gt;
&#8226;	vBridge Flow filter&lt;br/&gt;
&#8226;	vBridge Interface flow filter.&lt;/p&gt;

&lt;p&gt;Topology used&lt;br/&gt;
h1,h2 &amp;lt;--&lt;del&gt;&amp;gt; s2 &amp;lt;&lt;/del&gt;-&lt;del&gt;&amp;gt; s1 &amp;lt;&lt;/del&gt;-&lt;del&gt;&amp;gt; s3 &amp;lt;&lt;/del&gt;--&amp;gt; h3,h4&lt;/p&gt;

&lt;p&gt;Following are the steps followed in the CSIT test script for both OF10 and OF13.&lt;/p&gt;

&lt;p&gt;1.	Create  Tenant1&lt;br/&gt;
2.	Create  vBridge1&lt;br/&gt;
3.	Create  interfaces(if1 and if2) in vBridge1&lt;br/&gt;
4.	Create portmapping for if1 and if2.&lt;br/&gt;
5.	Ping h1 and h3 &lt;br/&gt;
6.	Verify Ping success&lt;br/&gt;
7.	Create vBridge2,&lt;br/&gt;
8.	Create interfaces(if3and if4) in Vbridge 2,&lt;br/&gt;
9.	Create portmapping for if3 and if4.&lt;br/&gt;
10.	Ping h3 and h4	&lt;br/&gt;
11.	Verify ping success&lt;br/&gt;
12.	Add flow condition to match h1, h3 ip address&lt;br/&gt;
13.	Add VTN flowfilter to set flow action (&quot;vtn-set-icmp-code-action&quot; and &quot;vtn-set-icmp-type-action&quot;)&lt;br/&gt;
14.	Ping h1 and h3&lt;br/&gt;
15.	Verify ping failure&lt;br/&gt;
16.	Read the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not.&lt;br/&gt;
17.     Remove VTN Flowfilter index which has ICMP values &lt;br/&gt;
18.	Add VBR flowfilter to set flow action (&quot;vtn-set-icmp-code-action&quot; and &quot;vtn-set-icmp-type-action&quot;)&lt;br/&gt;
19.	Ping h1 and h3&lt;br/&gt;
20.	Verify ping failure&lt;br/&gt;
21.	Read the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not.&lt;br/&gt;
22.     Remove VTN Flowfilter index which has ICMP values &lt;br/&gt;
23.	Add VBRIf flowfilter in If1 to set flow action (&quot;vtn-set-icmp-code-action&quot; and &quot;vtn-set-icmp-type-action&quot;)&lt;br/&gt;
24.	Ping h1 and h3&lt;br/&gt;
25.	Verify ping failure&lt;br/&gt;
26.	Read the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not.&lt;br/&gt;
27      Remove VTN Flowfilter index which has ICMP values  &lt;br/&gt;
28.	Delete flow condition&lt;br/&gt;
29.	Delete vtn1&lt;/p&gt;

&lt;p&gt;In the above steps, Test cases failed in the below cases.&lt;/p&gt;

&lt;p&gt;For OF10:&lt;br/&gt;
In step 15, step 19 and step 23 we are expecting verify ping failure(mininet ping should not success between hosts h1 and h3) but pinging between hosts which makes test failures. &lt;br/&gt;
Because we have set action ICMP type=3 and cpde =1 which defines destination unreachable.&lt;/p&gt;

&lt;p&gt;For OF13:&lt;br/&gt;
In step 16, step 20 and step 24 reading the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not. But test cases fails and in mininet flows ICMP code and type values(mod_tp_src and mod_tp_dst) are not set. &lt;/p&gt;

&lt;p&gt;To understand the above issues, analyzed karaf log for VTN Manager module while the above steps were executed. Flow entry were installed with ICMP values and removed only when remove flowfilter cases were excuted. But test fails only when verifying flows in mininet.&lt;br/&gt;
Attached log as zip file icmp_karaf.zip:&lt;br/&gt;
karaf log file name -&amp;gt; icmp_karaf.log &lt;/p&gt;

&lt;p&gt;For OF10:&lt;br/&gt;
VTN Flow filter - Test steps 13-17&lt;br/&gt;
a)	Flow entry install request is issued in line 2444 at time stamp 2016-03-23 05:43:14,065&lt;br/&gt;
b)	Flow entries remove request has be issued in line 2648 at time stamp 2016-03-23 05:43:35,214&lt;/p&gt;

&lt;p&gt;VBR Flow filter &#8211; Test steps 18 &#8211; 22&lt;br/&gt;
a)	Flow entry install request is issued in line 2720 at time stamp 2016-03-23 05:43:35,263&lt;br/&gt;
b)	Flow entries remove request has be issued in line 2927 at time stamp 2016-03-23 05:43:56,464&lt;/p&gt;

&lt;p&gt;VBRIF Flow filter &#8211; Test steps 23 &#8211; 27&lt;br/&gt;
a)	Flow entry install request is issued in line 2996 at time stamp 2016-03-23 05:43:56,507&lt;br/&gt;
b)	Flow entries remove request has be issued in line 3167 at time stamp 2016-03-23 05:44:17,695&lt;/p&gt;


&lt;p&gt;For OF13:&lt;br/&gt;
VTN Flow filter - Test steps 13-17&lt;br/&gt;
a)	Flow entry install request is issued in line 6832 at time stamp 2016-03-23 05:48:03,683 &lt;br/&gt;
b)	Flow entries remove request has be issued in line 7036 at time stamp 2016-03-23 05:48:36,091&lt;/p&gt;

&lt;p&gt;VBR Flow filter &#8211; Test steps 18 &#8211; 22&lt;br/&gt;
a)	Flow entry install request is issued in line 7092 at time stamp 2016-03-23 05:48:36,130&lt;br/&gt;
b)	Flow entries remove request has be issued in line 7236 at time stamp 2016-03-23 05:49:09,014&lt;/p&gt;

&lt;p&gt;VBRIF Flow filter &#8211; Test steps 23 &#8211; 27&lt;br/&gt;
a)	Flow entry install request is issued in line 7286 at time stamp 2016-03-23 05:49:09,053&lt;br/&gt;
b)	Flow entries remove request has be issued in line 7484 at time stamp 2016-03-23 05:49:41,478&lt;/p&gt;


&lt;p&gt;Copied dumpflow output from Mininet in Sandbox:&lt;/p&gt;

&lt;p&gt;dump-flow log for OF10 in switch s3: Here we can see ICMP code and type value set as actions=mod_tp_dst:1,mod_tp_src:3&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;
	&lt;ul&gt;
		&lt;li&gt;
		&lt;ul&gt;
			&lt;li&gt;s3 ------------------------------------------------------------------------&lt;br/&gt;
NXST_FLOW reply (xid=0x4):&lt;br/&gt;
 cookie=0x7f5600000000000e, duration=21.079s, table=0, n_packets=19, n_bytes=1862, idle_age=1, priority=14,icmp,in_port=3,vlan_tci=0x0000,dl_src=86:1f:a7:79:cb:69,dl_dst=46:fa:9e:28:b0:12,nw_src=10.0.0.1,nw_dst=10.0.0.3 actions=mod_tp_dst:1,mod_tp_src:3,output:1     &amp;lt;&amp;lt;-------------&lt;br/&gt;
 cookie=0x7f5600000000000f, duration=20.106s, table=0, n_packets=18, n_bytes=1764, idle_timeout=300, idle_age=1, priority=12,ip,in_port=1,vlan_tci=0x0000,dl_src=46:fa:9e:28:b0:12,dl_dst=86:1f:a7:79:cb:69,nw_src=10.0.0.3 actions=output:3&lt;br/&gt;
 cookie=0x7f56000000000010, duration=15.094s, table=0, n_packets=0, n_bytes=0, idle_timeout=300, idle_age=15, priority=11,arp,in_port=1,vlan_tci=0x0000,dl_src=46:fa:9e:28:b0:12,dl_dst=86:1f:a7:79:cb:69 actions=output:3&lt;br/&gt;
 cookie=0x7f56000000000011, duration=15.091s, table=0, n_packets=0, n_bytes=0, idle_age=15, priority=11,arp,in_port=3,vlan_tci=0x0000,dl_src=86:1f:a7:79:cb:69,dl_dst=46:fa:9e:28:b0:12 actions=output:1&lt;/li&gt;
		&lt;/ul&gt;
		&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;dump-flow log for OF13 in switch s3: Here ICMP code and type values are not set in flowentries.&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;
	&lt;ul&gt;
		&lt;li&gt;
		&lt;ul&gt;
			&lt;li&gt;s3 ------------------------------------------------------------------------&lt;br/&gt;
OFPST_FLOW reply (OF1.3) (xid=0x2):&lt;br/&gt;
 cookie=0x7f57ffffffffffff, duration=73.772s, table=0, n_packets=75, n_bytes=5612, send_flow_rem priority=0 actions=CONTROLLER:65535&lt;br/&gt;
 cookie=0x7f56000000000037, duration=24.247s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=11,arp,in_port=3,vlan_tci=0x0000/0x1fff,dl_src=26:33:e6:4b:32:58,dl_dst=86:d0:90:26:f9:06 actions=output:1&lt;br/&gt;
 cookie=0x7f56000000000038, duration=24.242s, table=0, n_packets=0, n_bytes=0, idle_timeout=300, send_flow_rem priority=11,arp,in_port=1,vlan_tci=0x0000/0x1fff,dl_src=86:d0:90:26:f9:06,dl_dst=26:33:e6:4b:32:58 actions=output:3&lt;br/&gt;
mininet&amp;gt; &lt;/li&gt;
		&lt;/ul&gt;
		&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;



&lt;p&gt;Attached karaf log file as icmp_karaf.zip&lt;/p&gt;</description>
                <environment>&lt;p&gt;Operating System: All&lt;br/&gt;
Platform: All&lt;/p&gt;</environment>
        <key id="26508">VTN-128</key>
            <summary>CSIT for VTN Manager failed to verify ICMP action values in flowentries</summary>
                <type id="10104" iconUrl="https://jira.opendaylight.org/secure/viewavatar?size=xsmall&amp;avatarId=10303&amp;avatarType=issuetype">Bug</type>
                                                <status id="5" iconUrl="https://jira.opendaylight.org/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10003">Cannot Reproduce</resolution>
                                        <assignee username="-1">Unassigned</assignee>
                                    <reporter username="siva-karthik@hcl.com">Karthik Sivasamy</reporter>
                        <labels>
                    </labels>
                <created>Wed, 23 Mar 2016 07:40:52 +0000</created>
                <updated>Thu, 19 Oct 2017 21:25:04 +0000</updated>
                            <resolved>Mon, 18 Jul 2016 05:35:51 +0000</resolved>
                                    <version>unspecified</version>
                                                    <component>VTN Manager</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>0</watches>
                                                                                                                <comments>
                            <comment id="53111" author="siva-karthik@hcl.com" created="Wed, 23 Mar 2016 07:40:52 +0000"  >&lt;p&gt;Attachment icmp_karaf.zip has been added with description: Karaf log enabled TRACE for VTN Manager&lt;/p&gt;</comment>
                            <comment id="53108" author="siva-karthik@hcl.com" created="Thu, 14 Jul 2016 07:23:57 +0000"  >&lt;p&gt;Steps followed for verifying the Bug:&lt;br/&gt;
=====================================&lt;/p&gt;

&lt;p&gt;Tested with Be/SR2 distro for verification of action ICMP code and type in flowentries.&lt;/p&gt;

&lt;p&gt;Since ICMP code and type are not supported in ovs2.3.0&lt;br/&gt;
I have updated mininet with latest OVS 2.5.0. &lt;/p&gt;

&lt;p&gt;Issue is not reproduced. Now i can see in flowentries created with ICMP code and type actions successfully.&lt;/p&gt;

&lt;p&gt;Verified both Karaf.log and mininet, i have seen icmp parameters.&lt;/p&gt;

&lt;p&gt;Followed the same steps which i followed when i raised the bug, which is in the earlier commetns.&lt;/p&gt;

&lt;p&gt;Mininet Output:&lt;br/&gt;
===============&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;
	&lt;ul&gt;
		&lt;li&gt;
		&lt;ul&gt;
			&lt;li&gt;s3 ------------------------------------------------------------------------&lt;br/&gt;
NXST_FLOW reply (xid=0x4):&lt;br/&gt;
 cookie=0x7f5600000000000a, duration=11.425s, table=0, n_packets=4, n_bytes=392, idle_age=7, priority=14,icmp,in_port=3,vlan_tci=0x0000/0x1fff,dl_src=ea:a1:b9:df:06:6e,dl_dst=9e:89:4a:13:cc:80,nw_src=10.0.0.1,nw_dst=10.0.0.3 &lt;br/&gt;
============================================================================&lt;br/&gt;
actions=load:0x3-&amp;gt;NXM_OF_ICMP_CODE[],load:0x6-&amp;gt;NXM_OF_ICMP_TYPE[],output:1&lt;br/&gt;
============================================================================&lt;br/&gt;
 cookie=0x7f56000000000009, duration=11.436s, table=0, n_packets=0, n_bytes=0, idle_timeout=300, idle_age=11, priority=11,arp,in_port=1,vlan_tci=0x0000/0x1fff,dl_src=9e:89:4a:13:cc:80,dl_dst=ea:a1:b9:df:06:6e actions=output:3&lt;br/&gt;
 cookie=0x7f57ffffffffffff, duration=1191.123s, table=0, n_packets=239, n_bytes=20272, idle_age=3, priority=0 actions=CONTROLLER:65535&lt;br/&gt;
mininet&amp;gt;&lt;/li&gt;
		&lt;/ul&gt;
		&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;




&lt;p&gt;Karaf Log:&lt;br/&gt;
==========&lt;/p&gt;

&lt;p&gt;2016-07-14 08:29:34,422 | DEBUG | TN Flow Thread-0 | FlowAddContext                   | 189 - org.opendaylight.vtn.manager.implementation - 0.4.2.Beryllium-SR2 | Data flow has been installed: id=9&lt;br/&gt;
2016-07-14 08:29:34,427 | TRACE | TN Flow Thread-0 | FlowAddContext                   | 189 - org.opendaylight.vtn.manager.implementation - 0.4.2.Beryllium-SR2 | Flow entry has been installed: flow=[id=7f5600000000000a-1, pri=14, timeout=(0,0), node=openflow:1, ingress=openflow:1:1, cond=&lt;/p&gt;
{DL_SRC=ea:a1:b9:df:06:6e,DL_DST=9e:89:4a:13:cc:80,DL_TYPE=2048,DL_VLAN=0,IP_SRC=10.0.0.1,IP_DST=10.0.0.3,IP_PROTO=1}
&lt;p&gt;, actions=&lt;/p&gt;
{OUTPUT(port=openflow:1:2, len=65535)}
&lt;p&gt;2016-07-14 08:29:34,432 | TRACE | TN Flow Thread-0 | FlowAddContext                   | 189 - org.opendaylight.vtn.manager.implementation - 0.4.2.Beryllium-SR2 | Flow entry has been installed: flow=[id=7f5600000000000a-2, pri=14, timeout=(0,0), node=openflow:3, ingress=openflow:3:3, cond=&lt;/p&gt;
{DL_SRC=ea:a1:b9:df:06:6e,DL_DST=9e:89:4a:13:cc:80,DL_TYPE=2048,DL_VLAN=0,IP_SRC=10.0.0.1,IP_DST=10.0.0.3,IP_PROTO=1}
&lt;p&gt;, actions=&lt;/p&gt;
{SET_TP_DST(port=3), SET_TP_SRC(port=6), OUTPUT(port=openflow:3:1, len=65535)}
&lt;p&gt;2016-07-14 08:29:34,436 | TRACE | TN Flow Thread-0 | FlowAddContext                   | 189 - org.opendaylight.vtn.manager.implementation - 0.4.2.Beryllium-SR2 | Flow entry has been installed: flow=[id=7f5600000000000a-0, pri=14, timeout=(300,0), node=openflow:2, ingress=openflow:2:1, cond=&lt;/p&gt;
{DL_SRC=ea:a1:b9:df:06:6e,DL_DST=9e:89:4a:13:cc:80,DL_TYPE=2048,DL_VLAN=0,IP_SRC=10.0.0.1,IP_DST=10.0.0.3,IP_PROTO=1}
&lt;p&gt;, actions=&lt;/p&gt;
{OUTPUT(port=openflow:2:3, len=65535)}
&lt;p&gt;2016-07-14 08:29:34,436 | DEBUG | TN Flow Thread-0 | FlowAddContext                   | 189 - org.opendaylight.vtn.manager.implementation - 0.4.2.Beryllium-SR2 | Data flow has been installed: id=10&lt;/p&gt;




&lt;p&gt;Below are the flowentries from mininet for OF10.&lt;/p&gt;


&lt;p&gt;1.	Create  Tenant1&lt;br/&gt;
2.	Create  vBridge1&lt;br/&gt;
3.	Create  interfaces(if1 and if2) in vBridge1&lt;br/&gt;
4.	Create portmapping for if1 and if2.&lt;br/&gt;
5.	Ping h1 and h3 &lt;br/&gt;
6.	Verify Ping success&lt;br/&gt;
7.	Create vBridge2,&lt;br/&gt;
8.	Create interfaces(if3and if4) in Vbridge 2,&lt;br/&gt;
9.	Create portmapping for if3 and if4.&lt;br/&gt;
10.	Ping h3 and h4	&lt;br/&gt;
11.	Verify ping success&lt;br/&gt;
12.	Add flow condition to match h1, h3 ip address&lt;br/&gt;
13.	Add VTN flowfilter to set flow action (&quot;vtn-set-icmp-code-action&quot; and &quot;vtn-set-icmp-type-action&quot;)&lt;br/&gt;
14.	Ping h1 and h3&lt;br/&gt;
15.	Verify ping failure&lt;br/&gt;
16.	Read the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not.&lt;br/&gt;
17.     Remove VTN Flowfilter index which has ICMP values &lt;br/&gt;
18.	Add VBR flowfilter to set flow action (&quot;vtn-set-icmp-code-action&quot; and &quot;vtn-set-icmp-type-action&quot;)&lt;br/&gt;
19.	Ping h1 and h3&lt;br/&gt;
20.	Verify ping failure&lt;br/&gt;
21.	Read the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not.&lt;br/&gt;
22.     Remove VTN Flowfilter index which has ICMP values &lt;br/&gt;
23.	Add VBRIf flowfilter in If1 to set flow action (&quot;vtn-set-icmp-code-action&quot; and &quot;vtn-set-icmp-type-action&quot;)&lt;br/&gt;
24.	Ping h1 and h3&lt;br/&gt;
25.	Verify ping failure&lt;br/&gt;
26.	Read the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not.&lt;br/&gt;
27      Remove VTN Flowfilter index which has ICMP values  &lt;br/&gt;
28.	Delete flow condition&lt;br/&gt;
29.	Delete vtn1&lt;/p&gt;</comment>
                            <comment id="53109" author="siva-karthik@hcl.com" created="Thu, 14 Jul 2016 07:48:34 +0000"  >&lt;p&gt;I have Tested for below keytypes,&lt;/p&gt;

&lt;p&gt;&#8226;	VTN Flow filter&lt;br/&gt;
&#8226;	vBridge Flow filter&lt;br/&gt;
&#8226;	vBridge Interface flow filter.&lt;/p&gt;

&lt;p&gt;And in mininet i have created topolofy in both OF10 and OF13 switch.&lt;/p&gt;

&lt;p&gt;Both are working fine.&lt;/p&gt;</comment>
                            <comment id="53110" author="siva-karthik@hcl.com" created="Thu, 14 Jul 2016 12:54:37 +0000"  >&lt;p&gt;Tested manually to verify ICMP code and Type action in Flowentries, by updating OVS version from 2.3.1 to 2.5.0 and found issue is not reproduced. So updated status to Resolved and &quot;Wontfix&quot;&lt;/p&gt;

&lt;p&gt;Since CSIT cases not yet fixed, in releng CSIT environment, OVS version not yet updated to OVS 2.5.0. Changing of actions ICMP code and types fields are supported from OVS 2.5.0.&lt;/p&gt;

&lt;p&gt;Once the OVS version is updated to OVS2.5.0 in releng environment, we will apply fix the patch to enable ICMP code and Type cases. &lt;/p&gt;

&lt;p&gt;And then we will change bug status to &apos;Resolved&apos; and &apos;Fixed&apos;.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="13712" name="icmp_karaf.zip" size="195947" author="siva-karthik@hcl.com" created="Wed, 23 Mar 2016 07:40:52 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_11400" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10208" key="com.atlassian.jira.plugin.system.customfieldtypes:textfield">
                        <customfieldname>External issue ID</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5587</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10201" key="com.atlassian.jira.plugin.system.customfieldtypes:url">
                        <customfieldname>External issue URL</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[https://bugs.opendaylight.org/show_bug.cgi?id=5587]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i02trb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>