https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGIDE-11 yangide <p>I just noticed that the yangide source tree actually includes x4 test projects, but as of today none of them are currently not run during its build and for proposed Gerrit changes. Having tests but not running them seems a shame! (Perhaps something like <a href="https://jira.opendaylight.org/browse/YANGIDE-10" title="java.lang.ClassNotFoundException: org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor$YangProvider at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)" class="issue-link" data-issue-key="YANGIDE-10">YANGIDE-10</a> would even have been detected by this?)</p> <p>This bug is to discuss what it would take in particular the existing tests in org.opendaylight.yangide.core.tests and org.opendaylight.yangide.m2e.yang.tests for build and proposed Gerrit changes. (I'll create a separate new bug for two other test bundles which I found.)</p> <p>I can see that these are commented out in the &lt;modules&gt; of the root pom.xml, but I don't really understand why .. do they not run (anymore?) - need help to get them green? </p> <p>Or were they perhaps commented out fearing that they will not run on a build server due to UI dependencies? As far as I saw, these two actually do NOT contain UI tests, so should be fine.</p> <p>Operating System: All<br/> Platform: All</p> YANGIDE-11

(Re)enable non-UI tests for build and proposed Gerrit changes

Improvement Open Unresolved Unassigned Michael Vorburger Mon, 9 May 2016 14:22:03 +0000 Thu, 26 Oct 2017 09:40:34 +0000 unspecified General 0 1 <p>&gt; I'll create a separate new bug for two other test bundles which I found</p> <p><a href="https://jira.opendaylight.org/browse/YANGIDE-12" title="(Re)enable UI (!) tests for build and proposed Gerrit changes" class="issue-link" data-issue-key="YANGIDE-12"><del>YANGIDE-12</del></a> created specifically for UI related tests (this one just for non-UI).</p> <p>&gt; these are commented out in the &lt;modules&gt; of the root pom.xml</p> <p>BTW: This has the curious side effect that in a <a href="https://github.com/vorburger/opendaylight-eclipse-setup" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/vorburger/opendaylight-eclipse-setup</a> provision workspace, or even when one does a manual Import Existing Maven Projects from the yangide root directory, then org.opendaylight.yangide.core.tests and org.opendaylight.yangide.m2e.yang.tests do not get imported. It appears that M2E appears to be (IMHO too..) smart and "filters" out projects which are not in &lt;modules&gt;.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/38586/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38586/</a> raised for this, and:</p> <p>Locally it passed just fine (without opening any UI related pop-ups), see:</p> <p>Running org.opendaylight.yangide.m2e.yang.tests.YangGenerationTest<br/> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".<br/> SLF4J: Defaulting to no-operation (NOP) logger implementation<br/> SLF4J: See <a href="http://www.slf4j.org/codes.html#StaticLoggerBinder" class="external-link" target="_blank" rel="nofollow noopener">http://www.slf4j.org/codes.html#StaticLoggerBinder</a> for further details.<br/> TEST-SETUP: test_p001_simple<br/> <span class="error">&#91;I&#93;</span> Project: yang-p001<br/> <span class="error">&#91;I&#93;</span> simple-string-demo@2013-06-18 - simple-string-demo - MODULE<br/> <span class="error">&#91;I&#93;</span> simple-string-demo@2013-06-18 - typedef-string - TYPE<br/> <span class="error">&#91;IR&#93;</span> QName <span class="error">&#91;module=simple-string-demo, prefix=sbd, name=string, revision=2013-06-18&#93;</span> : TYPE_REF - yang-p001@/yang-p001/src/main/yang/simple-string-demo.yang<br/> <span class="error">&#91;I&#93;</span> Project: yang-p001<br/> <span class="error">&#91;x&#93;</span> L/yang-p001/src/main/yang/simple-string-demo.yang<br/> <span class="error">&#91;I&#93;</span> Project: yang-p001<br/> <span class="error">&#91;x&#93;</span> L/yang-p001/src/main/yang/simple-string-demo.yang<br/> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 186.97 sec - in org.opendaylight.yangide.m2e.yang.tests.YangGenerationTest<br/> test_p001_simple(org.opendaylight.yangide.m2e.yang.tests.YangGenerationTest) Time elapsed: 181.035 sec</p> <p><span class="error">&#91;INFO&#93;</span> org.opendaylight.yangide.m2e.yang.tests ............ SUCCESS <span class="error">&#91;03:22 min&#93;</span><br/> <span class="error">&#91;INFO&#93;</span> org.opendaylight.yangide.core.tests ................ SUCCESS [ 21.185 s]</p> <p>That YangGenerationTest does seem slow though at 3 minutes.</p> <p>On <a href="https://jenkins.opendaylight.org/releng/job/yangide-verify-boron/jdk=openjdk8,nodes=dynamic_verify/31/console" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/releng/job/yangide-verify-boron/jdk=openjdk8,nodes=dynamic_verify/31/console</a> this failed with:</p> <p>org.eclipse.swt.SWTError: No more handles <span class="error">&#91;gtk_init_check() failed&#93;</span><br/> at org.eclipse.swt.SWT.error(SWT.java:4517)<br/> at org.eclipse.swt.widgets.Display.createDisplay(Display.java:908)<br/> at org.eclipse.swt.widgets.Display.create(Display.java:892)<br/> at org.eclipse.swt.graphics.Device.&lt;init&gt;(Device.java:156)<br/> at org.eclipse.swt.widgets.Display.&lt;init&gt;(Display.java:512)<br/> at org.eclipse.swt.widgets.Display.&lt;init&gt;(Display.java:503)<br/> at org.eclipse.swt.widgets.Display.getDefault(Display.java:1704)<br/> at org.eclipse.jface.preference.PreferenceConverter.&lt;clinit&gt;(PreferenceConverter.java:81)<br/> at org.opendaylight.yangide.ui.internal.preferences.YangUIPreferenceInitializer.initializeDefaultPreferences(YangUIPreferenceInitializer.java:37)<br/> at org.eclipse.core.internal.preferences.PreferenceServiceRegistryHelper$1.run(PreferenceServiceRegistryHelper.java:300)<br/> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)<br/> at org.eclipse.core.internal.preferences.PreferenceServiceRegistryHelper.runInitializer(PreferenceServiceRegistryHelper.java:303)<br/> at org.eclipse.core.internal.preferences.PreferenceServiceRegistryHelper.applyRuntimeDefaults(PreferenceServiceRegistryHelper.java:131)<br/> at org.eclipse.core.internal.preferences.PreferencesService.applyRuntimeDefaults(PreferencesService.java:368)<br/> at org.eclipse.core.internal.preferences.DefaultPreferences.applyRuntimeDefaults(DefaultPreferences.java:221)<br/> at org.eclipse.core.internal.preferences.DefaultPreferences.load(DefaultPreferences.java:274)<br/> at org.eclipse.core.internal.preferences.EclipsePreferences.create(EclipsePreferences.java:409)<br/> at org.eclipse.core.internal.preferences.EclipsePreferences.internalNode(EclipsePreferences.java:670)<br/> at org.eclipse.core.internal.preferences.EclipsePreferences.node(EclipsePreferences.java:812)<br/> at org.eclipse.core.internal.preferences.AbstractScope.getNode(AbstractScope.java:38)<br/> at org.eclipse.core.runtime.preferences.DefaultScope.getNode(DefaultScope.java:76)<br/> at org.eclipse.ui.preferences.ScopedPreferenceStore.getDefaultPreferences(ScopedPreferenceStore.java:238)<br/> at org.eclipse.ui.preferences.ScopedPreferenceStore.getPreferenceNodes(ScopedPreferenceStore.java:269)<br/> at org.eclipse.ui.preferences.ScopedPreferenceStore.internalGet(ScopedPreferenceStore.java:419)<br/> at org.eclipse.ui.preferences.ScopedPreferenceStore.getBoolean(ScopedPreferenceStore.java:359)<br/> at org.opendaylight.yangide.m2e.yang.YangBuildParticipant.build(YangBuildParticipant.java:83)<br/> at org.eclipse.m2e.core.internal.builder.MavenBuilderImpl.build(MavenBuilderImpl.java:137)<br/> at org.eclipse.m2e.core.internal.builder.MavenBuilder$1.method(MavenBuilder.java:172)<br/> at org.eclipse.m2e.core.internal.builder.MavenBuilder$1.method(MavenBuilder.java:1)<br/> at org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod$1$1.call(MavenBuilder.java:115)<br/> at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:176)<br/> at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:112)<br/> at org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod$1.call(MavenBuilder.java:105)<br/> at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:176)<br/> at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:151)<br/> at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:99)<br/> at org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.execute(MavenBuilder.java:86)<br/> at org.eclipse.m2e.core.internal.builder.MavenBuilder.build(MavenBuilder.java:200)<br/> at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:734)<br/> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)<br/> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:205)<br/> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:245)<br/> at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:300)<br/> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)<br/> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:303)<br/> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:262)<br/> at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:402)<br/> at org.eclipse.core.internal.resources.Project$1.run(Project.java:556)<br/> at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2241)<br/> at org.eclipse.core.internal.resources.Project.internalBuild(Project.java:534)<br/> at org.eclipse.core.internal.resources.Project.build(Project.java:111)<br/> at org.opendaylight.yangide.m2e.yang.tests.YangGenerationTest.test_p001_simple(YangGenerationTest.java:32)</p> <p>So this "non-UI" test behind still requires a UI (because of a YangUIPreferenceInitializer from org.opendaylight.yangide.org.opendaylight.yangide.ui.</p> <p>Because you would need to have at least a "virtual" UI anyway for <a href="https://jira.opendaylight.org/browse/YANGIDE-12" title="(Re)enable UI (!) tests for build and proposed Gerrit changes" class="issue-link" data-issue-key="YANGIDE-12"><del>YANGIDE-12</del></a> I would suggest that as per <a href="https://documentation.cloudbees.com/docs/dev-at-cloud/CI_Testing_GUI_Applications.html" class="external-link" target="_blank" rel="nofollow noopener">https://documentation.cloudbees.com/docs/dev-at-cloud/CI_Testing_GUI_Applications.html</a> this could be addressed by using <a href="https://wiki.jenkins-ci.org/display/JENKINS/Xvfb+Plugin" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.jenkins-ci.org/display/JENKINS/Xvfb+Plugin</a> or <a href="https://wiki.jenkins-ci.org/display/JENKINS/Xvnc+Plugin" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.jenkins-ci.org/display/JENKINS/Xvnc+Plugin</a> on jenkins.opendaylight.org. How do we get that configured?</p> <p>Getting the tests fully working (reliably) will be a project in itself. I commented out those modules in the POM because I often saw them failing in the command line build, even when they would succeed running interactively in Eclipse.</p> <p>I've already informally broached the subject of running automated UI tests with Thanh and Andy (Grimberg). I had more important things to get working.</p> <p>Next step: Waiting for reply to helpdesk@opendaylight.org helpdesk ticket #22870, and/or <a href="https://lists.opendaylight.org/pipermail/dev/2016-May/001999.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/dev/2016-May/001999.html</a> ..</p> <p>Helpdesk meanwhile gave me access to Jenkins sandbox. Email below clarifies what needs to be done next.</p> <p>Assigning to myself to indicate that I'm hoping to eventually get to this, but likely only during July and not June. If anyone gets to this earlier, please do and update status here.</p> <p>---------- Forwarded message ----------<br/> From: Thanh Ha via RT &lt;helpdesk@opendaylight.org&gt;<br/> Date: Wed, May 11, 2016 at 1:49 AM<br/> Subject: <a href="#22870" target="_blank" rel="noopener">opendaylight.org #22870</a> Fwd: <span class="error">&#91;opendaylight-dev&#93;</span> How to get new Jenkins plugins for "virtual" X11 for UI testing installed?<br/> To: vorburger@redhat.com</p> <p>On Mon May 09 15:15:23 2016, vorburger@redhat.com wrote:<br/> &gt; &gt; What do I have to do to get, as per<br/> &gt; &gt; <a href="https://documentation.cloudbees.com/docs/dev-at-" class="external-link" target="_blank" rel="nofollow noopener">https://documentation.cloudbees.com/docs/dev-at-</a><br/> &gt; &gt; cloud/CI_Testing_GUI_Applications.html,<br/> &gt; &gt; either <a href="https://wiki.jenkins-ci.org/display/JENKINS/Xvfb+Plugin" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.jenkins-ci.org/display/JENKINS/Xvfb+Plugin</a> or<br/> &gt; &gt; <a href="https://wiki.jenkins-ci.org/display/JENKINS/Xvnc+Plugin" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.jenkins-ci.org/display/JENKINS/Xvnc+Plugin</a> installed on<br/> &gt; &gt; jenkins.opendaylight.org and activated on the yangide build jobs?</p> <p>I installed both plugins in the sandbox and will entrust you to test and recommend to us which one we should deploy to production. They both appear to be supported by JJB which is a good thing:</p> <p><a href="http://docs.openstack.org/infra/jenkins-job-builder/wrappers.html" class="external-link" target="_blank" rel="nofollow noopener">http://docs.openstack.org/infra/jenkins-job-builder/wrappers.html</a></p> <p>If you find there are features that you cannot configure with JJB and need support for it. Feel free to post on the dev mailing list with the <span class="error">&#91;releng&#93;</span> topic. We have an intern this summer who is working on JJB who can implement any missing functionality if necessary.</p> <p>&gt; &gt; This would be useful for<br/> &gt; &gt; <a href="https://bugs.opendaylight.org/show_bug.cgi?id=5864" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=5864</a>, needed to get<br/> &gt; &gt; <a href="https://git.opendaylight.org/gerrit/#/c/38586/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38586/</a> to pass.<br/> &gt; &gt;<br/> &gt; &gt; I'm willing to help, but do not seem to have the require permissions<br/> &gt; &gt; to<br/> &gt; &gt; install new plugins on Jenkins and change the configuration of plans.<br/> &gt; &gt; So<br/> &gt; &gt; I'm assuming there's someone else who would do this for me? <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/wink.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>That's great, please keep us in the loop on your findings. Our systems build using dynamically allocated build slaves so you may find that additional dependencies might be needed to be installed on the slave systems. Our CI Jenkins page which I linked to you today should have details on the different slave types and you can find the vagrant definitions for those slaves in the releng/builder repo under the "vagrant" directory. Unfortunately updates to these files currently require helpdesk to respin the images and we're in the middle of transitioning to the private cloud so there might be some blocking issues here if you need vagrants updated until the private cloud migration is complete.</p> <p>Thanks,<br/> Thanh</p> <p>Un-assigning issues I'll never work on... (I've no interest in yangide anymore.)</p> Blocks YANGIDE-12 Duplicate YANGIDE-12 Development External issue ID 5864 External issue URL Rank 0|i02y7r: