https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-1003 yangtools <p>Given rpc definition:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> rpc some-action {   input {     anyxml data;   } } </pre> </div></div> <p>And data passed into restconf:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> { <span class="code-quote">"input"</span> : {     <span class="code-quote">"data"</span> : [       { <span class="code-quote">"key"</span> : <span class="code-quote">"value"</span> }     ]   } }   </pre> </div></div> <p>results in following json element received from gson codec: </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-quote">"data"</span> : {   <span class="code-quote">"array-element"</span> : { <span class="code-quote">"key"</span> : <span class="code-quote">" value"</span> } } </pre> </div></div> <p> </p> <p>This breaks how jsonrpc digests anyxml data from restconf.</p> <p>I can't find reference to this behavior in RFC7951, so I think this is a bug.</p> YANGTOOLS-1003

Anyxml list data are wrapped in "array-element"

Bug Medium Confirmed Unresolved Unassigned Richard Kosegi Mon, 10 Jun 2019 20:15:23 +0000 Wed, 24 Jun 2020 11:34:20 +0000 2.0.12 2.1.10 3.0.2 4.0.8 codecs 0 2 <p>This has been the behaviour from day one. The reason for 'array-element' is that XML encoding loses list encapsulation so if you read JSON anyxml and write the thing out you'd lose the brackets in data. JSON codec uses this information to accurately emit the brackets. If you use JSON codec to send out the result, you will get a correct JSON – not perfect, but it works.</p> <p>Now to fix this without regressing, JSON codec needs to do something similar as DOMSourceAnydata is doing, but as a subclass of DOMSource containing an unencapsulated tree (passed to DOMSource constructor) and an encapulated tree (kept as an additional field). JSON egress needs to recognize this subclass and pick the escaped tree when writing out JSON.</p> <p>Thanks <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=rovarga" class="user-hover" rel="rovarga">rovarga</a> for info. Can you elaborate a bit on "If you use JSON codec to send out the result"?</p> <p>Problem is actually in both ways.</p> <p>1, when user use restconf to invoke RPC with anyxml in input, following code is called <a href="https://github.com/opendaylight/jsonrpc/blob/master/impl/src/main/java/org/opendaylight/jsonrpc/impl/JsonConverter.java#L219" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/jsonrpc/blob/master/impl/src/main/java/org/opendaylight/jsonrpc/impl/JsonConverter.java#L219</a></p> <p>Before we send anything out, I can modify data and apply fix.</p> <p>2, But when response is received from external entity, following code is called <a href="https://github.com/opendaylight/jsonrpc/blob/master/impl/src/main/java/org/opendaylight/jsonrpc/impl/JsonRPCtoRPCBridge.java#L303" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/jsonrpc/blob/master/impl/src/main/java/org/opendaylight/jsonrpc/impl/JsonRPCtoRPCBridge.java#L303 </a>to form NormalizedNode.</p> <p>There is no way I'm aware of I can do anything here, RPC output will be wrapped in array-element (if RPC output has anyxml node and data contains list)</p> <p> </p> <p>The constant comes from <a href="https://github.com/opendaylight/yangtools/blob/master/yang/yang-data-codec-gson/src/main/java/org/opendaylight/yangtools/yang/data/codec/gson/JsonParserStream.java#L66" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/yangtools/blob/master/yang/yang-data-codec-gson/src/main/java/org/opendaylight/yangtools/yang/data/codec/gson/JsonParserStream.java#L66</a> and is supposed to be eliminated when the DOMSource is streamed out again, i.e. in the JSON -&gt; DOMSource -&gt; JSON case. Not sure that works.</p> <p>The reason is that if the anyxml element represents a list, it needs to be captured as such – and hence it needs a containment node, which is <b>not</b> part of DOMSource specification – i.e. it would <b>not</b> be present were the anyxml node parsed from XML.</p> <p>As noted, this will need JSON-level event buffering, where the DOMSource view of anyxml will be not contain this hack use proper format. See <a href="https://jira.opendaylight.org/browse/YANGTOOLS-994" title="Add support for JSON-encoded anydata" class="issue-link" data-issue-key="YANGTOOLS-994">YANGTOOLS-994</a> for details.</p> Relates YANGTOOLS-994 Development Rank 0|i03o5z: