https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-1046 yangtools <p>When generating Json with codec.gson.JSONNormalizedNodeStreamWriter,<br/> a closing curly bracket is missing. </p> YANGTOOLS-1046

The generated Json is missing a closing curly bracket

Bug Medium Resolved Won't Do Ahmed Triki Ahmed Triki Mon, 2 Dec 2019 15:36:32 +0000 Tue, 3 Dec 2019 17:19:03 +0000 Tue, 3 Dec 2019 17:19:03 +0000 3.0.6 codecs 0 2 <p>What version, what are the steps to reproduce?</p> <p>I am using the method createJsonStringFromDataObject (below) to generate json from DataObject. The version of org.opendaylight.yangtools/odl-yangtools-codec is 3.0.6.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">public</span> <span class="code-object">String</span> createJsonStringFromDataObject(<span class="code-keyword">final</span> InstanceIdentifier&lt;?&gt; id, DataObject object) <span class="code-keyword">throws</span> Exception { <span class="code-keyword">final</span> SchemaPath scPath = SchemaPath .create(FluentIterable.from(id.getPathArguments()).transform(<span class="code-keyword">new</span> Function&lt;PathArgument, QName&gt;() { @Override <span class="code-keyword">public</span> QName apply(<span class="code-keyword">final</span> PathArgument input) { <span class="code-keyword">return</span> BindingReflections.findQName(input.getType()); } }), <span class="code-keyword">true</span>); <span class="code-keyword">final</span> Writer writer = <span class="code-keyword">new</span> StringWriter(); NormalizedNodeStreamWriter domWriter; <span class="code-keyword">try</span> { <span class="code-comment">// Prepare the variables </span> <span class="code-keyword">final</span> ModuleInfoBackedContext moduleContext = ModuleInfoBackedContext.create(); Iterable&lt;? <span class="code-keyword">extends</span> YangModuleInfo&gt; moduleInfos = Collections .singleton(BindingReflections.getModuleInfo(object.getClass())); moduleContext.addModuleInfos(moduleInfos); SchemaContext schemaContext = moduleContext.tryToCreateSchemaContext().get(); BindingRuntimeContext bindingContext; bindingContext = BindingRuntimeContext.create(moduleContext, schemaContext); <span class="code-keyword">final</span> BindingNormalizedNodeCodecRegistry codecRegistry = <span class="code-keyword">new</span> BindingNormalizedNodeCodecRegistry(bindingContext); /* * This function needs : - context - scPath.getParent() - * scPath.getLastComponent().getNamespace(), - * JsonWriterFactory.createJsonWriter(writer) */ domWriter = JSONNormalizedNodeStreamWriter.createExclusiveWriter( JSONCodecFactorySupplier.DRAFT_LHOTKA_NETMOD_YANG_JSON_02.createSimple(schemaContext), scPath.getParent(), scPath.getLastComponent().getNamespace(), JsonWriterFactory.createJsonWriter(writer, 2)); <span class="code-comment">// The write part </span> <span class="code-keyword">final</span> BindingStreamEventWriter bindingWriter = codecRegistry.newWriter(id, domWriter); codecRegistry.getSerializer(id.getTargetType()).serialize(object, bindingWriter); writer.close(); } <span class="code-keyword">catch</span> (IOException e) { LOG.error(<span class="code-quote">" writer error "</span>); } <span class="code-keyword">catch</span> (YangSyntaxErrorException e) { LOG.warn(<span class="code-quote">"exception {} occured during json file creation"</span>, e.getMessage(), e); } <span class="code-keyword">catch</span> (ReactorException e) { LOG.warn(<span class="code-quote">" exception {} occured during json file creation"</span>, e.getMessage(), e); } <span class="code-keyword">return</span> writer.toString(); } </pre> </div></div> <p>Right, you need to close domWriter.</p> Relates YANGTOOLS-1029 Development Rank 0|i03q8v: