https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-1316 yangtools <p>With <a href="https://jira.opendaylight.org/browse/YANGTOOLS-1066" title="SchemaPath identification of SchemaNodes is costly and useless" class="issue-link" data-issue-key="YANGTOOLS-1066"><del>YANGTOOLS-1066</del></a> out of the way it becomes obvious we may be storing the argument multiple times when we are dealing with original statement.</p> <p>More specifically, AbstractLeafEffectiveStatement has two specializations, storing argument in an explicit field. This statement is a CopyableNode, hence it may have an 'original' pointer – but when it does not, as is the case for EmptyLeafEffectiveStatement, the argument and declared.argument() should be pointing to the same thing. Hence we should be able to specialize a bit more.</p> <p>This is probably true of many other statements as well. Audit all statements bearing a QName argument.</p> YANGTOOLS-1316

Re-examine argument storage in effective statements

Improvement Medium Resolved Done Robert Varga Robert Varga pt Thu, 2 Sep 2021 10:42:12 +0000 Wed, 8 Dec 2021 11:19:44 +0000 Wed, 8 Dec 2021 11:19:44 +0000 8.0.0 parser 0 1 <p>We need to have ditched SchemaNode.getPath() to allow this optimization.</p> <p>Current JOL output:</p> <p> </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>***** 32-bit VM: ********************************************************** org.opendaylight.yangtools.yang.model.ri.stmt.impl.eff.EmptyLeafEffectiveStatement object internals: OFFSET  SIZE                                                               TYPE DESCRIPTION                                    VALUE      0     8                                                                    (object header)                                N/A      8     4   org.opendaylight.yangtools.yang.model.api.meta.DeclaredStatement Default.declared                               N/A     12     4                                                                int AbstractLeafEffectiveStatement.flags           N/A     16     4                                                   java.lang.Object AbstractLeafEffectiveStatement.substatements   N/A     20     4                       org.opendaylight.yangtools.yang.common.QName AbstractLeafEffectiveStatement.argument        N/A     24     4           org.opendaylight.yangtools.yang.model.api.TypeDefinition AbstractLeafEffectiveStatement.type            N/A     28     4                                                                    (loss due to the next object alignment) Instance size: 32 bytes Space losses: 0 bytes internal + 4 bytes external = 4 bytes total ***** 64-bit VM: ********************************************************** org.opendaylight.yangtools.yang.model.ri.stmt.impl.eff.EmptyLeafEffectiveStatement object internals: OFFSET  SIZE                                                               TYPE DESCRIPTION                                    VALUE      0    16                                                                    (object header)                                N/A     16     8   org.opendaylight.yangtools.yang.model.api.meta.DeclaredStatement Default.declared                               N/A     24     4                                                                int AbstractLeafEffectiveStatement.flags           N/A     28     4                                                                    (alignment/padding gap)                             32     8                                                   java.lang.Object AbstractLeafEffectiveStatement.substatements   N/A     40     8                       org.opendaylight.yangtools.yang.common.QName AbstractLeafEffectiveStatement.argument        N/A     48     8           org.opendaylight.yangtools.yang.model.api.TypeDefinition AbstractLeafEffectiveStatement.type            N/A Instance size: 56 bytes Space losses: 4 bytes internal + 0 bytes external = 4 bytes total </pre> </div></div> <p>Reusing argument would save 8 bytes (25% and 14%), but would not change the picture with compressed references. In terms of the Junos test case this means saving 400KiB.</p> <p> </p> <p> </p> Blocks YANGTOOLS-1066 Issue split YANGTOOLS-1375 Relates YANGTOOLS-1377 Development Epic Link YANGTOOLS-652 Rank 0|i03zan: