https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-1384 yangtools <p>ModelStatement.statementSource() is a confusing contract, as it allows for DeclaredStatements which are not StatementOrigin.DECLARATION. A DeclaredStatement is by definition declared, so this does not quite make sense.</p> <p>Based on historical record, the interface design comes from 2015 (Java 7). In Java 8 world, though, and thus have a consistent way of saying that:</p> <ul> <li>DeclaredStatement is always StatementOrigin.DECLARATION</li> <li>EffectiveStatement is either one of the possibilities based on getDeclared() being null (or not)</li> </ul> <p>Remove all ModelStatement.statementSource() implementations in favor of default implementations in DeclaredStatement and EffectiveStatement.</p> YANGTOOLS-1384

Remove ModelStatement.statementSource()

Sub-task YANGTOOLS-1372 High Resolved Done Robert Varga Robert Varga Mon, 13 Dec 2021 23:55:06 +0000 Wed, 15 Dec 2021 14:40:25 +0000 Tue, 14 Dec 2021 01:52:17 +0000 8.0.0 model-api model-ri parser 0 1 <p>As it turns out, once we implement <a href="https://jira.opendaylight.org/browse/YANGTOOLS-1372" title="Add support for purely-effective substatements" class="issue-link" data-issue-key="YANGTOOLS-1372"><del>YANGTOOLS-1372</del></a>, this method is only useful for EffectiveStatements. Hence we will be moving it there.</p> Development Rank 0|i04133: