https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-1468 yangtools <p>JsonParserStream is not able to read augmented container data.</p> <p>Here is the log:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>java.lang.IllegalStateException: Schema node with name container-aug was not found under (test-ns-aug)container-aug.    at org.opendaylight.yangtools.yang.data.codec.gson/org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.resolveNamespace(JsonParserStream.java:410)     at org.opendaylight.yangtools.yang.data.codec.gson/org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.read(JsonParserStream.java:308)     at org.opendaylight.yangtools.yang.data.codec.gson/org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.parse(JsonParserStream.java:193)     at org.opendaylight.yangtools.yang.data.codec.gson/org.opendaylight.yangtools.yang.data.codec.gson.YT1468JsonTest.fromJSON(YT1468JsonTest.java:70)     at org.opendaylight.yangtools.yang.data.codec.gson/org.opendaylight.yangtools.yang.data.codec.gson.YT1468JsonTest.testReadAugmentedContainer(YT1468JsonTest.java:59)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.base/java.lang.reflect.Method.invoke(Method.java:568)     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)     at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)     at org.junit.runners.ParentRunner.run(ParentRunner.java:413)     at org.junit.runner.JUnitCore.run(JUnitCore.java:137)     at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)     at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)     at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)     at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)     at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)     at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54) </pre> </div></div> <p>Please see a reproducer in <a href="https://git.opendaylight.org/gerrit/c/yangtools/+/103307" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/yangtools/+/103307</a>.</p> YANGTOOLS-1468

JsonParserStream cannot read augmentations

Bug Medium Resolved Won't Do Ruslan Kashapov Ivan Hrasko pt Tue, 22 Nov 2022 13:38:16 +0000 Wed, 15 Mar 2023 09:27:03 +0000 Wed, 15 Mar 2023 09:18:44 +0000 codecs 0 2 <p>there is no issues parsing augmented nodes, see <a href="https://git.opendaylight.org/gerrit/c/yangtools/+/104237" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/yangtools/+/104237</a></p> <p>so called <ins>parentNode</ins> parameter used to define non-root element to parse has a different meanings for XML and JSON parsers</p> <ul> <li>in XML parser <ins>parentNode</ins> points to <b>root xml element</b>, so returned node identifier matches it <b>exactly</b> the one of <ins>parentNode</ins></li> <li>in JSON parser <ins>parentNode</ins> indicates parsing <b>context</b> (belongings of top level parenthesis), and returned node is a recognized <b>direct child</b> of <ins>parentNode</ins></li> </ul> <p>this difference is historical and assumes significant code base which relies on behavior explained above</p> <p>for augmentation case the augmentation itself became a standalone (structural, non-data) node within hierarchy of parsed node structure:<br/> <tt>container-root &gt; container-lvl1 &gt; augmentation &gt; container-aug &gt; leaf-aug</tt></p> <p>according to behavior explained above same</p> <p><ins>parentNode</ins> -&gt; <b>container-aug</b> means (to parse and return) <b>container-aug</b> for XML parser and <b>leaf-aug</b> for JSON parser<br/> <ins>parentNode</ins> -&gt; <b>container-lvl1</b> means <b>container-lvl1</b> for XML parser and <b>augmentation</b> node for JSON parser </p> <p>due to <ins>parentNode</ins> cannot be pointed to <b>augmentation</b> node JSON parser cannot return <b>container-aug</b> as direct child</p> <p>due to JSON parser cannot define exact node to parse, it's not reasonable to expect exact node to be returned by parser.</p> <p> </p> <p>next action (to confirm)</p> <ul class="alternate" type="square"> <li>close as not a bug</li> <li>normalize behavior: same meaning of parentNode for both parsers (significant effort and impact expected)</li> <li>add a workaround to never return augmentation node as top level node on parsing (seems unjustified)</li> </ul> <p>Original tests in <a href="https://git.opendaylight.org/gerrit/c/yangtools/+/103307" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/yangtools/+/103307</a> contain additional check that the returned data is a container.</p> <ul> <li>Even if you use parent node as parameter in JSON you read augmentation - but we would like to get container.</li> <li>Different node/parent node parameters should be documented.</li> </ul> <p>In addition, it looks like a new bug is there - we cannot read leaf value from XML: <a href="https://git.opendaylight.org/gerrit/c/yangtools/+/104237/1..2" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/yangtools/+/104237/1..2</a></p> <p>The problems will be addressed in <a href="https://jira.opendaylight.org/browse/YANGTOOLS-1415" title="Deal with leading YangInstanceIdentifier fragment" class="issue-link" data-issue-key="YANGTOOLS-1415">YANGTOOLS-1415</a>.</p> Blocks NETCONF-911 Development Rank 0|i043hr: