https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-1521 yangtools <p>The following artifacts contain references to JUnit4:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>codec/yang-data-codec-binfmt codec/yang-data-codec-gson codec/yang-data-codec-xml common/util data/yang-data-impl data/yang-data-tree-ri data/yang-data-tree-spi parser/odlext-parser-support parser/rfc6241-parser-support parser/rfc6536-parser-support parser/rfc6643-parser-support parser/rfc7952-parser-support parser/rfc8040-parser-support parser/rfc8528-parser-support parser/rfc8639-parser-support parser/yang-parser-impl parser/yang-parser-spi plugin/yang-maven-plugin-it yang/yang-repo-spi </pre> </div></div> <p>Migrate them to JUnit5. This includes cleaning up things like assertThat(instanceOf()), assertTrue(foo instanceof x) to use assertInstanceOf(), etc.</p> YANGTOOLS-1521

Migrate to JUnit5

Task Medium Resolved Done Robert Varga Robert Varga pt Tue, 4 Jul 2023 11:07:04 +0000 Wed, 18 Oct 2023 16:32:58 +0000 Wed, 18 Oct 2023 16:32:58 +0000 12.0.0 0 2 <p>This is the plugin setup I was using for the refactoring, letting it live here for future references.</p> <p>    &lt;build&gt;<br/>         &lt;plugins&gt;<br/>             &lt;plugin&gt;<br/>                 &lt;groupId&gt;org.openrewrite.maven&lt;/groupId&gt;<br/>                 &lt;artifactId&gt;rewrite-maven-plugin&lt;/artifactId&gt;<br/>                 &lt;version&gt;5.2.6&lt;/version&gt;<br/>                 &lt;configuration&gt;<br/>                     &lt;activeRecipes&gt;<br/>                         &lt;recipe&gt;org.openrewrite.java.testing.hamcrest.HamcrestMatcherToJUnit5&lt;/recipe&gt; &lt;!-- my new recipe --&gt;<br/>                         &lt;recipe&gt;org.openrewrite.java.testing.hamcrest.AssertThatBooleanToJUnit5&lt;/recipe&gt; &lt;!-- my new recipe --&gt;<br/>                         &lt;recipe&gt;org.openrewrite.java.testing.junit5.MigrateJUnitTestCase&lt;/recipe&gt;<br/>                         &lt;recipe&gt;org.openrewrite.java.testing.junit5.AssertToAssertions&lt;/recipe&gt;<br/>                         &lt;recipe&gt;org.openrewrite.java.testing.junit5.UpdateTestAnnotation&lt;/recipe&gt;<br/>                         &lt;recipe&gt;org.openrewrite.java.testing.junit5.UpdateBeforeAfterAnnotations&lt;/recipe&gt;<br/>                         &lt;recipe&gt;org.openrewrite.java.testing.junit5.RemoveObsoleteRunners&lt;/recipe&gt;<br/>                         &lt;recipe&gt;org.openrewrite.java.testing.junit5.RunnerToExtension&lt;/recipe&gt;<br/>                         &lt;recipe&gt;org.openrewrite.java.testing.junit5.AssertTrueInstanceofToAssertInstanceOf&lt;/recipe&gt; &lt;!-- my new recipe, merged meanwhile--&gt;<br/>                     &lt;/activeRecipes&gt;<br/>                 &lt;/configuration&gt;<br/>                 &lt;dependencies&gt;   &lt;!-- This part is necessary, as we need to use local maven repo when working with custom forked openrewrite project --&gt;<br/>                     &lt;dependency&gt;<br/>                         &lt;groupId&gt;org.openrewrite.recipe&lt;/groupId&gt;<br/>                         &lt;artifactId&gt;rewrite-testing-frameworks&lt;/artifactId&gt;<br/>                         &lt;version&gt;0.1.0-SNAPSHOT&lt;/version&gt; &lt;!-- version yielded by ./gradlew publishToMavenLocal --&gt;<br/>                     &lt;/dependency&gt;<br/>                 &lt;/dependencies&gt;<br/>             &lt;/plugin&gt;<br/>         &lt;/plugins&gt;<br/>     &lt;/build&gt;</p> <p> </p> <p>I did not use org.openrewrite.java.testing.junit5.JUnit5BestPracticesRecipe nor JUnit4to5Migration as it produced an invalid code with a ton of checkstyle errors.<br/> With having this plugin setup in module's pom.xml, we can simply run `mvn rewrite:run`, which will trigger the refactoring process.</p> <p>In case anyone will continue with this, the aforementioned recipes have not been merged yet, so here is the pull request containing them:<br/> <a href="https://github.com/openrewrite/rewrite-testing-frameworks/pull/343" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/openrewrite/rewrite-testing-frameworks/pull/343</a></p> Development Rank 0|i045mf: