[YANGTOOLS-1543] XmlStringInstanceIdentifierCodec is using JSON encoding for writeValue()

Blocks — Mon, 2 Oct 2023 17:05:14 +0000

This was discovered downstream. As it turns out we have two codecs, XmlStringInstanceIdentifierCodec and RandomPrefixInstanceIdentifierSerializer.

The latter is performing correct encoding, emitting XML namespace declarations as appropriate.

The former is exposed as the official instance identifier codec, but it does the wrong thing: it uses module names instead of emitting XML namespace declarations. Related UT are asserting this, but the test cases are ambiguous: modules used for testing have the same name and prefix arguments. The assertions therefore match what we would want for our end result to be.

XmlStringInstanceIdentifierCodec does not implement the write path, so perhaps we should just unify them as a first step.

The second, separate, step is then to improve RandomPrefixInstanceIdentifierSerializer so it creates prefixes based on the module's 'prefix' statement (if that mapping refers to a unique XMLNamespace throughout th EffectiveModelContext we operate on).

OpenDaylight JIRA

[YANGTOOLS-1543] XmlStringInstanceIdentifierCodec is using JSON encoding for writeValue()