https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-200 yangtools <p>org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.IpAddress</p> <p>public IpAddress(Ipv4Address _ipv4Address) </p> { super(); this._ipv4Address = _ipv4Address; this._ipv6Address = null; this._value = null; } <p>This constructor is possibly wrong because it returns null on getValue(). If the instance is created using this constructor it cannot be sent over JMX.</p> <p>Consider this example:<br/> client.setAddress(new IpAddress(new Ipv4Address("127.0.0.1")));<br/> will fail<br/> client.setAddress(new IpAddress("127.0.0.1".toCharArray()));<br/> will succeed (value != null)</p> <p>Proposed fix: _value should be filled using _ipv4Address.getValue()</p> <p>Detail:</p> <p>The failure looks like this:<br/> Caused by: java.io.InvalidObjectException: Exception constructing org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.IpAddress<br/> at com.sun.jmx.mbeanserver.DefaultMXBeanMappingFactory.invalidObjectException(DefaultMXBeanMappingFactory.java:1415)<br/> at com.sun.jmx.mbeanserver.DefaultMXBeanMappingFactory$CompositeBuilderViaConstructor.fromCompositeData(DefaultMXBeanMappingFactory.java:1335)<br/> at com.sun.jmx.mbeanserver.DefaultMXBeanMappingFactory$CompositeMapping.fromNonNullOpenValue(DefaultMXBeanMappingFactory.java:918)<br/> at com.sun.jmx.mbeanserver.DefaultMXBeanMappingFactory$NonNullMXBeanMapping.fromOpenValue(DefaultMXBeanMappingFactory.java:132)<br/> at com.sun.jmx.mbeanserver.DefaultMXBeanMappingFactory$CompositeBuilderViaSetters.fromCompositeData(DefaultMXBeanMappingFactory.java:1119)<br/> ... 48 more<br/> Caused by: java.lang.reflect.InvocationTargetException<br/> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)<br/> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)<br/> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)<br/> at java.lang.reflect.Constructor.newInstance(Constructor.java:526)<br/> at com.sun.jmx.mbeanserver.DefaultMXBeanMappingFactory$CompositeBuilderViaConstructor.fromCompositeData(DefaultMXBeanMappingFactory.java:1331)<br/> ... 51 more<br/> Caused by: java.lang.NullPointerException<br/> at java.lang.String.&lt;init&gt;(String.java:168)<br/> at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.IpAddress.&lt;init&gt;(IpAddress.java:38)<br/> ... 56 more</p> <p>Operating System: All<br/> Platform: All</p> YANGTOOLS-200

code generator should not generate this.value = null

Bug Resolved Done Martin Vitez Tomas Olvecky Wed, 2 Jul 2014 09:01:39 +0000 Sun, 10 Apr 2022 18:35:09 +0000 Mon, 21 Jul 2014 08:15:34 +0000 Fri, 18 Jul 2014 00:00:00 +0000 0 5 <p>In addition, value field is compared in equals method. Equal result depends on which constructor was used for union type. Basic constructors set value to null and Artificial constructor sets the value to input value.</p> <p>this is a bug in code generator (not enhancement) that forces programmers to use workarounds and document them in their code base, see bgpcep, e.g.<br/> <a href="https://github.com/opendaylight/bgpcep/blob/master/bgp/rib-impl-config/src/test/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModuleTest.java#L148" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/bgpcep/blob/master/bgp/rib-impl-config/src/test/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModuleTest.java#L148</a></p> <p>Proposed patch:</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/9006/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/9006/</a></p> Development External issue ID 1276 External issue URL ODL SR Target Milestone Rank 0|i025rb: