https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-257 yangtools <p>This is a shortened example from the TTP repo.</p> <p>If you have YANG like this:</p> <p> ...<br/> list parameters {<br/> ...<br/> leaf default {<br/> type union </p> { type string; type uint32; } <p> }<br/> ...<br/> }<br/> ...</p> <p>The DefaultBuilder.java winds up being stored in src/main/java instead of the configured directory.</p> <p>The same thing happens with PortNumberBuilder.java in controller. Which is generated to opendaylight/md-sal/model/model-flow-base/src/main/java/org/opendaylight/yang/gen/v1/urn/opendaylight/flow/types/port/rev130925/PortNumberBuilder.java</p> <p>While it's counterparts are generated to opendaylight/md-sal/model/model-flow-base/src/main/yang-gen-sal/org/opendaylight/yang/gen/v1/urn/opendaylight/...</p> <p>Operating System: Mac OS<br/> Platform: PC</p> YANGTOOLS-257

generated builder java file for a leaf containing a union needs documentation for why it's stored in src/main/java

Bug Resolved Done Ladislav Borak Colin Dixon Sat, 9 Aug 2014 18:55:53 +0000 Sun, 10 Apr 2022 18:35:14 +0000 Tue, 14 Oct 2014 09:36:09 +0000 0 3 <p>After talking to Devin Avery and Tom Pantelis, I think that this isn't a bug in that it's placed in the wrong location, but rather a bug in that the <b>reason</b> that it's placed here isn't properly conveyed.</p> <p>Ideally, this generate class's functionality would be automated, but in the meantime a comment needs to be added to explain that the person creating the model needs to add code, what that code needs to do, and what happens if they don't.</p> <p>The purpose of generated class in src/main/java for Union types is to create new instances of unions from a string representation. In some cases it is very difficult to automate it since there can be unions such as (uint32 - uint16), or (string - uint32). </p> <p>The reason behind putting it under src/main/java is:<br/> This class is generated in form of a stub and needs to be finished by the user. This class is generated only once to prevent loss of user code.</p> <p>I agree with you, that a comment should be added to such classes.</p> <p>(In reply to Maros Marsalek from comment #2)<br/> &gt; The purpose of generated class in src/main/java for Union types is to create<br/> &gt; new instances of unions from a string representation. In some cases it is<br/> &gt; very difficult to automate it since there can be unions such as (uint32 -<br/> &gt; uint16), or (string - uint32). </p> <p>The YANG spec actually says the correct thing to do here is to use the first listed type in the union for which it can be correctly interpreted.</p> <p>"When a string representing a union data type is validated, the string is validated against each member type, in the order they are specified in the "type" statement, until a match is found."</p> <p>From here: <a href="http://www.yang-central.org/twiki/pub/Main/YangDocuments/rfc6020.html#rfc.section.9.12" class="external-link" target="_blank" rel="nofollow noopener">http://www.yang-central.org/twiki/pub/Main/YangDocuments/rfc6020.html#rfc.section.9.12</a></p> <p>I <b>think</b> we should be able to do this automatically, but I may be wrong.</p> <p>proposed patch: <a href="https://git.opendaylight.org/gerrit/#/c/9952/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/9952/</a></p> <p>Please create new enhancement for your last comment.</p> Development External issue ID 1512 External issue URL ODL SR Target Milestone Rank 0|i0263z: