[YANGTOOLS-35] Inconsistent constructor argument ordering

Sun, 10 Apr 2022 18:34:53 +0000

TablesKey, which is a list key, has its constructor arguments ordered differently on my machine and on jenkins.

My:
public TablesKey(Class<? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.AddressFamily> _Afi, Class<? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.SubsequentAddressFamily> _Safi) {

Jenkins:
public TablesKey(Class<? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.SubsequentAddressFamily> _Safi, Class<? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.AddressFamily> _Afi) {

which causes verification to fail with:
[ERROR] /opt/jenkins-bgpcep/workspace/bgpcep-verify/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPPeer.java:[55,36] no suitable constructor found for TablesKey(java.lang.Class<capture#1 of ? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.AddressFamily>,java.lang.Class<capture#2 of ? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.SubsequentAddressFamily>)
constructor org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.rib.TablesKey.TablesKey(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.rib.TablesKey) is not applicable
(actual and formal argument lists differ in length)
constructor org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.rib.TablesKey.TablesKey(java.lang.Class<? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.SubsequentAddressFamily>,java.lang.Class<? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.AddressFamily>) is not applicable
(actual argument java.lang.Class<capture#1 of ? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.AddressFamily> cannot be converted to java.lang.Class<? extends org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.SubsequentAddressFamily> by method invocation conversion)

The reason for this seems to be reliance on HashMaps, whose ordering is indeterminate. Please make sure to alpha-sort arguments before emitting them.

OpenDaylight JIRA

[YANGTOOLS-35] Inconsistent constructor argument ordering