https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-417 yangtools <p><a href="https://gist.github.com/2da83d35b8c8b11c3822" class="external-link" target="_blank" rel="nofollow noopener">https://gist.github.com/2da83d35b8c8b11c3822</a></p> <p>This worked fine Tue 5:30am when I built. Now we are hosed again.</p> <p>It's very very hard not to rant when we change nothing, and either REST doesn't work for 2 days, or when it starts to work again, it breaks something else.</p> <p>We are blocked.</p> <p>Operating System: All<br/> Platform: All</p> YANGTOOLS-417

JSON PUT for list item does not work correctly

Bug Resolved Done Tony Tkacik Keith Burns Thu, 12 Mar 2015 04:07:53 +0000 Sun, 10 Apr 2022 18:35:29 +0000 Mon, 16 Mar 2015 12:23:45 +0000 0 3 <p>The PUT to tenant has worked this way since:</p> <p>commit 304445a4343a67e68fd6111edba6cba8cbaf7ac3<br/> Author: Thomas Bachman &lt;tbachman@yahoo.com&gt;<br/> Date: Mon Jan 19 17:03:23 2015 -0800</p> <p> Fixed overwrite of tenant policy.</p> <p> The existing script would overwrite any policy from tenant<br/> and below, because of the URL used. This patch only adds<br/> to the tenant list, instead of overwriting the whole thing.</p> <p> Change-Id: Ia077b45a883fdd2d11cdd5775c28da6da7fb1a97<br/> Signed-off-by: Thomas Bachman &lt;tbachman@yahoo.com&gt;</p> <p>I have reproduced this error by:</p> <p>cd groupbasedpolicy/<br/> mvn clean install<br/> cd distribution-karaf/target/assembly/bin<br/> ./karaf</p> <p>Then using this postman:</p> <p><a href="https://www.getpostman.com/collections/d641d67f578c0abbf3d8" class="external-link" target="_blank" rel="nofollow noopener">https://www.getpostman.com/collections/d641d67f578c0abbf3d8</a></p> <p>Doing 'Inventory PUT' (which works) followed by 'Policy PUT' (which gives the error Keith saw).</p> <p>Note: When I try to use API-docs... API-docs thinks we have the policy model, and even shows the relavent things to GET and PUT... but they are breaking because the schema is missing.</p> <p>JSON PUT does not work correctly after fixing POST for list items,</p> <p>this bug has also its variation in <a href="https://jenkins.opendaylight.org/releng/view/CSIT-Jobs/job/openflowplugin-csit-1node-imds-flow-services-all-master/14/robot/report/log.html#s1-s4-s2-t3" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/releng/view/CSIT-Jobs/job/openflowplugin-csit-1node-imds-flow-services-all-master/14/robot/report/log.html#s1-s4-s2-t3</a></p> <p>Workaround is to wrap policy:tenant object in array as it is.</p> <p>{<br/> "policy:tenant": [{</p> <p> }]<br/> }</p> <p>Seems yang-data-codec-gson does not handle parsing of one list item properly</p> <ul class="alternate" type="square"> <li>it handles parsing of lists as specified in <a href="https://tools.ietf.org/html/draft-lhotka-netmod-yang-json-02#page-10" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/draft-lhotka-netmod-yang-json-02#page-10</a>,</li> </ul> <p>3.2.4. The "list" Data Node</p> <p> A sequence of one or more sibling XML elements with the same<br/> qualified name that is modeled as YANG list is translated to a name/<br/> array pair, and the array elements are JSON objects.</p> <p>but implemented restconf draft provides examples for lists (which bit changes serialization of list):</p> <p><a href="https://tools.ietf.org/html/draft-bierman-netconf-restconf-02#page-37" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/draft-bierman-netconf-restconf-02#page-37</a></p> <p>Example from biermann</p> <p> PUT /restconf/config/example-jukebox:jukebox/<br/> library/artist/Foo%20Fighters/album/Wasting%20Light HTTP/1.1<br/> Host: example.com<br/> If-Match: b3830f23a4c<br/> Content-Type: application/yang.data+json</p> <p> {<br/> "example-jukebox:album" : </p> { "name" : "Wasting Light", "genre" : "example-jukebox:alternative", "year" : 2011 } <p> }</p> <p>But by referenced YANG-JSON specification it should be <br/> {<br/> "example-jukebox:album" : [</p> { "name" : "Wasting Light", "genre" : "example-jukebox:alternative", "year" : 2011 } <p>]<br/> }</p> <p>Seems this unclarity between specifications is still present in latest drafts:</p> <p><a href="https://tools.ietf.org/html/draft-ietf-netconf-restconf-04" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/draft-ietf-netconf-restconf-04</a><br/> <a href="https://tools.ietf.org/html/draft-ietf-netmod-yang-json-03#section-5.4" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/draft-ietf-netmod-yang-json-03#section-5.4</a></p> <p>Where RESTCONF draft showcases reading list item returning<br/> { list: [{</p> <p> }]<br/> }</p> <p>but PUT showcases <br/> { list : {</p> <p> }<br/> }</p> <p>YANTools - <a href="https://git.opendaylight.org/gerrit/16405" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/16405</a></p> Development External issue ID 2818 External issue URL Rank 0|i0273j: