https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-450 yangtools <p>This is an example piece of code from openflowplugin tests.</p> <p>ActionSetNwSrcReactorTest.java:45</p> <p> new Ipv6Builder().setIpv6Address(new Ipv6Prefix("1234:5678:9abc:def1:2345:6789:abcd:ef12")).build(),</p> <p>This passes a prefix without a /X to the Ipv6Prefix constructor. </p> <p>This should not work. But it does - test passes in stock openflowplugin from helium.</p> <p>Operating System: All<br/> Platform: All</p> YANGTOOLS-450

v6 prefix checking broken

Bug Resolved Done Tony Tkacik Anton Ivanov Thu, 23 Apr 2015 09:09:52 +0000 Sun, 10 Apr 2022 18:35:32 +0000 Mon, 8 Jun 2015 13:27:14 +0000 0 5 <p>remote: <a href="https://git.opendaylight.org/gerrit/18922" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/18922</a></p> <p>Exec summary: I have no clue what is going on here.</p> <p>The java code generated by yangtools looks correct. However it accepts input which should definitely fail (as in the openflow example).</p> <p>The regexps are correct. If I cut-n-paste them into the following perl snippet they work:</p> <p>#!/usr/bin/perl</p> <p>@z = ("^((:|<span class="error">&#91;0-9a-fA-F&#93;</span></p> {0,4})<img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/>(<span class="error">&#91;0-9a-fA-F&#93;</span>{0,4} <p><img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> {0,5} <p>(((<span class="error">&#91;0-9a-fA-F&#93;</span></p> {0,4}<img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/>?(:|<span class="error">&#91;0-9a-fA-F&#93;</span>{0,4} <p>))|(((25<span class="error">&#91;0-5&#93;</span>|2<span class="error">&#91;0-4&#93;</span><span class="error">&#91;0-9&#93;</span>|<span class="error">&#91;01&#93;</span>?<span class="error">&#91;0-9&#93;</span>?<span class="error">&#91;0-9&#93;</span>)<br class="atl-forced-newline" />.)</p> {3} <p>(25<span class="error">&#91;0-5&#93;</span>|2<span class="error">&#91;0-4&#93;</span><span class="error">&#91;0-9&#93;</span>|<span class="error">&#91;01&#93;</span>?<span class="error">&#91;0-9&#93;</span>?<span class="error">&#91;0-9&#93;</span>)))(/((<span class="error">&#91;0-9&#93;</span>)|(<span class="error">&#91;0-9&#93;</span></p> {2} <p>)|(1<span class="error">&#91;0-1&#93;</span><span class="error">&#91;0-9&#93;</span>)|(12<span class="error">&#91;0-8&#93;</span>)))\$", "^((<span class="error">&#91;^:&#93;</span>+<img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> {6} <p>((<span class="error">&#91;^:&#93;</span><ins>:<span class="error">&#91;^:&#93;</span></ins>)|(.<b><br class="atl-forced-newline" />..</b>)))|(((<span class="error">&#91;^:&#93;</span><ins><img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/><b><span class="error">&#91;^:&#93;</span></ins>)?:<img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/>(<span class="error">&#91;^:&#93;</span><ins><img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></b><span class="error">&#91;^:&#93;</span></ins>)?)(/.+)\$");</p> <p>while ($a = &lt;STDIN&gt;) {<br/> chomp($a);<br/> foreach $regexp (@z) {<br/> if ($a =~ /$regexp/) </p> { print "OK for $regexp\n"; } <p> else </p> { print "NOK for $regexp\n"; } <p> }<br/> }</p> <p>Unless there is something in the yang generated code which I have missed, this looks like a bug in the underlying regexp library.</p> <p>Awaiting down stream projects to update their code.<br/> To remain open until new IPv6Builder() is used.</p> <p>Projects Still failing:<br/> Openflow<br/> OVSDB<br/> GBP</p> <p>Hi Carol,</p> <p>What exactly are the changes that down stream project need to do?</p> <p>Thanks<br/> Anil</p> <p>Anil, you need to replace any instantiation of IpvXPrefix (mostly found in Matchers) which is being done without a netmask with a correct argument - with netmask.</p> <p>The easiest way is utility class with multiple createPrefix() methods:</p> <p>Ipv6Prefix createPrefix(string);<br/> Ipv6Prefix createPrefix(string, integer);</p> <p>Ipv6Prefix createPrefix(Ipv6Address);<br/> Ipv6Prefix createPrefix(Ipv6Address, integer);</p> <p>Ipv4Prefix createPrefix(string);<br/> Ipv4Prefix createPrefix(string, integer);</p> <p>Ipv4Prefix createPrefix(Ipv4Address);<br/> Ipv4Prefix createPrefix(Ipv4Address, integer);</p> <p>You just drop that in instead of the direct new IpvXPrefix() instantiation across the board. It will take whatever argument you are feeding it and consume it.</p> <p>I ended up adding temprorarily (string, string) for openflowplugin, but IMHO that is temporary, the mask has no need of being a string in a network application. Ever. </p> <p>The easiest way to get that done would have been to override the yangtools generation if we had that facility. As we do not have it, you have to do it manually.</p> Blocks GBP-33 Development External issue ID 3051 External issue URL Issue Type ODL SR Target Milestone Rank 0|i027av: