[YANGTOOLS-454] Differentiate YangInstanceIdentifier

Sun, 10 Apr 2022 18:35:32 +0000

YangInstanceIdentifier has inherently two ways of construction: a fixed iterable from root, or concatenation. Current implementation is geared towards the later use case, where it takes advantage of Iterables.concat().

This has an unfortunate side-effect of not being able to efficiently implement getLastPathArgument(), which is used in binding codecs and will be used heavily in defensive precautions solving BUG-3189.

Rework the implementation such that the two cases are differentiated, one using an internal ImmutableList, the other one keeping a reference to the YangInstanceIdentifier from which it was created (and storing a single PathArgument).

This will have the effect of the fixed implementation improving on various operations, as well as the stacked implementation having lower overhead and being efficient in providing the last path argument.

OpenDaylight JIRA

[YANGTOOLS-454] Differentiate YangInstanceIdentifier