OpenDaylight JIRA

OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us

8.20.10

820010

22-06-2022

[YANGTOOLS-603] Yang parser overwrites all multiple substatements with equal argument by the last one https://jira.opendaylight.org/browse/YANGTOOLS-603 yangtools <p>StatementContextBase.substatementBuilder(line 324) overwrites all multiple substatements with equal argument by the last one.</p> <p>Operating System: All<br/> Platform: All</p> YANGTOOLS-603

Yang parser overwrites all multiple substatements with equal argument by the last one

Bug Resolved Done Robert Varga Peter Kajsa Wed, 13 Apr 2016 09:30:49 +0000 Sun, 10 Apr 2022 18:35:46 +0000 Fri, 18 Nov 2016 10:18:37 +0000 0 3 <p>(In reply to Peter Kajsa from comment #0)<br/> > StatementContextBase.substatementBuilder(line 324) overwrites all multiple<br/> > substatements with equal argument by the last one.</p> <p>Hi,<br/> I am planning to work on this bug, could you please provide me more info.</p> <p>Hi,</p> <p>if a statement contains multiple substatements which have equal arguments, the previous are overwritten by the last one.</p> <p>For an example, see bug <a href="https://bugs.opendaylight.org/show_bug.cgi?id=5396" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=5396</a> <br/> where in<br/> typedef my-type {<br/> type union {<br/> type string </p> { pattern "dp[0-9]+o[0-9]+"; } <p> type string </p> { pattern "dp[0-9]+s[0-9]+(f[0-9]+)?(d[0-9]+)?"; } <p> type string {<br/> pattern "dp<span class="error">[0-9]</span><ins>(P<span class="error">[0-9]</span></ins>)?p<span class="error">[0-9]</span></p> {1,3}s<span class="error">[0-9]</span>{1,3} <p>(f<span class="error">[0-9]</span><ins>)?(d<span class="error">[0-9]</span></ins>)?";<br/> }<br/> type string </p> { pattern "dp[0-9]+p[0-9]+p[0-9]+"; }<br/> }<br/> }<br/> <br/> the previous "type string" statements are overwritten by the last one:<br/> type string { pattern "dp[0-9]+p[0-9]+p[0-9]+"; } <p>The same issue occurs also by multiple augment, refine, deviation,..?? statements.</p> <p>These issues have been fixed by some hotfixes recently, but the root cause of the issue still persists. It is necessary to fix StatementContextBase.substatementBuilder in order to handle potential substatements in another way (for an example: track also the order of substatements and then check substatetement name, argument and also the substatement order).</p> <p>This boils down to statements being in two classes:</p> <ul class="alternate" type="square"> <li>attribute statements, which just add attributes to their enclosing entity</li> <li>entity statements, which define an entity</li> </ul> <p>The first type does not need an identifier, the second one does.</p> <p>First step: eliminate substatement(), as it does not need to be visible: <a href="https://git.opendaylight.org/gerrit/48205" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/48205</a></p> <p>second step: use an integer to identify statements: <a href="https://git.opendaylight.org/gerrit/48241" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/48241</a></p> Blocks YANGTOOLS-628 YANGTOOLS-715 Development External issue ID 5717 External issue URL Issue Type ODL SR Target Milestone Rank 0|i0288v: