https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-631 yangtools <p><a href="https://tools.ietf.org/html/rfc6020#section-6.1.3" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/rfc6020#section-6.1.3</a><br/> If a string is enclosed in double-quotes, and the string itself contains a double-quote character, the character should be written as this: \"</p> <p>But ODL currently seems to misinterpret that, possibly as a single backslash.<br/> Example model to follow shortly.</p> <p>Operating System: All<br/> Platform: All</p> YANGTOOLS-631

Parser: Backslash double-quote in double-quoted string not recognized

Bug Resolved Done Peter Kajsa Vratko Polak Mon, 11 Jul 2016 10:53:15 +0000 Sun, 10 Apr 2022 18:35:48 +0000 Mon, 26 Sep 2016 17:01:23 +0000 0 2 <p>&gt; Example model to follow shortly.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/41645/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/41645/1</a></p> <p>It shows two symptoms. Warning with TransformerException from usage in "when" statement, and wrong pattern compilation for restricted string type. Neither fault makes the build fail.<br/> There is also a "good" model, showing the symptoms do not happen when single-quoted strings are used.</p> <p>The pattern:<br/> Good '".<b>"' gets compiled from Yang into Java as "^\".</b>\"$", which is correct.<br/> But "\".<b>\"" gets compiled as "^\\.</b><br class="atl-forced-newline" />$", which is incorrect.</p> <p>The "when" statement:<br/> Good '/foo != "bar"' is accepted.<br/> But "/foo != \"bar\"" leads to this long stacktrace:</p> <p><span class="error">&#91;WARNING&#93;</span> Argument "/foo != \bar\" is not valid XPath string at "META-INF/yang/bug6180.yang:17:4"<br/> javax.xml.transform.TransformerException: A location path was expected, but the following token was enc<br/> ountered: \<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.error(XPathParser.java:612)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.LocationPath(XPathParser.java:1603)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.PathExpr(XPathParser.java:1319)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.UnionExpr(XPathParser.java:1238)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.UnaryExpr(XPathParser.java:1144)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.MultiplicativeExpr(XPathParser.java:1<br/> 065)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.AdditiveExpr(XPathParser.java:1007)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.RelationalExpr(XPathParser.java:932)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.EqualityExpr(XPathParser.java:872)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.EqualityExpr(XPathParser.java:884)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.AndExpr(XPathParser.java:836)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.OrExpr(XPathParser.java:809)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.Expr(XPathParser.java:792)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.initXPath(XPathParser.java:131)<br/> at com.sun.org.apache.xpath.internal.XPath.&lt;init&gt;(XPath.java:180)<br/> at com.sun.org.apache.xpath.internal.XPath.&lt;init&gt;(XPath.java:268)<br/> at com.sun.org.apache.xpath.internal.jaxp.XPathImpl.compile(XPathImpl.java:392)<br/> at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.Utils.parseXPath(Utils.java:369)<br/> at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.WhenStatementImpl$Definition.parseArgume<br/> ntValue(WhenStatementImpl.java:44)<br/> at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.WhenStatementImpl$Definition.parseArgume<br/> ntValue(WhenStatementImpl.java:35)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementDefinitionContext.parseArgument<br/> Value(StatementDefinitionContext.java:34)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.SubstatementContext.&lt;init&gt;(SubstatementC<br/> ontext.java:49)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextBase$1.build(StatementCo<br/> ntextBase.java:327)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextWriter.defferedCreate(St<br/> atementContextWriter.java:45)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextWriter.endStatement(Stat<br/> ementContextWriter.java:52)<br/> at org.opendaylight.yangtools.yang.parser.impl.YangStatementParserListenerImpl.exitStatement(Ya<br/> ngStatementParserListenerImpl.java:105)<br/> at org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser$StatementContext.exitRule(Ya<br/> ngStatementParser.java:117)<br/> at org.antlr.v4.runtime.tree.ParseTreeWalker.exitRule(ParseTreeWalker.java:71)<br/> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:54)<br/> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)<br/> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)<br/> at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.YangStatementSourceImpl.writeFull(YangSt<br/> atementSourceImpl.java:98)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.SourceSpecificContext.loadStatements(Sou<br/> rceSpecificContext.java:329)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.loadPhaseStatements(B<br/> uildGlobalContext.java:228)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.buildEffective(BuildG<br/> lobalContext.java:196)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction.<br/> buildEffective(CrossSourceStatementReactor.java:134)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction.<br/> buildEffective(CrossSourceStatementReactor.java:151)<br/> at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.processYang(YangToSour<br/> cesProcessor.java:177)<br/> at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.execute(YangToSourcesProcessor.java:93)<br/> at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.conditionalExecute(YangToSourcesProcessor.java:104)<br/> at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesMojo.execute(YangToSourcesMojo.java:119)<br/> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)<br/> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)<br/> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)<br/> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)<br/> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)<br/> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)<br/> at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)<br/> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)<br/> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)<br/> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)<br/> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)<br/> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)<br/> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)<br/> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)<br/> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<br/> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)<br/> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<br/> at java.lang.reflect.Method.invoke(Method.java:498)<br/> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)<br/> at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)<br/> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)<br/> at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)<br/> --------------- linked to ------------------<br/> javax.xml.xpath.XPathExpressionException: javax.xml.transform.TransformerException: A location path was expected, but the following token was encountered: \<br/> at com.sun.org.apache.xpath.internal.jaxp.XPathImpl.compile(XPathImpl.java:400)<br/> at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.Utils.parseXPath(Utils.java:369)<br/> at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.WhenStatementImpl$Definition.parseArgumentValue(WhenStatementImpl.java:44)<br/> at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.WhenStatementImpl$Definition.parseArgumentValue(WhenStatementImpl.java:35)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementDefinitionContext.parseArgumentValue(StatementDefinitionContext.java:34)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.SubstatementContext.&lt;init&gt;(SubstatementContext.java:49)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextBase$1.build(StatementContextBase.java:327)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextWriter.defferedCreate(StatementContextWriter.java:45)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextWriter.endStatement(StatementContextWriter.java:52)<br/> at org.opendaylight.yangtools.yang.parser.impl.YangStatementParserListenerImpl.exitStatement(YangStatementParserListenerImpl.java:105)<br/> at org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser$StatementContext.exitRule(YangStatementParser.java:117)<br/> at org.antlr.v4.runtime.tree.ParseTreeWalker.exitRule(ParseTreeWalker.java:71)<br/> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:54)<br/> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)<br/> at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)<br/> at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.YangStatementSourceImpl.writeFull(YangStatementSourceImpl.java:98)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.SourceSpecificContext.loadStatements(SourceSpecificContext.java:329)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.loadPhaseStatements(BuildGlobalContext.java:228)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.buildEffective(BuildGlobalContext.java:196)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction.buildEffective(CrossSourceStatementReactor.java:134)<br/> at org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction.buildEffective(CrossSourceStatementReactor.java:151)<br/> at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.processYang(YangToSourcesProcessor.java:177)<br/> at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.execute(YangToSourcesProcessor.java:93)<br/> at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.conditionalExecute(YangToSourcesProcessor.java:104)<br/> at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesMojo.execute(YangToSourcesMojo.java:119)<br/> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)<br/> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)<br/> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)<br/> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)<br/> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)<br/> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)<br/> at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)<br/> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)<br/> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)<br/> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)<br/> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)<br/> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)<br/> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)<br/> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)<br/> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<br/> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)<br/> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<br/> at java.lang.reflect.Method.invoke(Method.java:498)<br/> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)<br/> at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)<br/> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)<br/> at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)<br/> Caused by: javax.xml.transform.TransformerException: A location path was expected, but the following token was encountered: \<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.error(XPathParser.java:612)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.LocationPath(XPathParser.java:1603)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.PathExpr(XPathParser.java:1319)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.UnionExpr(XPathParser.java:1238)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.UnaryExpr(XPathParser.java:1144)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.MultiplicativeExpr(XPathParser.java:1065)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.AdditiveExpr(XPathParser.java:1007)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.RelationalExpr(XPathParser.java:932)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.EqualityExpr(XPathParser.java:872)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.EqualityExpr(XPathParser.java:884)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.AndExpr(XPathParser.java:836)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.OrExpr(XPathParser.java:809)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.Expr(XPathParser.java:792)<br/> at com.sun.org.apache.xpath.internal.compiler.XPathParser.initXPath(XPathParser.java:131)<br/> at com.sun.org.apache.xpath.internal.XPath.&lt;init&gt;(XPath.java:180)<br/> at com.sun.org.apache.xpath.internal.XPath.&lt;init&gt;(XPath.java:268)<br/> at com.sun.org.apache.xpath.internal.jaxp.XPathImpl.compile(XPathImpl.java:392)<br/> ... 46 more</p> <p>fix: <a href="https://git.opendaylight.org/gerrit/#/c/41828" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/41828</a></p> <p>However, the xpath expression of 'when' statement in the test model 'foo.yang' contains escaped double quotes (\"), which must be unescaped back to double quotes (\" -&gt; ") in order to compile this expression successfully. We could do this by path.replace("\\\"", "\""), what will works fine for almost all cases, but I am not sure whether we really want to do this, because some special cases maybe would not work .. ?</p> <p>&gt; fix: <a href="https://git.opendaylight.org/gerrit/#/c/41828" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/41828</a></p> <p>Merged.</p> <p>Waiting for review: cherry-pick to Beryllium<br/> <a href="https://git.opendaylight.org/gerrit/44490" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/44490</a></p> <p>&gt; cherry-pick to Beryllium <a href="https://git.opendaylight.org/gerrit/44490" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/44490</a></p> <p>... is merged now.</p> Development External issue ID 6180 External issue URL Issue Type ODL SR Target Milestone Rank 0|i028f3: