https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-742 yangtools <p>Deserialization fails with following exception:</p> <p>Caused by: java.lang.IllegalArgumentException: Failed to construct instance of class org.opendaylight.yang.gen.v1.urn.ieee.params.xml.ns.yang.dot1q.types.rev150626.dot1q.tag.or.any.Dot1qTag$VlanId for input 2420<br/> at org.opendaylight.yangtools.binding.data.codec.impl.UnionTypeCodec.deserialize(UnionTypeCodec.java:51) ~<span class="error">&#91;mdsal-binding-dom-codec-0.9.2-Boron-SR2.jar:na&#93;</span><br/> at org.opendaylight.yangtools.binding.data.codec.impl.LeafNodeCodecContext.deserializeObject(LeafNodeCodecContext.java:199) ~<span class="error">&#91;mdsal-binding-dom-codec-0.9.2-Boron-SR2.jar:na&#93;</span><br/> at org.opendaylight.yangtools.binding.data.codec.impl.DataObjectCodecContext.getBindingChildValue(DataObjectCodecContext.java:329) ~<span class="error">&#91;mdsal-binding-dom-codec-0.9.2-Boron-SR2.jar:na&#93;</span><br/> at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.getBindingData(LazyDataObject.java:148) ~<span class="error">&#91;mdsal-binding-dom-codec-0.9.2-Boron-SR2.jar:na&#93;</span><br/> at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.bindingToString(LazyDataObject.java:205) ~<span class="error">&#91;mdsal-binding-dom-codec-0.9.2-Boron-SR2.jar:na&#93;</span><br/> at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.invoke(LazyDataObject.java:65) ~<span class="error">&#91;mdsal-binding-dom-codec-0.9.2-Boron-SR2.jar:na&#93;</span><br/> at com.sun.proxy.$Proxy117.toString(Unknown Source) ~[n</p> <p>when I do </p> <p>dot1qTag.getVlanId()</p> <p>here is yang model:<br/> <a href="https://git.fd.io/hc2vpp/tree/v3po/api/src/main/yang/dot1q-types.yang" class="external-link" target="_blank" rel="nofollow noopener">https://git.fd.io/hc2vpp/tree/v3po/api/src/main/yang/dot1q-types.yang</a></p> <p>after debugging, I found that</p> <p>EncapsulatedValueCodec.deserialize() </p> <p>fails because of</p> <p>java.lang.ClassCastException: Cannot cast java.lang.String to java.lang.Integer</p> <p>In case if I use analogous restconf request, DataObject is retrieved from cache<br/> at LazyDataObject.getBindingData and deserialization is not invoked.</p> <p>The same request works if we downgrade odl dependencies to Beryllium-SR2.</p> <p>I noticed that in case of beryllium, the generated Dot1qTagVlanIdBuilder was invoked.</p> <p>Operating System: All<br/> Platform: All</p> YANGTOOLS-742

Getter of BA object fails to construct class instance

Bug Resolved Done Robert Varga Marek Gradzki Wed, 8 Feb 2017 09:38:15 +0000 Sun, 10 Apr 2022 18:35:57 +0000 Wed, 15 Mar 2017 13:00:59 +0000 0 10 <p>Attachment netconf.txt has been added with description: netconf request</p> <p>Attachment restconf.txt has been added with description: restconf request</p> <p>Honeycomb log</p> <p><a href="https://jira.fd.io/secure/attachment/11007/full_honeycomb.zip" class="external-link" target="_blank" rel="nofollow noopener">https://jira.fd.io/secure/attachment/11007/full_honeycomb.zip</a></p> <p>Netconf request is working fine in stable/boron (except that you are missing &lt;type&gt; attribute in the rpc with id m-67).</p> <p>You are refering to SR2 or SR3 snapshot?<br/> How should valid netconf request look like?<br/> Btw, we are getting the request from ODL client - we have no control over it.</p> <p>I added &lt;type/&gt; and result is:</p> <p>&lt;rpc message-id="m-67" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"&gt;<br/> &lt;edit-config&gt;<br/> &lt;target&gt;<br/> &lt;candidate/&gt;<br/> &lt;/target&gt;<br/> &lt;config&gt;<br/> &lt;interfaces xmlns="urn:ietf:params:xml:ns:yang:ietf-interfaces"&gt;<br/> &lt;interface&gt;<br/> &lt;name&gt;GigabitEthernet0/8/0&lt;/name&gt;<br/> &lt;type/&gt;<br/> &lt;sub-interfaces xmlns="urn:opendaylight:params:xml:ns:yang:vpp:vlan"/&gt;<br/> &lt;/interface&gt;<br/> &lt;/interfaces&gt;<br/> &lt;/config&gt;<br/> &lt;/edit-config&gt;<br/> &lt;/rpc&gt;<br/> ]]&gt;]]&gt;</p> <p>Working rest request:</p> <p>PUT <a href="http://localhost:8181/restconf/config/ietf-interfaces:interfaces/interface/GigabitEthernet0%2F8%2F0" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/ietf-interfaces:interfaces/interface/GigabitEthernet0%2F8%2F0</a></p> <p>{<br/> "interface" : </p> { "name" : "GigabitEthernet0/8/0", "type" : "" } <p>}</p> <p>GigabitEthernet0/8/0 was defined in cfg before edit-cfg msg was received (perhaps this is why mandatory type attribute was not included in the series of messages).</p> <p>What we are more interesting in<br/> is the vlan-tag part (union type deserialzation).</p> <p>Have you checked boron SR2?</p> <p>Yes I have checked release/boron-sr2 release and it worked fine.</p> <p>It is possible it works for honeycomb/vbd alone. But our setup is a bit different. ODL app (honeycomb/vbd) sends netconf requests to hc2vpp. Then hc2vpp fails to deserialize vlan-id union type.</p> <p>Please look at attached logs (DEBUG). Let me know if you need additional logs or increasing log level for some components to reproduce issue.</p> <p>Ultimate solution to reproduce bug is to install and run hc2vpp <a href="https://docs.fd.io/hc2vpp/1.17.01-SNAPSHOT/release-notes-aggregator/release_notes.html#_install_guide" class="external-link" target="_blank" rel="nofollow noopener">https://docs.fd.io/hc2vpp/1.17.01-SNAPSHOT/release-notes-aggregator/release_notes.html#_install_guide</a> (will try to simplify the setup).</p> <p>cherry picked <a href="https://git.opendaylight.org/gerrit/#/c/52203/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/52203/</a></p> <p>Steps to reproduce:</p> <p>Add to software repositories:<br/> <a href="https://nexus.fd.io/content/repositories/fd.io.stable.1701.ubuntu.xenial.main/" class="external-link" target="_blank" rel="nofollow noopener">https://nexus.fd.io/content/repositories/fd.io.stable.1701.ubuntu.xenial.main/</a></p> <p>then install:</p> <p>sudo apt-get install vpp vpp-lib</p> <p>the start vpp:</p> <p>sudo service vpp start</p> <p>check:<br/> sudo vppctl show version<br/> sudo vppctl show int</p> <p>Download from honeycomb (if you want to change odl dependencies) and hc2vpp.</p> <p>Build hc2vpp and run it:<br/> sudo sh vpp-integration/minimal-distribution/target/vpp-integration-distribution-1.17.01-hc/vpp-integration-distribution-1.17.01/honeycomb-debug</p> <p>Debugging port is 5005.</p> <p>You can connect to honeycomb:<br/> ssh admin@localhost -p 2831 -s netconf</p> <p>Send hello message and run rpcs from file local0.txt (this file uses interface local0)</p> <p>Check if interface local0 exists and/or create it with postman.collection.json.</p> <p>Attachment local0.txt has been added with description: local0.txt file with requests to reproduce bug</p> <p>Attachment postman.collection.json has been added with description: postman.collection.json file</p> <p>In honeycomb project an hcv2vpp I used branch (stable/1701.</p> <p>honeycomb and hc2vpp sources can be downloaded from: <br/> <a href="https://gerrit.fd.io/r/#/admin/projects/" class="external-link" target="_blank" rel="nofollow noopener">https://gerrit.fd.io/r/#/admin/projects/</a></p> <p>In honeycomb master they use workaround:<br/> <a href="https://jira.fd.io/browse/HC2VPP-62" class="external-link" target="_blank" rel="nofollow noopener">https://jira.fd.io/browse/HC2VPP-62</a></p> <p>I also noticed that union types handling in general fails in our scenario<br/> (string type is choosen regardless type order or deserialization fails if <br/> there is no string type).</p> <p>Perhaps some simple model with union type would speed up issue identification.</p> <p>We use BindingToNormalizedNodeCodec for BA&lt;&gt;BI translation:</p> <p> StreamWriterGenerator serializerGenerator =<br/> new StreamWriterGenerator(JavassistUtils.forClassPool(ClassPool.getDefault()));<br/> BindingNormalizedNodeCodecRegistry codecRegistry = new BindingNormalizedNodeCodecRegistry(serializerGenerator);<br/> BindingRuntimeContext ctx = BindingRuntimeContext.create(mibCtx, mibCtx.getSchemaContext());<br/> codecRegistry.onBindingRuntimeContextUpdated(ctx);<br/> BindingToNormalizedNodeCodec codec = new BindingToNormalizedNodeCodec(mibCtx, codecRegistry);<br/> codec.onGlobalContextUpdated(mibCtx.getSchemaContext());</p> <p>...</p> <p>codec.fromNormalizedNode(id, data)</p> <p>BI data we deserialize is present in the full log<br/> (link attached in one of previous comments).<br/> Please let us know if you need to increase log level of some component.</p> <p>If it is not enough to reproduce issue with non HC environment,<br/> I can try to at least remove VPP from the picture.</p> <p>In Beryllium-2 it worked because there was always used string constructor to deserialize. Now there is type checking, so data must have correct type.</p> <p>Problem is probably somewhere outside mdsal.</p> <p>Hi,</p> <p>I tried to write test for this (added you to review) - <a href="https://git.opendaylight.org/gerrit/#/c/53067/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/53067/</a> - and it seems to be working for us (mdsal). Can you confirm this test?</p> <p>Thanks</p> <p>We use ModuleInfoBackedContext, except for that test looks good.<br/> But after updating your test still no exception...</p> <p>Codec and schema service is shared among various ODL componets,<br/> so perhaps issue is in how components interact.</p> <p>Will try to simplify the setup needed to reproduce issue...</p> <p>Here is simplified version of our setup with instructions how to reproduce issue:</p> <p><a href="https://gerrit.fd.io/r/#/c/5699/2" class="external-link" target="_blank" rel="nofollow noopener">https://gerrit.fd.io/r/#/c/5699/2</a></p> <p>I checked also SR3 snapshots:</p> <p><a href="https://gerrit.fd.io/r/#/c/5699/3" class="external-link" target="_blank" rel="nofollow noopener">https://gerrit.fd.io/r/#/c/5699/3</a></p> <p>and the issue is also present</p> <p>Codecs prepared in mdsal are used only in mdsal with specific input data. I added test to previous test<span class="error">&#91;0&#93;</span> - negative test - where input data (NormalizedNode) contains other type of value like it is defined by yang and I got your case with IllegalArgumentException. This mean, that you have to have good type of value in input data according to type of value define by yang. This is why you can't deserialize input data with string if there has to be int. Our codecs are OK + generated code from yangs is OK.</p> <p><span class="error">&#91;0&#93;</span> - <a href="https://git.opendaylight.org/gerrit/#/c/53264/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/53264/</a></p> <p>Looking at the log, I see the following:</p> <p>2017-02-08 09:57:18.527 CET <span class="error">&#91;netconf-netty-1&#93;</span> DEBUG o.o.y.b.d.c.i.UnionValueOptionContext - Codec org.opendaylight.yangtools.binding.data.codec.impl.EnumerationCodec@1b169815 failed to deserialize input 2420<br/> java.lang.IllegalArgumentException: Invalid enumeration value 2420. Valid values are <span class="error">&#91;any&#93;</span></p> <p>Based on the example case you have provided, this makes sense, your JSON has quotes around the number, which means it is a String and treated as such, hence the integer-based union members are immediately skipped and it hits EnumerationCodec directly.</p> <p>At some point we will need to parse values more strictly in the JSON/XML world, but that is a change we cannot do this late in the release.</p> <p>Looking at the codec infrastructure, though, I am failing to see how that string could have passed through.</p> <p>Are you getting the same results via RESTCONF and NETCONF?</p> <p>Looking at the various classes, I am not sure which codec we are hitting and they do have slight variances:</p> <p><a href="https://github.com/opendaylight/yangtools/blob/master/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/codec/UnionStringCodec.java" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/yangtools/blob/master/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/codec/UnionStringCodec.java</a></p> <p>does the wrong thing by returning the original string representation and it seems to be hooked into NETCONF.</p> <p><a href="https://github.com/opendaylight/yangtools/blob/master/yang/yang-data-util/src/main/java/org/opendaylight/yangtools/yang/data/util/AbstractStringUnionCodec.java" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/yangtools/blob/master/yang/yang-data-util/src/main/java/org/opendaylight/yangtools/yang/data/util/AbstractStringUnionCodec.java</a> seems to be doing the right thing (in most cases, I am not sure about edge cases) and is hooked into RESTCONF (for both XML and JSON).</p> <p>I am positive MD-SAL is off the hook and this needs to be fixed either in yangtools (by fixing the old codecs) or (better) netconf (by switching to yang-data-codec-xml).</p> <p>Can you guys confirm the following:</p> <p>1) this issue occurs when the data is introduced via RESTCONF (if HC has such a thing) (both XML and JSON formats)<br/> 2) which union codec is being used when the request is deserialized in EditConfig.parseIntoNormalizedNode()</p> <p>After we have the results we can decide which strategy to take.</p> <p>I stand corrected, netconf is still using yang-data-impl XML codecs across the board.</p> <p>This needs to gate Boron-3, because it is a regression from a previous release.</p> <p>master: <a href="https://git.opendaylight.org/gerrit/53297" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/53297</a></p> <p>(In reply to Robert Varga from comment #25)<br/> &gt; I stand corrected, netconf is still using yang-data-impl XML codecs across<br/> &gt; the board.</p> <p>Yeah, you are correct. Netconf and also Restconf is using data.impl.schema.transform parser/serializer infrastructure.</p> <p>boron: <a href="https://git.opendaylight.org/gerrit/53308" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/53308</a></p> <p>Verified with test patch <a href="https://gerrit.fd.io/r/#/c/5699/" class="external-link" target="_blank" rel="nofollow noopener">https://gerrit.fd.io/r/#/c/5699/</a>, no issue present</p> <p>(In reply to Jan Srnicek from comment #30)<br/> &gt; Verified with test patch <a href="https://gerrit.fd.io/r/#/c/5699/" class="external-link" target="_blank" rel="nofollow noopener">https://gerrit.fd.io/r/#/c/5699/</a>, no issue present<br/> + <a href="https://git.opendaylight.org/gerrit/#/c/53308/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/53308/</a></p> Development External issue ID 7759 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i0293r: