[YANGTOOLS-768] Unable to read root container with JsonParserStream

Sun, 10 Apr 2022 18:35:58 +0000

While exexuting following

public static ContainerNode readJson(@Nonnull final SchemaContext schemaContext,
@Nonnull final InputStream stream,
@Nonnull final SchemaNode parentSchema) {
final DataContainerNodeAttrBuilder<YangInstanceIdentifier.NodeIdentifier, ContainerNode> builder =
Builders.containerBuilder().withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(schemaContext.getQName()));
final NormalizedNodeStreamWriter writer = ImmutableNormalizedNodeStreamWriter.from(builder);

try (final JsonParserStream jsonParser = JsonParserStream.create(writer, schemaContext, parentSchema))

{ final JsonReader reader = new JsonReader(new InputStreamReader(stream, Charsets.UTF_8)); jsonParser.parse(reader); }

catch (IOException e)

{ LOG.warn("Unable to close json parser. Ignoring exception", e); }

return builder.build();
}

Where
schemaContext = valid schema context
stream(content of it) = ImmutableContainerNode{nodeIdentifier=(urn:opendaylight:params:xml:ns:yang:hc:test?revision=2015-01-05)simple-container, value=[ImmutableLeafNode{nodeIdentifier=(urn:opendaylight:params:xml:ns:yang:hc:test?revision=2015-01-05)simple-container-name, value=value2, attributes={}}], attributes={}}
parentSchema = its root container == schemaContext

Following error is showed

java.lang.IllegalArgumentException: Node (urn:ietf:params:xml:ns:netconf:base:1.0)data is not a simple type

at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
at org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.setValue(JsonParserStream.java:269)
at org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.read(JsonParserStream.java:178)
at org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.parse(JsonParserStream.java:99)
at io.fd.honeycomb.translate.util.JsonUtils.readJson(JsonUtils.java:95)
at io.fd.honeycomb.translate.util.JsonUtils.readJsonRoot(JsonUtils.java:83)
at io.fd.honeycomb.test.tools.ContainerNodeDataProcessor.getNodeData(ContainerNodeDataProcessor.java:74)
at io.fd.honeycomb.test.tools.YangDataProcessorRegistry.getNodeData(YangDataProcessorRegistry.java:61)
at io.fd.honeycomb.data.init.DiffFileTemplateImpl.deserializeUpdateModification(DiffFileTemplateImpl.java:186)
at io.fd.honeycomb.data.init.DiffFileTemplateImpl.stringToDataObjectUpdates(DiffFileTemplateImpl.java:110)
at io.fd.honeycomb.data.init.DiffFileTemplateImplTest.testStringToDataObjectUpdates(DiffFileTemplateImplTest.java:69)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

When digging to JsonParserStream code, i've probably discovered whats is the problem

public JsonParserStream parse(final JsonReader reader) {
...
// This is
final CompositeNodeDataWithSchema compositeNodeDataWithSchema = new CompositeNodeDataWithSchema(parentNode);
read(reader, compositeNodeDataWithSchema);
...
}

public void read(final JsonReader in, AbstractNodeDataWithSchema parent) throws IOException {
switch (in.peek()) {
case STRING:
case NUMBER:
setValue(parent, in.nextString());
break;
...

The problem is that first thig that setValue does is

Preconditions.checkArgument(parent instanceof SimpleNodeDataWithSchema, "Node %s is not a simple type",
parent.getSchema().getQName());

Which of course will fail becuase as shown in parse method, node is created
as CompositeNodeDataWithSchema.

OpenDaylight JIRA

[YANGTOOLS-768] Unable to read root container with JsonParserStream