<!-- 
RSS generated by JIRA (8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d) at Wed Feb 07 20:54:16 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>OpenDaylight JIRA</title>
    <link>https://jira.opendaylight.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.20.10</version>
        <build-number>820010</build-number>
        <build-date>22-06-2022</build-date>
    </build-info>


<item>
            <title>[YANGTOOLS-770] Some augments are not being processed</title>
                <link>https://jira.opendaylight.org/browse/YANGTOOLS-770</link>
                <project id="10188" key="YANGTOOLS">yangtools</project>
                    <description>&lt;p&gt;We are currently using a snapshot of Carbon of March 11.&lt;/p&gt;

&lt;p&gt;Some augments in the model of one of our devices are not being picked up it seems.   I have attached a minimal model to this ticket (which is the actual model, with all unnecessary parts removed, and with some types changed to string to avoid dragging in other models).&lt;/p&gt;

&lt;p&gt;The structure is as follows:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;ietf-interfaces defines:&lt;/li&gt;
	&lt;li&gt;container interfaces&lt;/li&gt;
	&lt;li&gt;list interface&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;bbf-sub-interfaces augments the interface with:&lt;/li&gt;
	&lt;li&gt;container frame-processing&lt;/li&gt;
	&lt;li&gt;container ingress-rule&lt;/li&gt;
	&lt;li&gt;list rule&lt;/li&gt;
	&lt;li&gt;container flexible-match&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;bbf-sub-interface-tagging has 2 augments:&lt;/li&gt;
	&lt;li&gt;an augment on flexible-match, which uses a grouping that defines:&lt;/li&gt;
	&lt;li&gt;choice vlan-tag-match-type&lt;/li&gt;
	&lt;li&gt;case match-all&lt;/li&gt;
	&lt;li&gt;leaf match-all&lt;/li&gt;
	&lt;li&gt;case untagged&lt;/li&gt;
	&lt;li&gt;leaf untagged&lt;/li&gt;
	&lt;li&gt;case vlan-tagged&lt;/li&gt;
	&lt;li&gt;list tag&lt;/li&gt;
	&lt;li&gt;leaf index&lt;/li&gt;
	&lt;li&gt;a second augment, on the &quot;tag&quot; added by the first augment, which again uses a grouping that defines:&lt;/li&gt;
	&lt;li&gt;container dot1q-tag   -&amp;gt; this dot1q-tag is not found in the parsed model&lt;br/&gt;
             ...&lt;/li&gt;
&lt;/ul&gt;



&lt;p&gt;The parsing is successful, no errors are generated, but the dot1q-tag of that last augment is not returned in the parsed model.&lt;/p&gt;</description>
                <environment>&lt;p&gt;Operating System: All&lt;br/&gt;
Platform: All&lt;/p&gt;</environment>
        <key id="23190">YANGTOOLS-770</key>
            <summary>Some augments are not being processed</summary>
                <type id="10104" iconUrl="https://jira.opendaylight.org/secure/viewavatar?size=xsmall&amp;avatarId=10303&amp;avatarType=issuetype">Bug</type>
                                                <status id="5" iconUrl="https://jira.opendaylight.org/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="pkajsa">Peter Kajsa</assignee>
                                    <reporter username="verthezpw">Peter Verthez</reporter>
                        <labels>
                    </labels>
                <created>Fri, 31 Mar 2017 12:26:31 +0000</created>
                <updated>Sun, 10 Apr 2022 18:35:59 +0000</updated>
                            <resolved>Mon, 10 Apr 2017 07:01:24 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="44407" author="verthezpw" created="Fri, 31 Mar 2017 12:26:31 +0000"  >&lt;p&gt;Attachment augmentbug.tgz has been added with description: minimized model showing the bug&lt;/p&gt;</comment>
                            <comment id="44405" author="pkajsa" created="Mon, 3 Apr 2017 09:33:43 +0000"  >&lt;p&gt;There is an issue with mandatory nodes. Yang parser complains that &quot;leaf tag-type&quot; cannot be added by the augment because &quot;leaf tag-type&quot; is mandatory and augment target is in different module (please see attached log entry below).&lt;/p&gt;

&lt;p&gt;After quick investigation I think the leaf can be added, because &quot;choice vlan-tag-match-type&quot; is not mandatory node and in consequence &quot;container match-criteria&quot; is also not mandatory. So we need to fix the check of mandatory nodes in yang statement parser. We also need to increase severity of the log from debug to error.  &lt;/p&gt;

&lt;p&gt;org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl - Failed to add augmentation /home/pkajsa/eclipse_workspace/yangtools/yang/yang-parser-impl/target-ide/test-classes/bugs/bug8126/bbf-frame-classification.yang:128:16 defined at /home/pkajsa/eclipse_workspace/yangtools/yang/yang-parser-impl/target-ide/test-classes/bugs/bug8126/bbf-sub-interface-tagging.yang:28:4&lt;br/&gt;
org.opendaylight.yangtools.yang.parser.spi.meta.InferenceException: An augment cannot add node &apos;tag-type&apos; because it is mandatory and in module different than target &lt;span class=&quot;error&quot;&gt;&amp;#91;at /home/pkajsa/eclipse_workspace/yangtools/yang/yang-parser-impl/target-ide/test-classes/bugs/bug8126/bbf-frame-classification.yang:35:12&amp;#93;&lt;/span&gt;&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.spi.meta.InferenceException.throwIf(InferenceException.java:47)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition.checkForMandatoryNodes(AugmentStatementImpl.java:301)&lt;br/&gt;
	at java.util.ArrayList.forEach(ArrayList.java:1249)&lt;br/&gt;
	at java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1080)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition.checkForMandatoryNodes(AugmentStatementImpl.java:298)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition.validateNodeCanBeCopiedByAugment(AugmentStatementImpl.java:267)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition.copyStatement(AugmentStatementImpl.java:249)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition.copyFromSourceToTarget(AugmentStatementImpl.java:224)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition$1.apply(AugmentStatementImpl.java:147)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.reactor.ModifierImpl.applyAction(ModifierImpl.java:100)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.reactor.ModifierImpl.tryApply(ModifierImpl.java:160)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.reactor.SourceSpecificContext.tryToProgress(SourceSpecificContext.java:350)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.reactor.SourceSpecificContext.tryToCompletePhase(SourceSpecificContext.java:328)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.completePhaseActions(BuildGlobalContext.java:359)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.executePhases(BuildGlobalContext.java:200)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.buildEffective(BuildGlobalContext.java:211)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction.buildEffective(CrossSourceStatementReactor.java:189)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.stmt.StmtTestUtils.parseYangSources(StmtTestUtils.java:121)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.stmt.StmtTestUtils.parseYangSources(StmtTestUtils.java:138)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.stmt.StmtTestUtils.parseYangSources(StmtTestUtils.java:187)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.stmt.StmtTestUtils.parseYangSources(StmtTestUtils.java:177)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.stmt.StmtTestUtils.parseYangSources(StmtTestUtils.java:153)&lt;br/&gt;
	at org.opendaylight.yangtools.yang.stmt.Bug8126Test.test(Bug8126Test.java:18)&lt;/p&gt;</comment>
                            <comment id="44406" author="pkajsa" created="Thu, 6 Apr 2017 08:46:57 +0000"  >&lt;p&gt;&lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/54365/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/54365/&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="13078" name="augmentbug.tgz" size="3088" author="verthezpw" created="Fri, 31 Mar 2017 12:26:31 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_11400" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10208" key="com.atlassian.jira.plugin.system.customfieldtypes:textfield">
                        <customfieldname>External issue ID</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>8126</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10201" key="com.atlassian.jira.plugin.system.customfieldtypes:url">
                        <customfieldname>External issue URL</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[https://bugs.opendaylight.org/show_bug.cgi?id=8126]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10206" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Issue Type</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10300"><![CDATA[Bug]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10204" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>ODL SR Target Milestone</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10336"><![CDATA[Carbon-RC0]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10000" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i0299z:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>