https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-787 yangtools <p>New XML parser (residing in yang-data-codec-xml) assumes that yang-modeled data in the parsed XML source are wrapped in a yang-independent root element which is not correct. Actually, the root element of such XML document should represent a specific yang data node defined in the provided yang model.</p> <p>Operating System: All<br/> Platform: All</p> YANGTOOLS-787

New XML parser design flaw

Bug Resolved Done Igor Foltin Igor Foltin Tue, 13 Jun 2017 09:05:05 +0000 Sun, 10 Apr 2022 18:36:00 +0000 Mon, 24 Jul 2017 07:58:43 +0000 0 1 <p>Another issue with the XML parser is the SchemaNode parameter that is used when<br/> creating an XmlParserStream instance. Currently, it represents a schema<br/> node that is the parent node of the root XML element. However, this<br/> parameter should correspond to the root XML element itself.</p> <p>Fix: <a href="https://git.opendaylight.org/gerrit/#/c/59036/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/59036/</a></p> <p>Follow-up fix for the BGPCEP project:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/59268/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/59268/</a></p> <p>Actually, ignore the first two comments.</p> <p>It is irrelevant if the root XML element corresponds to the SchemaNode parentNode parameter or not. The SchemaNode parameter represents the parent SchemaNode of the YANG-modeled data that are wrapped inside the root XML element.</p> <p>The actual flaw is that the parser wraps the parentNode parameter inside a CompositeNodeDataWithSchema which emits only its child nodes into the provided NormalizedNodeStreamWriter. The parentNode itself is not emitted which is a problem.</p> <p>Here is an example which illustrates the issue.<br/> Let's say we have a YANG module which looks like this:</p> <p>module foo {</p> <p> ...</p> <p> container foo-cont { list foo-list </p> {...} <p> }</p> <p> ...</p> <p>}</p> <p>We want to parse the foo-cont node, so we provide a corresponding foo-cont ContainerSchemaNode as the parentNode parameter to the XmlParserStream.</p> <p>Now, imagine we have an XML source which looks like this:</p> <p>&lt;foo-cont xmlns="foo"&gt; <br/> &lt;foo-list&gt; ...some other nodes... &lt;/foo-list&gt;<br/> &lt;/foo-cont&gt;</p> <p>If we parse this XML into a NormalizedNode tree, we will end up with a root NormalizedNode which corresponds to the foo-list node. However, it should be the foo-cont node.</p> <p>Therefore we need to check the parentNode type and put it into a corresponding ...NodeDataWithSchema.<br/> In the example above, it would be a ContainerNodeDataWithSchema.</p> Development External issue ID 8675 External issue URL ODL SR Target Milestone Rank 0|i029dr: