https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-794 yangtools <p>This could be K4 related, to reproduce:</p> <p>1) Install latest master K4 controller from nexus:<br/> <a href="https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/karaf/0.7.0-SNAPSHOT/" class="external-link" target="_blank" rel="nofollow noopener">https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/karaf/0.7.0-SNAPSHOT/</a></p> <p>2) Install feature: odl-openflowplugin-flow-services-rest</p> <p>3) Start mininet 1 switch: sudo mn --controller=remote,ip=192.168.0.1 --topo linear,1</p> <p>4) Do GET <a href="http://192.168.0.1:8181/restconf/operational/network-topology:network-topology/" class="external-link" target="_blank" rel="nofollow noopener">http://192.168.0.1:8181/restconf/operational/network-topology:network-topology/</a> using HTTP headers: Accept=application/xml, Content-Type=application/xml</p> <p>Controller hangs, only soultion is restart controller.</p> <p>Operating System: All<br/> Platform: All</p> YANGTOOLS-794

Get OF Topology in XML hangs controller in Nitrogen

Bug Resolved Done Unassigned Luis Gomez Wed, 5 Jul 2017 17:45:25 +0000 Sun, 10 Apr 2022 18:36:00 +0000 Wed, 26 Jul 2017 09:20:42 +0000 0 3 <p>It works for JSON, but hangs for XML, so I do not think that this issue is OpenFlowPlugin related at all. Maybe it is restconf related?</p> <p>We need karaf.log and probably a thread dump.</p> <p>Also, what does 'controller hangs' mean?</p> <p>I just tried this, the REST request hangs and I can perform other REST requests but the controller goes crazy in CPU even when I cancel the original request.</p> <p>There is nothing out of normal in karaf log and I attach the thread dump.</p> <p>Attachment thread_dump.txt has been added with description: Thread dump</p> <p>"qtp181445460-221" #221 prio=5 os_prio=0 tid=0x00007f18241d3000 nid=0x175c runnable <span class="error">&#91;0x00007f17b1ee6000&#93;</span><br/> java.lang.Thread.State: RUNNABLE<br/> at java.lang.String.intern(Native Method)<br/> at com.sun.org.apache.xerces.internal.util.SymbolTable$Entry.&lt;init&gt;(SymbolTable.java:448)<br/> at com.sun.org.apache.xerces.internal.util.SymbolTable.addSymbol0(SymbolTable.java:195)<br/> at com.sun.org.apache.xerces.internal.util.SymbolTable.addSymbol(SymbolTable.java:176)<br/> at com.sun.xml.internal.stream.writers.XMLStreamWriterImpl$NamespaceContextImpl.getNamespaceURI(XMLStreamWriterImpl.java:2051)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.RandomPrefix.alreadyUsedPrefix(RandomPrefix.java:66)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.RandomPrefix.encodePrefix(RandomPrefix.java:55)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.RandomPrefixInstanceIdentifierSerializer.prefixForNamespace(RandomPrefixInstanceIdentifierSerializer.java:34)<br/> at org.opendaylight.yangtools.yang.data.util.AbstractNamespaceCodec.appendQName(AbstractNamespaceCodec.java:45)<br/> at org.opendaylight.yangtools.yang.data.util.AbstractStringInstanceIdentifierCodec.serialize(AbstractStringInstanceIdentifierCodec.java:51)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.SchemaAwareXMLStreamWriterUtils.writeInstanceIdentifier(SchemaAwareXMLStreamWriterUtils.java:41)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.XMLStreamWriterUtils.write(XMLStreamWriterUtils.java:149)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.XMLStreamWriterUtils.writeValue(XMLStreamWriterUtils.java:103)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.XMLStreamWriterUtils.writeValue(XMLStreamWriterUtils.java:79)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.SchemaAwareXMLStreamNormalizedNodeStreamWriter.writeValue(SchemaAwareXMLStreamNormalizedNodeStreamWriter.java:51)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.SchemaAwareXMLStreamNormalizedNodeStreamWriter.writeValue(SchemaAwareXMLStreamNormalizedNodeStreamWriter.java:32)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.XMLStreamNormalizedNodeStreamWriter.writeElement(XMLStreamNormalizedNodeStreamWriter.java:179)<br/> at org.opendaylight.yangtools.yang.data.codec.xml.SchemaAwareXMLStreamNormalizedNodeStreamWriter.leafNode(SchemaAwareXMLStreamNormalizedNodeStreamWriter.java:90)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessAsSimpleNode(NormalizedNodeWriter.java:145)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:101)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:223)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:97)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter$OrderedNormalizedNodeWriter.writeMapEntryNode(NormalizedNodeWriter.java:283)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:208)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:97)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:238)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:97)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter$OrderedNormalizedNodeWriter.writeMapEntryNode(NormalizedNodeWriter.java:283)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:208)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:97)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:238)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:97)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:195)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:97)<br/> at org.opendaylight.netconf.sal.rest.impl.RestconfDelegatingNormalizedNodeWriter.write(RestconfDelegatingNormalizedNodeWriter.java:37)<br/> at org.opendaylight.netconf.sal.rest.impl.RestconfDelegatingNormalizedNodeWriter.write(RestconfDelegatingNormalizedNodeWriter.java:19)<br/> at org.opendaylight.netconf.sal.rest.impl.NormalizedNodeXmlBodyWriter.writeNormalizedNode(NormalizedNodeXmlBodyWriter.java:127)<br/> at org.opendaylight.netconf.sal.rest.impl.NormalizedNodeXmlBodyWriter.writeTo(NormalizedNodeXmlBodyWriter.java:104)<br/> at org.opendaylight.netconf.sal.rest.impl.NormalizedNodeXmlBodyWriter.writeTo(NormalizedNodeXmlBodyWriter.java:52)<br/> at com.sun.jersey.spi.container.ContainerResponse.write(ContainerResponse.java:306)<br/> at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1479)<br/> at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)<br/> at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)<br/> at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)<br/> at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)<br/> at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)<br/> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)</p> <p>Looks like RandomPrefix incorrectly processes the result of NamespaceContext.getNamespaceURI().</p> <p>In case it helps, here is the json output for the request that fais in XML:</p> <p>{<br/> "network-topology": {<br/> "topology": [<br/> {<br/> "topology-id": "flow:1",<br/> "node": [<br/> {<br/> "node-id": "openflow:1",<br/> "opendaylight-topology-inventory:inventory-node-ref": "/opendaylight-inventory:nodes/opendaylight-inventory:node<span class="error">&#91;opendaylight-inventory:id=&#39;openflow:1&#39;&#93;</span>",<br/> "termination-point": [<br/> </p> { "tp-id": "openflow:1:LOCAL", "opendaylight-topology-inventory:inventory-node-connector-ref": "/opendaylight-inventory:nodes/opendaylight-inventory:node[opendaylight-inventory:id='openflow:1']/opendaylight-inventory:node-connector[opendaylight-inventory:id='openflow:1:LOCAL']" } <p>,</p> { "tp-id": "openflow:1:1", "opendaylight-topology-inventory:inventory-node-connector-ref": "/opendaylight-inventory:nodes/opendaylight-inventory:node[opendaylight-inventory:id='openflow:1']/opendaylight-inventory:node-connector[opendaylight-inventory:id='openflow:1:1']" } <p> ]<br/> }<br/> ]<br/> }<br/> ]<br/> }<br/> }</p> <p>This also may have to do with RESTCONF's use of namespace repairing. It should not be needing that, I think.</p> <p>Maybe we should be checking the XMLWriter instance configuration?</p> <p>after performed investigation I have suspicios that maybe this loop (<a href="https://github.com/opendaylight/yangtools/blob/master/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/codec/xml/RandomPrefix.java#L54" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/yangtools/blob/master/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/codec/xml/RandomPrefix.java#L54</a>) runs infinitely, but I am not sure yet...</p> <p>master: <a href="https://git.opendaylight.org/gerrit/60736" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/60736</a></p> <p>This looks like a bug in JDK, as the return value does not seem to conform to javadoc (which states that for unbound prefixes an empty string should be returned).</p> <p>In fact javax.xml.bind.DatatypeConverterImpl in jdk-1.8.0.131 on line 403 says:</p> <p> uri = nsc.getNamespaceURI(prefix);<br/> // uri can never be null according to javadoc,<br/> // but some users reported that there are implementations that return null.<br/> if (uri == null || uri.length() == 0) // crap. the NamespaceContext interface is broken.<br/> // error: unbound prefix</p> { throw new IllegalArgumentException("prefix " + prefix + " is not bound to a namespace"); } Development External issue ID 8803 External issue URL Issue Type ODL SR Target Milestone Rank 0|i029fb: