https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-821 yangtools <p>LeafRefContext.validateNodeData() looks like it cant process augmentation nodes, <br/> or at least when Augmentation Node enters it, it fails on </p> <p>java.lang.UnsupportedOperationException: Augmentation node has no QName<br/> at org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier$AugmentationIdentifier.getNodeType(YangInstanceIdentifier.java:651) ~<span class="error">&#91;yang-data-api-1.1.2-Carbon.jar:na&#93;</span><br/> at org.opendaylight.yangtools.yang.data.impl.schema.nodes.AbstractImmutableNormalizedNode.getNodeType(AbstractImmutableNormalizedNode.java:27) ~<span class="error">&#91;yang-data-impl-1.1.2-Carbon.jar:na&#93;</span><br/> at org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefValidatation.validateNodeData(LeafRefValidatation.java:251) ~<span class="error">&#91;yang-data-impl-1.1.2-Carbon.jar:na&#93;</span><br/> at org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefValidatation.validateNodeData(LeafRefValidatation.java:241) ~<span class="error">&#91;yang-data-impl-1.1.2-Carbon.jar:na&#93;</span><br/> at org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefValidatation.validateNodeData(LeafRefValidatation.java:270) ~<span class="error">&#91;yang-data-impl-1.1.2-Carbon.jar:na&#93;</span><br/> at org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefValidatation.validateNodeData(LeafRefValidatation.java:241) ~<span class="error">&#91;yang-data-impl-1.1.2-Carbon.jar:na&#93;</span><br/> at org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefValidatation.validateNode(LeafRefValidatation.java:95) ~<span class="error">&#91;yang-data-impl-1.1.2-Carbon.jar:na&#93;</span><br/> at org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefValidatation.validate0(LeafRefValidatation.java:73) ~<span class="error">&#91;yang-data-impl-1.1.2-Carbon.jar:na&#93;</span><br/> at org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefValidatation.validate(LeafRefValidatation.java:59) ~<span class="error">&#91;yang-data-impl-1.1.2-Carbon.jar:na&#93;</span></p> <p>From looking at the method, support for augmentations is missing, in that case it falls back to MapNode logic and fails with exception above</p> <p><b>Appears in 1.1.2-Carbon</b></p> YANGTOOLS-821

LeafRefContext fails to process augmentations

Bug Medium Resolved Done Marek Gradzki Jan Srnicek Fri, 20 Oct 2017 12:10:11 +0000 Sun, 10 Apr 2022 18:36:02 +0000 Tue, 24 Jul 2018 00:43:44 +0000 1.1.2 2.0.5 2.0.9 2.0.6.1 0 3 <p>We need the models and data used to reproduce this issue.</p> <p>Here is example of config that fails to validate:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-xml"> <span class="code-tag">&lt;bgp xmlns=<span class="code-quote">"http://openconfig.net/yang/bgp"</span>&gt;</span> <span class="code-tag">&lt;peer-groups&gt;</span> <span class="code-tag">&lt;peer-group&gt;</span> <span class="code-tag">&lt;peer-group-name&gt;</span>application-peers<span class="code-tag">&lt;/peer-group-name&gt;</span> <span class="code-tag">&lt;/peer-group&gt;</span> <span class="code-tag">&lt;/peer-groups&gt;</span> <span class="code-tag">&lt;neighbors&gt;</span> <span class="code-tag">&lt;neighbor&gt;</span> <span class="code-tag">&lt;neighbor-address&gt;</span>10.25.1.9<span class="code-tag">&lt;/neighbor-address&gt;</span> <span class="code-tag">&lt;config&gt;</span> <span class="code-tag">&lt;peer-group&gt;</span>application-peers<span class="code-tag">&lt;/peer-group&gt;</span> <span class="code-tag">&lt;/config&gt;</span> <span class="code-tag">&lt;/neighbor&gt;</span> <span class="code-tag">&lt;/neighbors&gt;</span> <span class="code-tag">&lt;/bgp&gt;</span> </pre> </div></div> <p>Where peer-group is defined in openconfig-bgp@2015-10-09.yang as:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-comment">// add peer-group pointer only <span class="code-keyword">for</span> the neighbor list </span> augment /bgp/neighbors/neighbor/config { description "Augmentation to allow association of a neighbor with a peer-group"; uses bgp-neighbor-peer-group_config; } grouping bgp-neighbor-peer-group_config { [...] leaf peer-group { type leafref { <span class="code-comment">// we are at /bgp/neighbors/neighbor/ </span> path <span class="code-quote">"/bgp/peer-groups/peer-group/peer-group-name"</span>; <span class="code-comment">//TODO: require-instance should be added when it's </span> <span class="code-comment">//supported in YANG 1.1 </span> <span class="code-comment">//require-instance <span class="code-keyword">true</span>; </span> } description <span class="code-quote">"The peer-group with which <span class="code-keyword">this</span> neighbor is associated"</span>; } } </pre> </div></div> <p>Failing unit test (honeycomb):</p> <p><a href="https://gerrit.fd.io/r/#/c/13292/" class="external-link" target="_blank" rel="nofollow noopener">https://gerrit.fd.io/r/#/c/13292/</a></p> <p>More complex example, based on ODL BGP Oxygen User Guide, uses openconfig-network-instance:protocol augmentation defined in bgp-openconfig-extensions@2017-12-07 for configuration of neighbors:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-xml"> <span class="code-tag">&lt;bgp xmlns=<span class="code-quote">"http://openconfig.net/yang/bgp"</span>&gt;</span> <span class="code-tag">&lt;peer-groups&gt;</span> <span class="code-tag">&lt;peer-group&gt;</span> <span class="code-tag">&lt;peer-group-name&gt;</span>application-peers<span class="code-tag">&lt;/peer-group-name&gt;</span> <span class="code-tag">&lt;/peer-group&gt;</span> <span class="code-tag">&lt;/peer-groups&gt;</span> <span class="code-tag">&lt;/bgp&gt;</span> <span class="code-tag">&lt;network-instances xmlns=<span class="code-quote">"http://openconfig.net/yang/network-instance"</span>&gt;</span> <span class="code-tag">&lt;network-instance&gt;</span> <span class="code-tag">&lt;name&gt;</span>global-bgp<span class="code-tag">&lt;/name&gt;</span> <span class="code-tag">&lt;config&gt;</span> <span class="code-tag">&lt;name&gt;</span>global-bgp<span class="code-tag">&lt;/name&gt;</span> <span class="code-tag">&lt;/config&gt;</span> <span class="code-tag">&lt;protocols&gt;</span> <span class="code-tag">&lt;protocol&gt;</span> <span class="code-tag">&lt;identifier <span class="code-keyword">xmlns:x</span>=<span class="code-quote">"http://openconfig.net/yang/policy-types"</span>&gt;</span>x:BGP<span class="code-tag">&lt;/identifier&gt;</span> <span class="code-tag">&lt;name&gt;</span>hc-bgp-instance<span class="code-tag">&lt;/name&gt;</span> <span class="code-tag">&lt;config&gt;</span> <span class="code-tag">&lt;name&gt;</span>hc-bgp-instance<span class="code-tag">&lt;/name&gt;</span> <span class="code-tag">&lt;identifier <span class="code-keyword">xmlns:x</span>=<span class="code-quote">"http://openconfig.net/yang/policy-types"</span>&gt;</span>x:BGP<span class="code-tag">&lt;/identifier&gt;</span> <span class="code-tag">&lt;/config&gt;</span> <span class="code-tag">&lt;bgp xmlns=<span class="code-quote">"urn:opendaylight:params:xml:ns:yang:bgp:openconfig-extensions"</span>&gt;</span> <span class="code-tag">&lt;neighbors&gt;</span> <span class="code-tag">&lt;neighbor&gt;</span> <span class="code-tag">&lt;neighbor-address&gt;</span>10.25.1.9<span class="code-tag">&lt;/neighbor-address&gt;</span> <span class="code-tag">&lt;config&gt;</span> <span class="code-tag">&lt;peer-group&gt;</span>application-peers<span class="code-tag">&lt;/peer-group&gt;</span> <span class="code-tag">&lt;/config&gt;</span> <span class="code-tag">&lt;/neighbor&gt;</span> <span class="code-tag">&lt;/neighbors&gt;</span> <span class="code-tag">&lt;/bgp&gt;</span> <span class="code-tag">&lt;/protocol&gt;</span> <span class="code-tag">&lt;/protocols&gt;</span> <span class="code-tag">&lt;/network-instance&gt;</span> <span class="code-tag">&lt;/network-instances&gt;</span> </pre> </div></div> <p>LeafRefValidatation.validate fails to validate the config with the same exception as in the issue description.</p> <p>Fix:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/74338/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/74338/</a></p> <p>Tests are using XmlParserStream (much easier to test + compatibility with XML parser is something we are interested in),<br/> so they could not be placed in yang-data-impl (would introduce circular dependency).</p> <p>Robert, is there a better place for them than yang-data-codec-xml?</p> <p>Couple of nitpicks in review, otherwise it looks good.</p> <p>The test suite is just fine as it is – we can move it down a notch when we refactor yang-data-impl.</p> Development Rank 0|i036r3: