https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-848 yangtools <p>An action can be added in an augment or a grouping, like a DataSchemaNode.  </p> <p>But there are no methods isAugmenting and isAddedByUses available on ActionDefinition, like there is on DataSchemaNode.   This is an omission in the API.</p> <p>The same would be applicable for NotificationDefinition.</p> YANGTOOLS-848

No methods isAugmenting and isAddedByUses available on ActionDefinition

Bug Medium Resolved Won't Do Unassigned Peter Verthez Fri, 16 Feb 2018 11:30:00 +0000 Thu, 22 Feb 2018 08:05:30 +0000 Tue, 20 Feb 2018 10:03:31 +0000 parser 0 2 <p>Both these methods are marked as deprecated, as they are a leak from declared to effective model. As such they are only used by MDSAL's binding generator, which does not handle actions nor non-root notifications, as far as I can tell. What exactly is the use case for them?</p> <p>We have a converter from YANG to YIN (loosely based on YinExportUtils in ODL, but since that was not complete at that time we wrote our own).   That needs to know whether an action is added by augmentation or uses, to be able to regenerate the content of a module properly.</p> <p>Proper implementation of YIN module export does not actually require any of this. If your implementation requires those bits, they can be derived given the whole-Module visibility, hence I suggest you do that in your implementation, as introducing these methods:</p> <ul> <li>goes directly against the direction we want to take</li> <li>introduces more coupling in yang parser</li> <li>adds maintenance burden</li> </ul> <p>Can you clarify then how we can derive that?</p> <p>For example: isAugmenting() means that either the node has a different namespace (i.e. augment from another module) or there is a corresponding augment statement in current module. isAddedByUses() is similar.</p> Development Rank 0|i03ahj: