https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-895 yangtools <p>Hello.</p> <p>There is a problem with parsing MAC address from json</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> Caused by: java.lang.IllegalArgumentException: Value <span class="code-quote">'00:00:00:00:00:00'</span> does not match regular expression <span class="code-quote">'^[0-9a-fA-F]{2}(:[0-9a-fA-F]{2}){5}$'</span> at org.opendaylight.yangtools.yang.data.impl.codec.CompiledPatternContext.validate(CompiledPatternContext.java:48) at org.opendaylight.yangtools.yang.data.impl.codec.StringPatternCheckingCodec.validate(StringPatternCheckingCodec.java:39) at org.opendaylight.yangtools.yang.data.impl.codec.StringStringCodec.deserialize(StringStringCodec.java:43) at org.opendaylight.yangtools.yang.data.impl.codec.StringStringCodec.deserialize(StringStringCodec.java:22) at org.opendaylight.yangtools.yang.data.codec.gson.AbstractJSONCodec.parseValue(AbstractJSONCodec.java:34) at org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.translateValueByType(JsonParserStream.java:341) at org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.setValue(JsonParserStream.java:335) at org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.read(JsonParserStream.java:240) at org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.read(JsonParserStream.java:300) at org.opendaylight.yangtools.yang.data.codec.gson.JsonParserStream.parse(JsonParserStream.java:163)</pre> </div></div> <p>But the pattern actually matches the string.</p> <p> </p> <p>When java.util.regex.Pattern is created, I found out that it receives pattern string</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> ^(?:\^[0-9a-fA-F]{2}(:[0-9a-fA-F]{2}){5}\$)$ </pre> </div></div> <p>instead of what is defined in yang file</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> ^[0-9a-fA-F]{2}(:[0-9a-fA-F]{2}){5}$ </pre> </div></div> <p> </p> <p>I am using 2.0.6 version but checked also 2.0.7 and 2.0.10 and it happened too.</p> <p>yang-data-codec-gson-2.0.6.jar</p> YANGTOOLS-895

MAC address does not match regular expression pattern

Bug Highest Resolved Won't Do Robert Varga Michal Banik Fri, 24 Aug 2018 10:34:24 +0000 Mon, 27 Aug 2018 17:00:45 +0000 Mon, 27 Aug 2018 16:51:41 +0000 2.0.6 2.0.7 2.0.10 codecs 0 2 <p>What is the corresponding model?</p> <p>This is not a bug, your model is wrong – YANG regular expressions are implicitly anchored and '^' and '$' are normal characters. Fix your models.</p> <p>sorry I forgot to mention the model</p> <p> </p> <p>I uses openconfig models <ins><em>openconfig-if-ethernet.yang</em></ins> - leaf <em>mac-address</em> has type <em>oc-yang:mac-address</em> from <ins><em>openconfig-yang-types.yang</em></ins></p> <p>mac-address is defined:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> typedef mac-address { type string { pattern <span class="code-quote">'^[0-9a-fA-F]{2}(:[0-9a-fA-F]{2}){5}$'</span>; } description <span class="code-quote">"An IEEE 802 MAC address"</span>; } </pre> </div></div> <p> </p> <p><b>I still think there is a bug.</b></p> <p> </p> <p>Actually, the pattern string that is in yang model</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">final</span> Pattern pattern = Pattern.compile(<span class="code-quote">"^[0-9a-fA-F]{2}(:[0-9a-fA-F]{2}){5}$"</span>); pattern.matcher(<span class="code-quote">"00:00:00:00:00:00"</span>).matches(); </pre> </div></div> <p>returns</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">true</span> </pre> </div></div> <p>but, the pattern string that is actually set in pattern instance in <em>CompiledPatternContext</em> class</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">final</span> Pattern pattern = Pattern.compile(<span class="code-quote">"^(?:\\^[0-9a-fA-F]{2}(:[0-9a-fA-F]{2}){5}\\$)$"</span>); pattern.matcher(<span class="code-quote">"00:00:00:00:00:00"</span>).matches(); </pre> </div></div> <p>returns</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">false</span></pre> </div></div> <p> </p> <p> </p> <p>OpenConfig is violating RFC7950 section 9.4.5, as detailed in <a href="https://github.com/openconfig/public/issues/44" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/openconfig/public/issues/44</a> . In the context of YANG specification, pattern statement argument is interpreted according to <a href="https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/#regexs" class="external-link" target="_blank" rel="nofollow noopener">https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/#regexs</a> . That specifically means that both caret and ampersand are character literals – and for the purposes of use with java.util.regex.Pattern are escaped.</p> <p>POSIX (used by OpenConfig), XSD (used by YANG) and java.util.regex.Pattern regular expressions, while sharing basic concepts and basic lexical structure in simple cases, are not interchangeable in the general sense.</p> Development Rank 0|i03i3r: