https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/YANGTOOLS-961 yangtools <p>Current integration of NormalizedNodes and XML attributes is tacky in multiple ways:</p> <ul> <li>ImmutableNormalizedNodeStreamWriter completely ignores attributes</li> <li>attribute streaming is bolted on as a separate NormalizedNodeStreamWriter interface</li> <li>attributes are Map&lt;QName,String&gt; pairs, which means they are not normalized</li> <li>the integration completely ignores RFC7952 guidance</li> <li>attributes do not contribute to hashCode/equals</li> </ul> <p>The only user of attributes is NETCONF, which uses yang.data.api.ModifyAction, a manifestation of RFC6241 Section 7.2 – which should be easy to update.</p> <p> </p> YANGTOOLS-961

Integrate NormalizedNodes with RFC7952 metadata/attributes

Task Medium Resolved Done Robert Varga Robert Varga Thu, 28 Feb 2019 10:16:46 +0000 Thu, 4 Apr 2019 17:59:45 +0000 Thu, 4 Apr 2019 17:59:45 +0000 3.0.0 data-impl 0 1 <p>RFC7952 defines metadata annotations as a separate entity which semantically attaches to some data in a way which is compatible with XML attributes. Annotations are defined to not affect the data itself, but provide additional information (such as originating store in ietf-origin.yang) and can potentially be unrelated to the data itself (example-last-modified).</p> <p>When we consider how this would play out in case of DataTree interactions, it is obvious that attributes are <b>not</b> part of NormalizedNode structure, but rather are a separate metadata tree whose layout mirrors NormalizedNodes. This means that a DataTree instance would maintain it separately, perhaps exposing an interface which would allow querying the metadata and data tree in unison or separately.</p> <p>We therefore need to decouple yang.data.api.AttributesContainer from NormalizedNode implementations and reshape it in terms of a TreeNode structure – MetadataTree (or somesuch). This has the benefit of allowing the lifecycle to be disconnected, and thus the same NormalizedNode structure being attached to different MetadataTree.</p> <p>In terms of NormalizedNodeStreamWriter and its events, though, the two trees should be fused, so that metadata in concert with data – i.e. event sources would walk both trees at the same time, emitting metadata content before emitting data content (to match XML semantics) and receivers would either directly emit it (XML, JSON container), cache-and-emit (JSON leaf), place it it a separate structure (ImmutableNormalizedNodeStreamWriter with metadata) or discard it (ImmutableNormalizedNodeStreamWriter with plain NormalizedNode result).</p> Blocks YANGTOOLS-960 MDSAL-357 Relates YANGTOOLS-369 Development Rank 0|i03muf: