Uploaded image for project: 'bgpcep'
  1. bgpcep
  2. BGPCEP-864

BGP parser does not support Errata 4493

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Highest Highest
    • Neon, Sodium, Fluorine SR3
    • None
    • BGP
    • None

      https://www.rfc-editor.org/errata_search.php?eid=4493 defines 0 code for header and update errors, but we do not have them defined, leading to a splat:

      2019-03-06T09:24:44,587 | WARN  | epollEventLoopGroup-12-5 | BGPSessionImpl                   | 237 - org.opendaylight.bgpcep.bgp-rib-impl - 0.11.0 | BGP session encountered error
      io.netty.handler.codec.DecoderException: java.lang.IllegalArgumentException: BGP Error code 3 and subcode 0 not recognized.
      	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:472) ~[?:?]
      	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:278) ~[?:?]
      	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:323) [57:io.netty.codec:4.1.31.Final]
      	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:297) [57:io.netty.codec:4.1.31.Final]
      	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1434) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:965) [62:io.netty.transport:4.1.31.Final]
      	at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:799) [63:io.netty.transport-native-epoll:4.1.31.Final]
      	at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:433) [63:io.netty.transport-native-epoll:4.1.31.Final]
      	at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:330) [63:io.netty.transport-native-epoll:4.1.31.Final]
      	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:897) [59:io.netty.common:4.1.31.Final]
      	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [59:io.netty.common:4.1.31.Final]
      	at java.lang.Thread.run(Thread.java:748) [?:?]
      Caused by: java.lang.IllegalArgumentException: BGP Error code 3 and subcode 0 not recognized.
      	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:300) ~[?:?]
      	at org.opendaylight.protocol.bgp.parser.BGPError.forValue(BGPError.java:167) ~[?:?]
      	at org.opendaylight.protocol.bgp.parser.impl.message.BGPNotificationMessageParser.parseMessageBody(BGPNotificationMessageParser.java:84) ~[?:?]
      	at org.opendaylight.protocol.bgp.parser.impl.message.BGPNotificationMessageParser.parseMessageBody(BGPNotificationMessageParser.java:31) ~[?:?]
      	at org.opendaylight.protocol.bgp.parser.spi.pojo.SimpleMessageRegistry.parseBody(SimpleMessageRegistry.java:32) ~[?:?]
      	at org.opendaylight.protocol.bgp.parser.spi.AbstractMessageRegistry.parseMessage(AbstractMessageRegistry.java:66) ~[?:?]
      	at org.opendaylight.protocol.bgp.rib.impl.BGPByteToMessageDecoder.decode(BGPByteToMessageDecoder.java:47) ~[?:?]
      	at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:502) ~[?:?]
      	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:441) ~[?:?]
      	... 19 more

      This obscures our ability to properly log the cease cause.

            rovarga Robert Varga
            rovarga Robert Varga
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: