Uploaded image for project: 'controller'
  1. controller
  2. CONTROLLER-2085

Do not use RpcService in Controller components

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Medium Medium
    • 9.0.0
    • None
    • None

      A quick grep shows at least these users of deprecated API:

      ./controller/benchmark/dsbenchmark/src/main/java/org/opendaylight/dsbenchmark/DsbenchmarkProvider.java:        rpcReg = rpcService.registerRpcImplementation(DsbenchmarkService.class, this);
      ./controller/benchmark/ntfbenchmark/src/main/java/ntfbenchmark/impl/NtfbenchmarkProvider.java:        reg = rpcService.registerRpcImplementation(NtfbenchmarkService.class, this);
      ./controller/benchmark/rpcbenchmark/src/main/java/rpcbenchmark/impl/GlobalBindingRTCServer.java:        reg = rpcProvider.registerRpcImplementation(RpcbenchPayloadService.class, this);
      ./controller/benchmark/rpcbenchmark/src/main/java/rpcbenchmark/impl/RoutedBindingRTCServer.java:        reg = rpcProvider.registerRpcImplementation(RpcbenchPayloadService.class, this, paths);
      ./controller/benchmark/rpcbenchmark/src/main/java/rpcbenchmark/impl/RpcbenchmarkProvider.java:        reg = providerRegistry.registerRpcImplementation(RpcbenchmarkService.class, this);
      ./controller/opendaylight/md-sal/eos-dom-akka/src/main/java/org/opendaylight/controller/eos/akka/AkkaEntityOwnershipService.java:        reg = rpcProvider.registerRpcImplementation(OdlEntityOwnersService.class, this);
      ./controller/opendaylight/md-sal/sal-cluster-admin-impl/src/main/java/org/opendaylight/controller/cluster/datastore/admin/OSGiClusterAdmin.java:        reg = rpcProviderService.registerRpcImplementation(ClusterAdminService.class,
      ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        doReturn(newReg).when(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class),
      ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        doReturn(oldReg).when(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class),
      ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        inOrder.verify(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class),
      ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        inOrder.verify(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class),
      ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        verify(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class),
      ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/BasicRpcTestProvider.java:        rpcRegistration = rpcProviderRegistry.registerRpcImplementation(BasicRpcTestService.class, this);
      ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/CarProvider.java:        regs.add(rpcProviderService.registerRpcImplementation(CarService.class, this));
      ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/MdsalLowLevelTestProvider.java:        registration = rpcRegistry.registerRpcImplementation(OdlMdsalLowlevelControlService.class, this);
      ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/PeopleProvider.java:                regs.add(rpcProviderService.registerRpcImplementation(CarPurchaseService.class, rpcImplementation,
      ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/PeopleProvider.java:        regs.add(rpcProviderService.registerRpcImplementation(CarPurchaseService.class, rpcImplementation));
      ./controller/opendaylight/md-sal/samples/toaster-provider/src/main/java/org/opendaylight/controller/sample/toaster/provider/OpendaylightToaster.java:        reg = rpcProviderService.registerRpcImplementation(ToasterService.class, this);
      

      Convert them to yang.binding.Rpc-based implementations.

            ojo Oleksandr Zharov
            rovarga Robert Varga
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: