Uploaded image for project: 'mdsal'
  1. mdsal
  2. MDSAL-544

DOMNotificationRouter does not guard against Exception being thrown

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Medium Medium
    • 4.0.14, 6.0.1, 5.0.11
    • None
    • DOM runtime
    • None

      2020-01-20T12:11:30,739
       | ERROR | DOMNotificationRouter-disruptor-0 | 
      FatalExceptionHandler            | 109 - com.lmax.disruptor - 3.4.2 | 
      Exception processing: 17740 org.opendaylight.mdsal.dom.broker.DOMNotificationRouterEvent@5636abf1
      java.lang.NullPointerException: null
                      at c.a.e.c.o.s.CtlrEventTaskExecutor.processNetconfEvent(CtlrEventTaskExecutor.java:362) ~[?:?]
                      at c.a.e.c.o.s.CtlrEventTaskExecutor.execute(CtlrEventTaskExecutor.java:212) ~[?:?]
                      at c.a.e.c.o.s.CtlrEventsListenerImpl.onEvent(CtlrEventsListenerImpl.java:47) ~[?:?]
                      at 
      org.opendaylight.mdsal.binding.dom.adapter.invoke.NotificationListenerInvoker.invokeNotification(NotificationListenerInvoker.java:111)
       ~[?:?]
                      at 
      org.opendaylight.mdsal.binding.dom.adapter.BindingDOMNotificationListenerAdapter.onNotification(BindingDOMNotificationListenerAdapter.java:44)
       ~[?:?]
                      at 
      org.opendaylight.mdsal.dom.broker.DOMNotificationRouterEvent.deliverNotification(DOMNotificationRouterEvent.java:48)
       ~[?:?]
                      at 
      org.opendaylight.mdsal.dom.broker.DOMNotificationRouter.lambda$static$24(DOMNotificationRouter.java:75)
       ~[?:?]
                      at 
      com.lmax.disruptor.BatchEventProcessor.processEvents(BatchEventProcessor.java:168)
       [109:com.lmax.disruptor:3.4.2]
                      at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:125) [109:com.lmax.disruptor:3.4.2]

      this ends up killing the thread – which should have caused the entire platform to die, but I guess the environment is not set up for that.

      We can lower this to a warning and continue processing.

            rovarga Robert Varga
            rovarga Robert Varga
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: